----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102629/#review6550 -----------------------------------------------------------
hmm, so doubleclicking on a textshape, pictureshape,pathshape,videoshap,musicshape, will add a textshape . I don't think your rationale is valid for anything besides a very confined set of users. Also the hack around karbon looks rather hacky inside a plugin. Remember that there might be other apps out there that uses flake and dont want this behaviour either. - Casper On Sept. 16, 2011, 9:29 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102629/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2011, 9:29 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Changed double click behavior of default tool. Previously double click on a > path shape will enter path edit mode, but more often user expect creating a > text box on the shape. Now double click will create a textbox on the shape in > all applications except karbon, which is more concentrated on graphic editing. > > > Diffs > ----- > > libs/flake/KoTosContainer.h a2162f0 > plugins/defaultTools/defaulttool/DefaultTool.cpp ccfce0e > > Diff: http://git.reviewboard.kde.org/r/102629/diff > > > Testing > ------- > > Runs correctly on each app. But when moving textshape attached shapes there > are some flickers when updating the textshape. > > > Thanks, > > Yue > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
