----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/#review3918 -----------------------------------------------------------
Ship it! looks ok to me - Casper On June 15, 2011, 4:16 p.m., Sebastian Sauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101631/ > ----------------------------------------------------------- > > (Updated June 15, 2011, 4:16 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > The problem is that incrementing the fragment-iterator after we marked the > end-FrameIterator does result us in skipping the incremented text-fragment. > So, the idea is to increment it before setting the end-FrameIterator to have > the text-fragment still included in the area before doing the page-break. > > This fixes https://bugs.kde.org/show_bug.cgi?id=275709 > > The question is if there is a more elegant and logical way to handle this. > > > Diffs > ----- > > libs/textlayout/KoTextLayoutArea.cpp 37f1395 > > Diff: http://git.reviewboard.kde.org/r/101631/diff > > > Testing > ------- > > > Thanks, > > Sebastian > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
