Re: Review Request 126128: Port EqualizerDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126128/#review88842 --- Ship it! Ship It! - Ralf Engels On Nov. 21, 2015, 3:02

Re: Review Request 126128: Port EqualizerDialog

based on? What is the last commit you see with "git log"? Also here is something to read for providing patches: http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html - Ralf Engels On Nov. 21, 2015, 3:02 nachm., Olivier

Re: Review Request 126128: Port EqualizerDialog

get rid of the usage of a KDE dialog where a "plain" Qt dialog is sufficient? - Ralf Engels On Nov. 21, 2015, 3:02 nachm., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 122226: Some I18N fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/16/#review75170 --- Ship it! great. - Ralf Engels On Jan. 23, 2015, 5:44

Re: Review Request 119659: GSoC Review request 2: Fetching lrc from ttplayer webservice

strange comments. Also, at least this function needs a lot more comments and readable variable names to be maintainable. - Ralf Engels On Aug. 8, 2014, 10:04 vorm., Vedant Agarwala wrote: > > --- > This is an automatically generat

Re: [amarok] src: Refactoring: Using the same delegate almost everywhere in the browser

Am Dienstag, 26. Februar 2013, 13:29:53 schrieb Matěj Laitl: > On 22. 2. 2013 Ralf Engels wrote: > > Git commit 730583c601404719102ba92f72d07ab9ae14ade1 by Ralf Engels. > > > > Refactoring: Using the same delegate almost everywhere in the browser > > After using Amarok

Re: [amarok] src: Fix: "Local collection" text label is truncated with large font

some time but you won't notice the difference afterwards. Really, trust me :) I will have a look at the other places. Am Donnerstag, 21. Februar 2013, 00:37:16 schrieb Matěj Laitl: > On 20. 2. 2013 Ralf Engels wrote: > > Git commit 1600c2e58036301d09b8bd13a5392d83d43b

Re: Fwd: Another bug in equalizer

mitted on 2012-01-22 by Ralf Engels which seems to have caused some problem. Now equalizer shows (i+1)th preset on requesting i th present. For example, on requesting 'Classical' preset, the equalizer shows the values of 'Club' preset. So I request you to confirm the bug. Fur

Re: Review Request 108686: hidden items in context menu: usability question

h dangerous and > > without precedent. Conversely, moving to trash can be undone quite easily. > > Is this not sufficient? > > > > Regards, > > Wyatt > > Bjoern Balazs wrote: > +1 > > Ralf Engels wrote: > I agree. > Hidden menu en

Re: Review Request 108964: Added 3 different seek options (with customizable seek lengths)

> On Feb. 16, 2013, 10:26 a.m., Ralf Engels wrote: > > src/configdialog/dialogs/PlaybackConfig.ui, line 220 > > <http://git.reviewboard.kde.org/r/108964/diff/2/?file=114090#file114090line220> > > > > Could you extend the whatsThis text to indicate what keybo

Re: Review Request 108686: hidden items in context menu: usability question

> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Review Request 108964: Added 3 different seek options (with customizable seek lengths)

<http://git.reviewboard.kde.org/r/108964/#comment20670> Could you extend the whatsThis text to indicate what keyboard modificators you need to get a "short" "medium" and "long" seek. - Ralf Engels On Feb. 15, 2013, noon, Anmol Ahuja wrote: > > -

Re: Review Request 107476: clear filter history

ially since it's cleaned at every restart. It's sometimes hard to realize (and more so after a lot of work has been invested) that sometimes a nice functionality just isn't worth the increased code complexity, translation and maintenance effort. - Ralf Engels On Nov. 26, 201

Re: Review Request: Layout changes to organize collection, guess metadata, edit filter and edit playlist layout dialogs

don't make it this wide > > in any case. I didn't make it a combo, but you are right. Radio boxes would probably be better. - Ralf --- This is an automatically generated e-mail. To reply, visit: http://git

Review Request: Layout changes to organize collection, guess metadata, edit filter and edit playlist layout dialogs

7624/s/879/ Old Guess Tag Dialog http://git.reviewboard.kde.org/r/107624/s/880/ New Guess Tag Dialog http://git.reviewboard.kde.org/r/107624/s/881/ Old Edit Filter Dialog http://git.reviewboard.kde.org/r/107624/s/882/ New Edit Filter Dialog http://git.reviewboard.kde.org/r/107624/s/883/ Tha

Re: Review Request: Track statistics refactor (intended to be merged ASAP)

- > > (Updated Sept. 18, 2012, 3:52 p.m.) > > > Review request for Amarok, Bart Cerneels and Ralf Engels. > > > Description > --- > > {Tag,Url}StatisticsStore: fix dates not read/saved due to wrong format used > in sql > > ...we should really

Re: Review Request: Use multiple inheritance to get an implementation for statistics handling

> > 3. Change the name of the StatisticsProvider. Google the provider > pattern for an enlightning read. This is not a provider and we shouldn't call > it such. > > Alternative: ditch StatisticsProvider. Let's first discuss about the functionality. (and not

Re: Review Request: Use multiple inheritance to get an implementation for statistics handling

ttern for an enlightning read. This is not a provider and we shouldn't call it such. - Ralf --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106276/#review18709

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

> On Aug. 28, 2012, 2:15 p.m., Ralf Engels wrote: > > src/core/support/Amarok.cpp, line 153 > > <http://git.reviewboard.kde.org/r/101015/diff/5/?file=81271#file81271line153> > > > > Again i18n. The tricky thing with "hh:mm" is that not all countri

Review Request: Use multiple inheritance to get an implementation for statistics handling

.h b478c87 tests/mocks/MockTrack.h 57bc344 Diff: http://git.reviewboard.kde.org/r/106276/diff/ Testing --- Thanks, Ralf Engels ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

e tricky thing with "hh:mm" is that not all countries use a leading zero for the hour. At least Qt is already handling 12/24 hour. To circumvent the problem use Qt::TimeSpec again. Here is a nice Wiki page: http://en.wikipedia.org/wiki/Category:Date_and_time_representation_by_coun

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

> On Aug. 17, 2012, 12:31 p.m., Ralf Engels wrote: > > Please have a look at the diff in reviewboard. Trailing spaces are > > hightlighted in red. Nobody likes them. > > > > Also the basic issue is still open. > > We have signals that get send whenever a track

Re: Review Request: Restore heuristics to guess whether album is a compilation

> On Aug. 16, 2012, 12:15 p.m., Ralf Engels wrote: > > Just going through all the review requests again. > > > > With your patch the following auto test is failing: > > testIdentifyCompilationInMultipleDirectories > > Alexey Neyman wrote: > Which is,

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101015/#review17595 --- - Ralf Engels On July 30, 2012, 8:17 p.m., Conrad Hübler

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

r is (as far as I know) not single shot. So you just do something hoping that eventually works. - Ralf Engels On July 30, 2012, 8:17 p.m., Conrad Hübler wrote: > > --- > This is an automatically generated e-mai

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

still valid? Can we reject it? - Ralf Engels On June 11, 2012, 1:26 p.m., Zhengliang Feng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

still valid? Can we reject it? - Ralf Engels On June 11, 2012, 1:26 p.m., Zhengliang Feng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Some changes to make Amarok appearance more pretty

> On May 26, 2012, 3:23 p.m., Ralf Engels wrote: > > This is outstanding since quite some time. > > I liked it somehow. > > > > What is the current state? There was a question open, can that be solved? S

Re: Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

what the reason for this change request is (displaying something different somewhere, why?) and the change is done at the wrong place (it breaks the model instead of just changing the view). - Ralf Engels On Feb. 23, 2012, 4:49 p.m., Claudio Desideri

Re: Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

what the reason for this change request is (displaying something different somewhere, why?) and the change is done at the wrong place (it breaks the model instead of just changing the view). - Ralf Engels On Feb. 23, 2012, 4:49 p.m., Claudio Desideri

Re: Review Request: Restore heuristics to guess whether album is a compilation

> On Aug. 16, 2012, 12:15 p.m., Ralf Engels wrote: > > Just going through all the review requests again. > > > > With your patch the following auto test is failing: > > testIdentifyCompilationInMultipleDirectories > > Alexey Neyman wrote: > Which is,

Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

> On April 22, 2012, 5:28 p.m., Matěj Laitl wrote: > > This makes sense, give me some time to test it and think about it. Thought about it? Should we ship it? - Ralf --- This is an automatically generated e-mail. To reply, visit: http:/

Re: Review Request: Proof of Concepts implementation for the Amarok Current Track Model

4> Comments missing. What is a CTrack? What does it do, where is it used. - Ralf Engels On April 18, 2012, 5:43 p.m., Saurabh Sood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request: KWallet for Magnatune credentials

just asking a question. But you could also just do a "show" and allow the user to do other stuff before answering the question about the wallet. src/services/magnatune/MagnatuneConfig.cpp <http://git.reviewboard.kde.org/r/104480/#comment13742> And here you even adde

Re: Review Request: GPodder Improvements Patch Rev2

? If yes, I would commit it. - Ralf Engels On March 25, 2012, 8:34 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Proof of concept for the 2012 GSoC project idea 'Semantic Collection for Amarok'.

ck to the files. Search would not work (since the search is done in the sql database and the rating is not longer written there) and so on. How about a real Nepumuk backed collection not using sql at all? I would like to reject this request if you agree. - Ralf Engels On March 22, 2012, 4:5

Re: Review Request: Restore heuristics to guess whether album is a compilation

patch the following auto test is failing: testIdentifyCompilationInMultipleDirectories - Ralf Engels On March 16, 2012, 12:13 a.m., Alexey Neyman wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: Restore heuristics to guess whether album is a compilation

patch the following auto test is failing: testIdentifyCompilationInMultipleDirectories - Ralf Engels On March 16, 2012, 12:13 a.m., Alexey Neyman wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: Playing albums (adding delay)

> On Feb. 28, 2012, 9:12 a.m., Myriam Schweingruber wrote: > > Any news on this? Please update the patch or remove it. Could you make this an option / setting? There is place in the settings dialog -> playback -> general. Why exactly 8 seconds? Configurable? I can't currently see a wish for tha

Re: Review Request: mysql embedded default options

> On May 25, 2011, 7:30 p.m., Ralf Engels wrote: > > A summary of this discussion. Please check the correct answer. > > A: this patch is still fine and should be shipped > > B: this patch is working around a known bug and should be shipped > > C: this patch is workin

Re: Review Request: Fetch cover for DAAP Albums #240060

> On May 18, 2011, 9:37 p.m., Ralf Engels wrote: > > Just wanted to apply the patch (finally, sorry) but it doesn't apply > > cleanly any more. > > > > Also I noticed that there is not much magic in it, just implementing the > > virtual members, and I am

Re: Review Request: Preview of live scanning feature

er again. That's why we had the code below. - Ralf Engels On Feb. 23, 2012, 2:25 p.m., Ville Ranki wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request: Extend the scope of the playground

d. If somebody want's to play around we can do a branch on the kde git server, a WIP review request or something else. The "playground" stuff is unmaintained since years. - Ralf Engels On Feb. 17, 2012, 2:53 a.m., Ryan McCoskrie wrote: > >

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

y who is actually using podcasts to try this out before committing it. - Ralf Engels On Feb. 8, 2012, 11:15 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Support for equalizer scripts and plugins. WIP.

ttp://git.reviewboard.kde.org/r/102798/#comment13708> The "isXxx" naming convention comes from Qt as you can get confusing names if you don't do that. How do we continue? Is this ready to be submitted? What is the actual functionality? Can you also add a line for the ChangeLog.txt? -

Re: Review Request: Partial Rewrite of ID3v2TagHelper.cpp

" content of the patch is quite slim. It would be just some small format changes. Also you didn't answer my question: Do the auto tests still run? Please indicate what you want to do with the request. - Ralf Engels

Re: Review Request: Fix crash when closing Amarok with running CoverFetcher

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105942/#review17141 --- On Aug. 9, 2012, 10:36 a.m., Ralf Engels wrote: > > -

Review Request: Fix crash when closing Amarok with running CoverFetcher

/CompoundProgressBar.cpp 371a534 Diff: http://git.reviewboard.kde.org/r/105942/diff/ Testing --- Change is verified by me to fix the problem. Thanks, Ralf Engels ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request: Add playlist export action to Playlist Dock save action.

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105824/#review17100 ------- On Aug. 2, 2012, 12:14 p.m., Ralf Engels wrote: > > ---

Review Request: Add playlist export action to Playlist Dock save action.

action to Playlist Dock save action. Diffs - src/playlist/PlaylistDock.cpp ae1644f Diff: http://git.reviewboard.kde.org/r/105824/diff/ Testing --- Thanks, Ralf Engels ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org

Review Request: Add export action to UserPlaylists

--- Thanks, Ralf Engels ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Moving Tab-toolbars to the top

Hi all, I noticed that our toolbars are all over the place. The context and the playlist view have toolbars at the bottom. The media tab has the toolbar at the top. Now I think that this is confusing and especially bad in case of the playlist where we have some options at the top and then a tool

Re: Review Request: SqlScanResultProcessor: fix data-loss bug; squashed commits, recent on top

really feeling brave enought you can push it. - Ralf Engels On July 10, 2012, 2:54 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

lements a function that is not documented and could be surprising for the user in some corner cases. - Ralf Engels On July 12, 2012, 2:15 p.m., Matěj Laitl wrote: > > --- > This is an automatically ge

Re: [amarok] src: Fix DynamicModel test

a QWidget is currently blocking five test cases. On 07/12/2012 12:44 PM, ext Matěj Laitl wrote: On 11. 7. 2012 Ralf Engels wrote: Git commit 0066525f8d299a22509818e3814eafd08202945d by Ralf Engels. Committed on 10/07/2012 at 11:03. Pushed by rengels into branch 'master'. Fix Dynamic

Re: Review Request: SqlScanResultProcessor: fix data-loss bug; squashed commits, recent on top

cases to check for the current problems. Also I am working on a solution for the database schema as you can see from the database table .svg file in the docs directory. - Ralf Engels On July 10, 2012, 2:54 p.m., Matěj Laitl wrote

Re: Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

itself. Now the description() function does not return the description any longer. - Ralf Engels On Feb. 23, 2012, 4:49 p.m., Claudio Desideri wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: Make sure Amarok can enqueue local files of all supported Media types in the playlist.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103694/#review14184 --- Still waiting for feedback - Ralf Engels On Jan. 14

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

I understand, this means that if Amarok is not playing it will still update the recent played widget every 60 seconds triggering a repaint for the widget. Could you maybe just trigger one last update and then not use up cpu power? - Ralf Engels On March 2

Re: Review Request: Some changes to make Amarok appearance more pretty

. What is the current state? There was a question open, can that be solved? - Ralf Engels On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

693/#comment11212> There is a block linking the taglib just a few lines previously. Around 922 Why do you need that here? - Ralf Engels On April 22, 2012, 5:25 p.m., Mathias Stephan Panzenböck wrote: > > ---

Re: Review Request: Restore heuristics to guess whether album is a compilation

> On March 18, 2012, 9:39 p.m., Ralf Engels wrote: > > Are the unit test running? > > > > There is one specific scenario that the current scanner is handling (since > > years. No new change). > > > > ITunes stile collections put tracks from the sa

Re: Review Request: Restore heuristics to guess whether album is a compilation

> On March 18, 2012, 9:39 p.m., Ralf Engels wrote: > > Are the unit test running? > > > > There is one specific scenario that the current scanner is handling (since > > years. No new change). > > > > ITunes stile collections put tracks from the sa

Re: Review Request: Restore heuristics to guess whether album is a compilation

unit test I am all for committing the fix. Also you might want to make a new unit test to prevent somebody later on to change the behaviour for the worse. - Ralf Engels On March 16, 2012, 12:13 a.m., Alexey Neyman wrote: > > --- &

Re: Re: Incremental scanning (Bart Cerneels)

> Date: Mon, 6 Feb 2012 10:20:29 +0100 > From: Bart Cerneels > To: amarok-devel > Subject: Re: Incremental scanning > Message-ID: > > Content-Type: text/plain; charset=ISO-8859-1 > > On Wed, Feb 1, 2012 at 14:31, Ville Ranki wrote: > > > > Hello, > > > > I've been implementing increment

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

::podcastType() const« war versteckt [-Woverloaded-virtual] /home/ralf/src/amarok/src/playlistmanager/SyncedPodcast.h:39:13: Warnung: von »int SyncedPodcast::podcastType()« [-Woverloaded-virtual] You need to correct that too. If you don't see the warnings then please do a debug build. - Ralf E

Re: Review Request: Enable find as you type support in the playlist

also hard to discover. If one would read the code, one would not readily understand why the code is there and what it does. So I would say that we include it if it's better commented. Could you add more comments? Maybe even for the class to describe the complete key event behaviour? - Ralf E

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

); should be valid. See http://doc.trolltech.com/4.6/qabstractitemmodel.html#beginInsertRows - Ralf Engels On Jan. 19, 2012, 9:23 p.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: Rework transcoding: CollectionLocation asks user, not caller of prepareCopy()

ally care about that for now. - Ralf Engels On Jan. 21, 2012, 12:47 a.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.r

Re: Review Request: MetaFile: guess album artist as in SQL collection scanner, MemoryCollection: use also album artist as identifying key in album map (2 commits squelched just for reviewboard)

sed in the Collection. Still, the patch is good. Ship it. - Ralf Engels On Jan. 17, 2012, 2:10 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request: Visualization with projectM

and afterwards Christmas :) Anyway, can you make it so that it compiles when the audiodatacenter visualm libraries are not present. Conditional compilation with #ifdef and so on. - Ralf Engels On Aug. 25, 2011, 9:23 a.m., Alessandro Siniscalchi wrote

Re: Review Request: Fix Inconsistencies with Organize Files Dialog when canceling Dialog

> On May 15, 2011, 11:12 a.m., Ralf Engels wrote: > > This request has been lying around unchanged for quite some time. > > > > The patch doesn't look that bad but what about the discussions? > > Nobody seemed to miss an "Add preset" button till now,

Re: Review Request: Prevent FavoredRandomTrackNavigator choosing files chosen very recently (fix bug 244442)

will ship it unless someone vetos. - Ralf Engels On July 2, 2011, 4:55 p.m., Brendon Higgins wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

ur times. Please make a function out of it. You might call it longTrackName( Meta::TrackPtr track ) or something like this. - Ralf Engels On Sept. 10, 2011, 10:26 p.m., Ryan McCoskrie wrote: > > --- > This is an

Re: Review Request: Line feed nedeed because the label makes window too wide

. - Ralf Engels On Nov. 30, 2011, 7:49 p.m., Pavel Punegov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Review Request: Remove setUidUrl function from EditCapability

://git.reviewboard.kde.org/r/103704/diff/diff Testing --- All test cases executed. Compiled and running. Thanks, Ralf Engels ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add an absolute date filter

seems to be static. - Ralf Engels On Dec. 26, 2011, 8:50 p.m., Daniel Faust wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request: Some changes to make Amarok appearance more pretty

mment8156> Same here. i18np - Ralf Engels On Jan. 4, 2012, 12:52 a.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request: Make sure Amarok can enqueue local files of all supported Media types in the playlist.

busy wait. Drain on processor. I don't have the details but I perfere an other solution. - Ralf Engels On Jan. 14, 2012, 2:20 p.m., Shlomi Fish wrote: > > --- > This is an automatically generated e-mail.

Re: Amarok-devel Digest, Vol 56, Issue 4

Hi Panzi, Can you please do two things: 1. start Amarok with "gdb --args amarok --debug --nofork" When amarok hangs you can "ctr-c" the debugger and get a stack trace. 2. Since you are saying "since a few days" it might be possible to find the offending commit. Can you try to find that? Maybe w

New Dynamic playlist pros and cons and suggestions

Hi Alex, I implemented most of the new dynamic playlists. For a start, let's state the idea behind the update of playlists. The "old" dynamic playlists were considered complex and confusing. Especially the percentages were seen as "at least that much" when in fact they were "of all the songs exact

Re: Review Request: Adds GPL notices to a couple of files.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102187/#review5361 --- Ship it! I support patches that make the code better. Even if i

Re: Review Request: Partial Rewrite of ID3v2TagHelper.cpp

org/r/102055/ > --- > > (Updated July 22, 2011, 11:48 p.m.) > > > Review request for Amarok and Ralf Engels. > > > Summary > --- > > Rewrite if else else if Constructs to switch statements > > Add common Frame Names to m_fieldMap > >

Re: Amarok is bugging udisks-daemon

Hi Andreas, Previously Amarok was frequently checking the modification time of all collection directories to check for changes. Since 2.4.1 we are using the KDirWatcher. That's probably what you are seeing. The solution of constantly checking modification times is very primitive. The KDirWatcher

Re: Re: New Dynamic Playlist

Hi Lukas, On Fr, 2011-06-24 at 16:29 +0300, Lukas wrote: > Hi Ralf, > > On 24 June 2011 15:27, Ralf Engels wrote: > Hi Lukas, > I wanted to write a point by point review here but let's first > start > like this: > >

Re: DJ playlist

Hi Cedric, That is currently not possible. This might even be a case where a static playlist would make sense. The Dynamic Playlist UI is quite easy currently but on the other hand some people say that it's much to complex and geeky. Considering this, I would say, we rather don't add this featur

Re: Bug 263640

Hi Lydia, it's still open and as far as I know nobody is working on it. I would say that Amarok should inform the user (at startup or later) when tracks are in the playlist that are not physically available. So I would say a new function "checkForStaleFiles" in the Amarok class maybe (or playlist

e: Re: New Dynamic Playlist

... > > I personally don't want to belittle Ralph's work at all. I think the > new treeview for the dynamic playlists look very nice. Much respect > for that. And I'm sure if you understand the concepts well that it's > nice to use. > However I think we will not get anywhere with trying to use the

Re: Re: New Dynamic Playlist

Hi Myriam, Valorie I am wondering. Which of the many improvements suck? - The example biases which demonstrate to a novice user some of the features and are instantly usable? - The removal/merging of the three bias categories into one short list? - The simplification into a tree-widget that su

Re: added:today not working in current git

> Date: Thu, 26 May 2011 17:36:31 +0200 > From: Mathias Panzenb?ck > Subject: added:today not working in current git > To: Amarok > Message-ID: <4dde737f.8030...@gmx.net> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > I just wanted to note that the collection query "added:to

Re: Review Request: Last.fm scrobbling using composer (back again)

> On May 25, 2011, 7:28 p.m., Ralf Engels wrote: > > The description of the configuration option seems to be wrong. > > It says "use composer field" where in reality it is "using the composer > > field as artist" which only makes sense for classical tra

Re: Review Request: Podcast episode filename configuration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/#review3524 --- Ship it! Appart from the added spaces at the end of the lines i

Re: Review Request: mysql embedded default options

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100345/#review3523 --- A summary of this discussion. Please check the correct answer. A

Re: Review Request: Last.fm scrobbling using composer (back again)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100806/#review3522 --- The description of the configuration option seems to be wrong. I

Re: Review Request: Add autoscroll function to the lyrics applet.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101155/#review3491 --- Ship it! Diff looks fine, Will submit it unless I see a Veto.

Re: Review Request: Crash when browsing a category [@ CollectionTreeItem::row]

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100723/#review3432 --- Ship it! Just debugged a Magnatune crash and you were right. J

Re: Review Request: Fetch cover for DAAP Albums #240060

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100176/#review3396 --- Just wanted to apply the patch (finally, sorry) but it doesn't a

Re: Review Request: Playing albums (adding delay)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100837/#review3394 --- src/playlist/navigators/RandomAlbumNavigator.cpp

Re: Review Request: Trivial cosmetic fix to context view 'albums' applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100805/#review3392 --- Ship it! Looks sensible. Will be submitted until somebody else

Re: Review Request: Coverbling applet size/resize issues

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100791/#review3391 --- Ship it! The patch looks sensible, but I can't test the cover b

  1   2   >