> On Aug. 28, 2012, 2:15 p.m., Ralf Engels wrote: > > src/core/support/Amarok.cpp, line 153 > > <http://git.reviewboard.kde.org/r/101015/diff/5/?file=81271#file81271line153> > > > > Again i18n. The tricky thing with "hh:mm" is that not all countries use > > a leading zero for the hour. At least Qt is already handling 12/24 hour. > > > > To circumvent the problem use Qt::TimeSpec again. > > Conrad Hübler wrote: > Ok, but I actually have no idea. Should amarok.cpp provide serveral > return-statments, depending on the country or is the kde architecture able to > handle this with just make the time translatable by using something like: > > i18nc( "track was played within this day", "Today %1", i18nc( "time in > hh:mm", datetime.toString("hh:mm").toUtf8()));
Your solution is correct. The translators will then take care of the correct localized time format. However, I think the following is easier: i18nc( "track was played within this day", "Today %1", datetime.time().toString(Qt::DefaultLocaleShortDate) ); I haven't tried it, but I think it should work. - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101015/#review18161 ----------------------------------------------------------- On Aug. 26, 2012, 5:28 p.m., Conrad Hübler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101015/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2012, 5:28 p.m.) > > > Review request for Amarok. > > > Description > ------- > > The recentlyplayedtracks-widget from the current track applet does not update > the last played time of recently played tracks. It now happens, every 60000 > msec and after amarok stops. > > It is just a hack for the next release making this applet working as it > should, but it is not a proper solution for this problem. > > > Diffs > ----- > > src/core/support/Amarok.h d8c91e7 > src/core/support/Amarok.cpp 7541124 > src/context/applets/currenttrack/CurrentTrack.h e023e91 > src/context/applets/currenttrack/CurrentTrack.cpp aa83a66 > src/context/applets/currenttrack/currentTrackSettings.ui c006384 > src/context/widgets/RecentlyPlayedListWidget.h 37032cb > src/context/widgets/RecentlyPlayedListWidget.cpp 3b7bd72 > > Diff: http://git.reviewboard.kde.org/r/101015/diff/ > > > Testing > ------- > > > Thanks, > > Conrad Hübler > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
