----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104049/#review17517 -----------------------------------------------------------
Can you explain a little more what "live scanning" means? Currently I see different issues: 1. The scanner is started as soon as changes in the collection directory are notices. However because the way the scanner is working it will first enumerate all directories and then scan them. That means that further changes will go unnoticed. 2. The scan result processor is (because of performance issues and because it needs to have a complete overview of all files) waiting to commit changes. That is in my opinion the problem with the "live" scanning. src/core-impl/collections/db/ScanManager.h <http://git.reviewboard.kde.org/r/104049/#comment13710> We have git for old code. Keep the code base clean by removing the outdated code. utilities/collectionscanner/CollectionScanner.cpp <http://git.reviewboard.kde.org/r/104049/#comment13711> If the scanner app crashes it should re-start without writing the header again. That's why we had the code below. - Ralf Engels On Feb. 23, 2012, 2:25 p.m., Ville Ranki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104049/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2012, 2:25 p.m.) > > > Review request for Amarok. > > > Description > ------- > > This is a preview of work i've been doing to implement live scanning. > Currently it can do full scan > and add found tracks to database during the scan. Removing missing files is > not yet implemented. Also partial > scan may not work as expected. > > > Diffs > ----- > > src/core-impl/collections/db/ScanManager.h 5f0d153 > src/core-impl/collections/db/ScanManager.cpp 97d0b1c > src/core-impl/collections/db/ScanResultProcessor.cpp 4f02a16 > src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp 6699b98 > src/scanner/GenericScanManager.cpp 215f78b > utilities/collectionscanner/CollectionScanner.h 6bbc757 > utilities/collectionscanner/CollectionScanner.cpp 74b57a6 > utilities/collectionscanner/Directory.cpp 66b3a9b > > Diff: http://git.reviewboard.kde.org/r/104049/diff/ > > > Testing > ------- > > "Works on my pc" on a small test collection. > > > Thanks, > > Ville Ranki > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
