----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100998/#review10254 -----------------------------------------------------------
I get a couple of warnings. I have seen that you have corrected the const-ness of a couple of functions. However you did not correct the ones of the parent class which will cause the wrong functions to be called. The warnings look like this: /home/ralf/src/amarok/src/core/podcasts/PodcastMeta.h:235:21: Warnung: »virtual int Podcasts::PodcastChannel::podcastType() const« war versteckt [-Woverloaded-virtual] /home/ralf/src/amarok/src/playlistmanager/SyncedPodcast.h:39:13: Warnung: von »int SyncedPodcast::podcastType()« [-Woverloaded-virtual] You need to correct that too. If you don't see the warnings then please do a debug build. - Ralf Engels On Jan. 30, 2012, 7:03 p.m., Lucas Gomes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100998/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2012, 7:03 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Now downloaded episodes are kept in HD, if "keep episode" checkbox is checked. > These "kept" episodes are shown in the list regardless of the purgecount, > even if they > are not downloaded. > > BUG Description: > > Currently downloaded files are not kept when the episode is no longer shown in > the Podcast section. This behavior can not be configured but is tied to the > purge settings of each channel. > > It's possible to add a "keep downloaded file" checkbox to episodes to prevent > the deletion from happening. We should perhaps also show these "kept" episodes > in the list regardless of the purgecount. So even if a channel has purgecount > 5 > and 3 episodes marked to keep it will show 5 + maximum 3 older kept episodes. > > Reproducible: Always > > > This addresses bug 261062. > https://bugs.kde.org/show_bug.cgi?id=261062 > > > Diffs > ----- > > src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 > src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 > src/browsers/playlistbrowser/PodcastModel.h e88f4a1 > src/core-impl/podcasts/sql/SqlPodcastProvider.h c3d5e56 > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f > src/core/podcasts/PodcastMeta.h 679f7ac > > Diff: http://git.reviewboard.kde.org/r/100998/diff/diff > > > Testing > ------- > > > Thanks, > > Lucas Gomes > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
