----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104598/#review17539 -----------------------------------------------------------
The reason for submitting a "Proof of Concept" review request is probably to get a review. Since you now have your reviews, don't you want to reject the request? src/CTrack.h <http://git.reviewboard.kde.org/r/104598/#comment13745> Copyright header missing. src/CTrack.h <http://git.reviewboard.kde.org/r/104598/#comment13744> Comments missing. What is a CTrack? What does it do, where is it used. - Ralf Engels On April 18, 2012, 5:43 p.m., Saurabh Sood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104598/ > ----------------------------------------------------------- > > (Updated April 18, 2012, 5:43 p.m.) > > > Review request for Amarok. > > > Description > ------- > > This is my Proof of Concepts Implementation of the CurrentTrack data model. I > have implemented the data model using QObject and exposed the data to a QML > view using QDeclarative module. I have covered only the Artist Name, and the > Track name as of now, but this can be changed when I do the actual > implementation. I have implemented the QML view using a QWidget at present, > which is shown independently. > > > Diffs > ----- > > src/CMakeLists.txt 43bda903e4b1d2ef9bedff0f829ef2eed56e891f > src/CTrack.h PRE-CREATION > src/CTrack.cpp PRE-CREATION > src/CurrentTrack.h PRE-CREATION > src/CurrentTrack.cpp PRE-CREATION > src/MainWindow.h d49776476ce8b23013c1a8880a640d9aef35e817 > src/MainWindow.cpp 76f5cebc1cdb4fa2b93784c4500b55333b7ea66d > src/current.qml PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104598/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > Amarok QML View > http://git.reviewboard.kde.org/r/104598/s/528/ > > > Thanks, > > Saurabh Sood > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
