> On May 18, 2011, 9:37 p.m., Ralf Engels wrote: > > Just wanted to apply the patch (finally, sorry) but it doesn't apply > > cleanly any more. > > > > Also I noticed that there is not much magic in it, just implementing the > > virtual members, and I am wondering if that couldn't be done in the super > > class? > > > > Can you update the patch? > > Myriam Schweingruber wrote: > This actually doesn't concern bug 240060 but bug 173050 of which 240060 > is a duplicate. > > Does this still apply? If not please update the patch or remove it.
Need feedback. - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100176/#review3396 ----------------------------------------------------------- On Nov. 28, 2010, 3:03 p.m., Dennis Francis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100176/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2010, 3:03 p.m.) > > > Review request for Amarok. > > > Description > ------- > > This is just a copy and paste attempt to introduce cover fetch functionality > for DAAP albums. I used PlaydarMeta.h/.cpp as the reference. > > Please suggest better methods ! > > The cover arts does not persists between multiple runs of amarok; it seems to > load the art from internet everytime. Should I be using > ServiceAlbumCoverDownloader which has implemented caching ? > > > This addresses bug 240060. > https://bugs.kde.org/show_bug.cgi?id=240060 > > > Diffs > ----- > > src/core-impl/collections/daap/DaapMeta.h 8187d1e > src/core-impl/collections/daap/DaapMeta.cpp 61aa0db > > Diff: http://git.reviewboard.kde.org/r/100176/diff/ > > > Testing > ------- > > I am using a firefly DAAP server. > Cover art is getting fetched in non-blocking mode. > > > Thanks, > > Dennis Francis > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
