Re: [Kexi] Meego 1.1 and Koffice 2.2.95 - No Kexi package

[Marijn Kruisselbrink]

On Sunday, December 12, 2010 01:01:42 am Cyrille Berger Skott wrote:
> On Sunday 12 December 2010, Jaroslaw Staniek wrote:
> > On 12 December 2010 02:04, Noli Sicad  wrote:
> > > Hi,
> > > 
> > > I found that koffice and freoffice rpm in this repository state for
> > > meego_1.1_core (below).
> > > 
> > > https://build.pub.meego.com/package/binaries?package=koffice&project=ho
> > > me %3Amkruisselbrink%3Aminimalkde&repository=meego_1.1_core
> > > 
> > > However, there is no Kexi package.
> > 
> > Perhaps it's question to the package maintainers?
The package maintainer would be me.

> Well kexi is disabled in TINY.
Karbon and Krita are also disabled in TINY, but I still added those to the 
build; I can try to add kexi as well; be aware however that the kdelibs 
packages those meego packages are using are build with the mobile profile, 
which has at biggest consequence that all deprecated code in kdelibs has been 
removed/disabled. I don't know if kexi already compiles with such a limited 
kdelibs?

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Unit test coverage

[Marijn Kruisselbrink]

On Sunday, December 12, 2010 01:21:46 am Cyrille Berger Skott wrote:
> Hi,
> 
> I have setup a nightly build for calligra, which is intented if you have
> heavy unit tests that cannot be run for every commit. And also for unit
> test coverage.
> 
> The results is that we currently have a 26% coverage. It is neither too
> good, nor too bad. But definitively something we need to improve.
> 
> The result of last run is available here:
> http://my.cdash.org/viewCoverage.php?buildid=127785 (this page takes a
> while to be loaded...)
> 
> And if you click on a file you can get to know what part of the file is
> covered. (and click to open in a new window to avoid reloading the summary
> page :) )
> 
> So kudo to Dag and Plan for the file with the highest coverage:
> http://my.cdash.org/viewCoverageFile.php?buildid=127785&fileid=508339
You seemed to have missed the other two overview pages, with actual high test 
coverage :) That is the file with highest coverage that is still considered to 
have unacceptably low coverage.

http://my.cdash.org/viewCoverage.php?buildid=127785&status=2

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [Kexi] Meego 1.1 and Koffice 2.2.95 - No Kexi package

[Marijn Kruisselbrink]

On Sunday, December 12, 2010 01:40:13 am you wrote:
> On 12 December 2010 10:01, Cyrille Berger Skott  wrote:
> > Well kexi is disabled in TINY.
> 
> That's true but in the url above I see not just freoffice but regular
> koffice apps wihout TINY.
> If I am not mistaken we would expect regular kexi there.
> 
> Marijn?
Yeah, my packages change a bit what TINY disables... I tried first to just not 
use TINY at all, but then there are so many plugins etc that are not easily 
otherwise disableable (but don't build in the meego environment either) that 
in the end it was just easiest to use TINY but then patch it to not disable 
certain things.

A better solution would probably be to fix macro_optional_add_subdirectory to 
not require globally unique directory names, so I can just individually 
disable all the plugins that TINY now disables.

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Names of the binaries

[Marijn Kruisselbrink]

On Saturday, December 18, 2010 07:59:58 am Inge Wallin wrote:
> I think it would be a good idea to prefix our binaries with cs.  Examples
> would be cswords, cstables and so on. OOo does this with binaries like
> oowriter, oocalc, etc.  I *think* Libreoffice does the same but I'm not
> sure.
> 
> Reasons:
> 
>  - It follows the pattern
> 
>  - It helps the memory
> 
>  - It will be easier to find them for people that don't know all the names.
>cs will quickly give all the alternatives
> 
>  - The prefix is more unique.  For example, for tables, ta gives:
> tabs tac  tail tailftalk tar  taskset
>t gives 112 alternatives
> 
>  - It feels good :-)
>Yeah, this is very subjective, of course.
Even more than that, I think it is ridiculous to call our apps just "Tables" 
or "Words", so I'd suggest for user facing strings to always prefix the names 
with Calligra, so we'd have "Calligra Tables", "Calligra Words" etc (at least 
I'd feel ridiculous calling my app "Tables")

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Names of the binaries

[Marijn Kruisselbrink]

On Saturday, December 18, 2010 10:18:59 am Jaroslaw Staniek wrote:
> On 18 December 2010 16:59, Inge Wallin  wrote:
> > I think it would be a good idea to prefix our binaries with cs.  Examples
> > would be cswords, cstables and so on. OOo does this with binaries like
> > oowriter, oocalc, etc.  I *think* Libreoffice does the same but I'm not
> > sure.
> > 
> > Reasons:
> > 
> >  - It follows the pattern
> > 
> >  - It helps the memory
> > 
> >  - It will be easier to find them for people that don't know all the
> > names. cs will quickly give all the alternatives
> > 
> >  - The prefix is more unique.  For example, for tables, ta gives:
> > tabs tac  tail tailftalk tar  taskset
> >   t gives 112 alternatives
> > 
> >  - It feels good :-)
> >   Yeah, this is very subjective, of course.
> 
> I agree with the intention. Since you mentioned the tab completion,
> name length does not matter that much, so I propose calligra prefix.
> It's less geeky and more obvious.
Yeah, fully agree with this.

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Rename the "table" shape to spreadsheet shape

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100299/#review721
---

Ship it!


Agree

- Marijn


On 2011-01-03 21:04:36, Cyrille Berger Skott wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100299/
> ---
> 
> (Updated 2011-01-03 21:04:36)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Summary
> ---
> 
> As you can see in http://forum.kde.org/viewtopic.php?f=96&t=92343 the table 
> shape is confused for a text table shape, while it is really a spreadsheet 
> shape. I am suggesting we make it clear to the user that it is a spreadsheet 
> shape.
> 
> 
> Diffs
> -
> 
>   tables/shape/TableShapeFactory.cpp 84b3901e76678f61483a5d7800a4d69889418835 
> 
> Diff: http://git.reviewboard.kde.org/r/100299/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Cyrille
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: calligratables and formula offset

[Marijn Kruisselbrink]

On Tuesday, January 11, 2011 03:50:51 pm David Faure wrote:
> Hello,
> 
> I have a question for the applixspread import filter: if I have a formula
> like =B1+C1 for A1,
> and I want to reuse this formula for A3, I need to somehow change it to
> =B3+C3, just like copy/paste would do. Is there some utility function for
> this, which I can call from the applixspread import filter? Thanks.
The xlsx import filter has its own code for that 
(filters/tables/xlsx/FormulaParser.cpp, MSOOXML::convertFormulaReference), 
which probably doesn't even handle 100% all cases correctly. So I think at the 
moment that is something every filter implements independently.

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120609: The PixmapCacheSheetView crashes after the getTile API retuns from the QCache the QImage, but its use is deprecated

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120609/#review68574
---

Ship it!


If you remove the last use of PixmapCachingSheetView you should probably also 
just delete that class itself?

- Marijn Kruisselbrink


On Oct. 16, 2014, 8:11 p.m., Philip Van Hoof wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120609/
> ---
> 
> (Updated Oct. 16, 2014, 8:11 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 339921
> http://bugs.kde.org/show_bug.cgi?id=339921
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> The PixmapCacheSheetView crashes after the getTile API retuns from the QCache 
> the QImage, but its use is deprecated
> 
> 
> Diffs
> -
> 
>   sheets/part/CanvasItem.cpp 9a5d77a 
> 
> Diff: https://git.reviewboard.kde.org/r/120609/diff/
> 
> 
> Testing
> ---
> 
> More on the bug and crash explained here:
> 
> https://bugs.kde.org/show_bug.cgi?id=339921
> 
> I think it's better to just stop using PixmapCacheSheetView and simply use 
> SheetView directly in CanvasItem.
> 
> 
> Thanks,
> 
> Philip Van Hoof
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Limit zooming to a minimum and maximum zoom value

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100613/#review1319
---



libs/widgets/KoZoomAction.cpp


I'm not entirely sure, but doesn't this change the zoom levels from being 
exponential (1.25, 2.5, 5, 10, 20, 40, 80 or something like that, but with 
smaller) to something that has a linear increase in zoom level, and thus quite 
a different behavior?



libs/widgets/KoZoomMode.cpp


Maybe keep the default values to those that are currently used by 
KoZoomAction? thus 0.0625 - 16


- Marijn


On Feb. 9, 2011, 12:45 a.m., Arjen Hiemstra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100613/
> ---
> 
> (Updated Feb. 9, 2011, 12:45 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> ---
> 
> This bug fixes an issue with Calligra's zoom handling, caused by not limiting 
> the minimum and maximum zoom levels. Currently it is possible to completely 
> freeze Tables (or cause even more serious issues) by zoom out far enough.
> Zooming in on the other hand can cause you to get completely lost in your 
> document.
> 
> Note that for Krita and others, the default minimum and maximum zoom might 
> not be the best choice, which is why I included a setter for the minimum and 
> maximum values.
> 
> 
> Diffs
> -
> 
>   libs/widgets/KoZoomAction.cpp 4ef4d8b 
>   libs/widgets/KoZoomController.cpp 54b9168 
>   libs/widgets/KoZoomHandler.cpp ce234e6 
>   libs/widgets/KoZoomMode.h 9bfd195 
>   libs/widgets/KoZoomMode.cpp 293f1af 
> 
> Diff: http://git.reviewboard.kde.org/r/100613/diff
> 
> 
> Testing
> ---
> 
> Tested on Words, Stage, Tables and Krita. This patch currently breaks the 
> zoom handler unit test, which I will fix after this.
> 
> 
> Thanks,
> 
> Arjen
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Limit zooming to a minimum and maximum zoom value

[Marijn Kruisselbrink]

> On Feb. 9, 2011, 9:25 a.m., Marijn Kruisselbrink wrote:
> > libs/widgets/KoZoomAction.cpp, lines 78-85
> > <http://git.reviewboard.kde.org/r/100613/diff/1/?file=8794#file8794line78>
> >
> > I'm not entirely sure, but doesn't this change the zoom levels from 
> > being exponential (1.25, 2.5, 5, 10, 20, 40, 80 or something like that, but 
> > with smaller) to something that has a linear increase in zoom level, and 
> > thus quite a different behavior?

So you probably want something like
zoomStep = pow(1/minZoom, 1/16)
for i = 1 to 16
  sliderLookup[i] = pow(zoomStep, i-16)
zoomStep = pow(maxZoom, 1/16)
for i = 16 to 32
  sliderLookup[i] = pow(zoomStep, i-16)


- Marijn


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100613/#review1319
---


On Feb. 9, 2011, 12:45 a.m., Arjen Hiemstra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100613/
> ---
> 
> (Updated Feb. 9, 2011, 12:45 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> ---
> 
> This bug fixes an issue with Calligra's zoom handling, caused by not limiting 
> the minimum and maximum zoom levels. Currently it is possible to completely 
> freeze Tables (or cause even more serious issues) by zoom out far enough.
> Zooming in on the other hand can cause you to get completely lost in your 
> document.
> 
> Note that for Krita and others, the default minimum and maximum zoom might 
> not be the best choice, which is why I included a setter for the minimum and 
> maximum values.
> 
> 
> Diffs
> -
> 
>   libs/widgets/KoZoomAction.cpp 4ef4d8b 
>   libs/widgets/KoZoomController.cpp 54b9168 
>   libs/widgets/KoZoomHandler.cpp ce234e6 
>   libs/widgets/KoZoomMode.h 9bfd195 
>   libs/widgets/KoZoomMode.cpp 293f1af 
> 
> Diff: http://git.reviewboard.kde.org/r/100613/diff
> 
> 
> Testing
> ---
> 
> Tested on Words, Stage, Tables and Krita. This patch currently breaks the 
> zoom handler unit test, which I will fix after this.
> 
> 
> Thanks,
> 
> Arjen
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Limit zooming to a minimum and maximum zoom value

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100613/#review1322
---


- Marijn


On Feb. 9, 2011, 12:45 a.m., Arjen Hiemstra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100613/
> ---
> 
> (Updated Feb. 9, 2011, 12:45 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> ---
> 
> This bug fixes an issue with Calligra's zoom handling, caused by not limiting 
> the minimum and maximum zoom levels. Currently it is possible to completely 
> freeze Tables (or cause even more serious issues) by zoom out far enough.
> Zooming in on the other hand can cause you to get completely lost in your 
> document.
> 
> Note that for Krita and others, the default minimum and maximum zoom might 
> not be the best choice, which is why I included a setter for the minimum and 
> maximum values.
> 
> 
> Diffs
> -
> 
>   libs/widgets/KoZoomAction.cpp 4ef4d8b 
>   libs/widgets/KoZoomController.cpp 54b9168 
>   libs/widgets/KoZoomHandler.cpp ce234e6 
>   libs/widgets/KoZoomMode.h 9bfd195 
>   libs/widgets/KoZoomMode.cpp 293f1af 
> 
> Diff: http://git.reviewboard.kde.org/r/100613/diff
> 
> 
> Testing
> ---
> 
> Tested on Words, Stage, Tables and Krita. This patch currently breaks the 
> zoom handler unit test, which I will fix after this.
> 
> 
> Thanks,
> 
> Arjen
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Limit zooming to a minimum and maximum zoom value

[Marijn Kruisselbrink]

Hmm, that didn't quite work as intended, I tried to add another comment:
"Or probably even something that doesn't hardcode the center to 1, but just 
interpolates the entire range..."
But apparently reviewboard doesn't want me to actually publish that one...

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Change KoImageSelectionWidget to no longer embed a KFileWidget

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100716/
---

Review request for Calligra.


Summary
---

This changes KoImageSelectionWidget to no longer be a widget that embeds a 
KFileWidget, but instead show a KFileDialog to select a file. This should make 
it for example feel more native when run on windows, as you get a real file 
dialog. The overall behavior of the widget hasn't really changed with this 
diff, after selecting a file in the dialog/widget, you still get a preview of 
the image and can Ok/Cancel it.


Diffs
-

  libs/main/KoImageSelectionWidget.h 737ffdc3f655eaffb31eeb569384fe2b6c8aa678 
  libs/main/KoImageSelectionWidget.cpp 92c6d215b1a4c30607b1855dd517cfbce61bdda7 

Diff: http://git.reviewboard.kde.org/r/100716/diff


Testing
---


Thanks,

Marijn

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Change KoImageSelectionWidget to no longer embed a KFileWidget

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100716/
---

(Updated Feb. 23, 2011, 11:48 p.m.)


Review request for Calligra.


Changes
---

It now at least shows the preview inline in the file dialog (when run in KDE), 
getting rid of the second preview is a bit more difficult due to the async 
nature of KIO (and the potential for a long wait for a remote image). If you 
insert a remote image currently the UI will not block, but you just won't see 
an image in the dialog/will be able to insert an image until the download is 
completed (you are able to cancel insertion though). I guess we somehow could 
do this in the background in some other way, but doing that without blocking 
the UI is tricky.

I haven't yet done anything about the size of the preview.


Summary
---

This changes KoImageSelectionWidget to no longer be a widget that embeds a 
KFileWidget, but instead show a KFileDialog to select a file. This should make 
it for example feel more native when run on windows, as you get a real file 
dialog. The overall behavior of the widget hasn't really changed with this 
diff, after selecting a file in the dialog/widget, you still get a preview of 
the image and can Ok/Cancel it.


Diffs (updated)
-

  libs/main/KoImageSelectionWidget.h 737ffdc3f655eaffb31eeb569384fe2b6c8aa678 
  libs/main/KoImageSelectionWidget.cpp 92c6d215b1a4c30607b1855dd517cfbce61bdda7 

Diff: http://git.reviewboard.kde.org/r/100716/diff


Testing
---


Thanks,

Marijn

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Add an initial implementation of KoFind to Tables

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101295/#review3128
---

Ship it!


Looks good in general I guess, one thing would be to match the current 
searching code in tables it would need to search in userinput instead of values 
(although I'm not quite sure which would be more expected, displayText() would 
probably be even better, but looking up that for every cell is a very heavy 
operation since it requires actual formatting of the value).

And another thing still missing that the current search code has is the option 
to search in notes/comments.

If you add those as TODO's to the code I guess it should be fine to go in since 
the code won't be used already anyway.

- Marijn


On May 5, 2011, 12:42 p.m., Arjen Hiemstra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101295/
> ---
> 
> (Updated May 5, 2011, 12:42 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Summary
> ---
> 
> This patch adds an initial implementation of KoFindBase to Tables that can 
> search through a Tables sheet. It does not yet do highlighting and other 
> features, but the basic functionality works.
> 
> 
> Diffs
> -
> 
>   tables/CMakeLists.txt dad70dc 
>   tables/Find.h PRE-CREATION 
>   tables/Find.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101295/diff
> 
> 
> Testing
> ---
> 
> Added the KoFindToolBar to Tables in the branch and used that to test the 
> code.
> 
> 
> Thanks,
> 
> Arjen
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Windows compilation error

[Marijn Kruisselbrink]

When did you last update calligra? And what kdelibs version are you building 
against? There should be a #if in the code that only uses the (KFileItemList, 
QSize) arguments for kdelibs versions where that method exist, but somehow 
that check seems to be failing for you?

Marijn

On Sunday, May 22, 2011 01:00:28 pm Pierre Stirnweiss wrote:
> While compiling on windows, i get the following error:
> 
> 
> [  9%] Building CXX object
> libs/main/CMakeFiles/komain.dir/KoRecentDocumentsPane.obj
> KoRecentDocumentsPane.cpp
> C:\Users\pierre\shared\Hacking\calligra\libs\main\KoRecentDocumentsPane.cpp
> (125) : error C2665: 'KIO::filePreview' : none of the 2 overloads could
> convert all the argument types c:\kde\include\kio/previewjob.h(165): could
> be 'KIO::PreviewJob *KIO::filePreview(const KFileItemList
> &,int,int,int,int,bool,bool,const QStringList *)'
> c:\kde\include\kio/previewjob.h(187): or   'KIO::PreviewJob
> *KIO::filePreview(const KUrl::List &,int,int,int,int,bool,bool,const
> QStringList *)' while trying to match the argument list '(KFileItemList,
> QSize)' NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~1.0\VC\bin\cl.exe'
> : return code '0x2'
> Stop.
> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio
> 10.0\VC\BIN\nmake.exe"' : return code '0x2' Stop.
> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio
> 10.0\VC\BIN\nmake.exe"' : return code '0x2' Stop.
> 
> 
> I won't have much time to fix this before mid next week. And i'd like to
> nail down the styles widget stuff in the little time i'll have then. So if
> the corresponding author could look into this one, i'd be much gratefull.
> 
> Pierre

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: best unittest result ever:

[Marijn Kruisselbrink]

On Wednesday, June 22, 2011 02:32:21 pm Jos van den Oever wrote:
> On Wednesday, June 22, 2011 23:25:55 PM Jos van den Oever wrote:
> > On Wednesday, June 22, 2011 23:13:40 PM Jos van den Oever wrote:
> > > On Wednesday, June 22, 2011 14:51:52 PM Cyrille Berger Skott wrote:
> > > > On Wednesday 22 June 2011, Boudewijn Rempt wrote:
> > > > > On Wednesday 22 June 2011 Jun, Cyrille Berger Skott wrote:
> > > > > > > while on Jos' nameless build
> > > > > > > server, many krita/pigment tests fail for some weird reason
> > > > > > > (they shouldn't be enabled at all there, actually).
> > > > > > 
> > > > > > I guess some dependencies check are not working correctly. What
> > > > > > is the missing library for that build server ?
> > > > > 
> > > > > I'm not sure, but it looks a bit like there isn't any lcms -- and
> > > > > if lcms is absent, krita shouldn't be built:
> > > > > 
> > > > > ### Krita: pigment, eigen2, exiv2
> > > > > if(NOT EIGEN2_FOUND OR NOT EXIV2_FOUND OR NOT
> > > > > HAVE_REQUIRED_LCMS_VERSION)
> > > > > 
> > > > >set(SHOULD_BUILD_KRITA FALSE)
> > > > > 
> > > > > endif(NOT EIGEN2_FOUND OR NOT EXIV2_FOUND OR NOT
> > > > > HAVE_REQUIRED_LCMS_VERSION)
> > > > 
> > > > I actually think that Jos need to do some cleaning on his build
> > > > server.
> > > > 
> > > > Because if you go to the report page and look at log, and show all
> > > > message, you get this:
> > > > 
> > > > [13:05:50]: --  The following applications will be
> > > > built 
> > > > [13:05:50]: -- words
> > > > [13:05:50]: -- tables
> > > > [13:05:50]: -- kpresenter
> > > > [13:05:50]: -- kformula
> > > > [13:05:50]: -- mobile
> > > > [13:05:50]: -- calligra
> > > > [13:05:50]: -- cstester
> > > > [13:05:50]: --
> > > 
> > > Whenever a build fails, calligra is checked out again and built from
> > > scratch, so this log is intrueguing. I'll have a look at what might be
> > > lying around.
> > > 
> > > Cheers,
> > > Jos
> > > ___
> > > calligra-devel mailing list
> > > calligra-devel@kde.org
> > > https://mail.kde.org/mailman/listinfo/calligra-devel
> > 
> > The build machine has /usr/lib/liblcms.so.1 but that's it. No other
> > strange things that might trigger a krita build or test run as far as i
> > can tell.
> > 
> > Cheers,
> > Jos
> > ___
> > calligra-devel mailing list
> > calligra-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/calligra-devel
> 
> Here's something that might be interesting. This is how the tests are run
> on the build server:
> ===
> #! /bin/bash
> SCRIPTDIR=`dirname "$0"`
> 
> # free memory from remaining jobs
> killall -u $USER kdeinit4; killall -u $USER knotify4; killall -u $USER
> klauncher
> 
> for f in `find -name '*.shell'|grep -i test`; do
> TML=${f%.shell}.tml
> XML=${f%.shell}.xml
> rm -f $XML $TML
> timeout 30 $f -xml -o $TML
> xsltproc -o $XML ${SCRIPTDIR}/qtest2junit.xsl $TML
> done
> ===
> So if the .shell files for krita tests are created, they are run.
Wouldn't parsing the output of ctest -V -N be a much more reliable method to 
figure out what tests need to be run?

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [calligra] libs/main: Show the current working directory by default when starting without args

[Marijn Kruisselbrink]

Why would you want the "current" working directory to be shown when you start 
an app from the kde menu and/or krunner or any of many other places where you 
invoke the application without having a clear concept of working directory? 
This might be a nice feature for people that start stuff from the command line 
often, but it seems like it would break for the much more common use-case of 
end-users starting apps from user interfaces...

Marijn

On Monday, July 04, 2011 03:17:44 am Boudewijn Rempt wrote:
> Git commit e3b34f96f68b3ed752b8069b9d423583a69b88ef by Boudewijn Rempt.
> Committed on 04/07/2011 at 12:16.
> Pushed by rempt into branch 'master'.
> 
> Show the current working directory by default when starting without args
> 
> Instead of showing the directory from which we last loaded a file when
> we start an app without any arguments, show the directory from which
> the app was started.
> 
> BUG:260477
> 
> M  +8-0libs/main/KoApplication.cpp
> 
> http://commits.kde.org/calligra/e3b34f96f68b3ed752b8069b9d423583a69b88ef
> 
> diff --git a/libs/main/KoApplication.cpp b/libs/main/KoApplication.cpp
> index 8c1d148..af80653 100644
> --- a/libs/main/KoApplication.cpp
> +++ b/libs/main/KoApplication.cpp
> @@ -34,6 +34,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -136,6 +137,13 @@ bool KoApplication::start()
> 
>  // No argument -> create an empty document
>  if (!argsCount) {
> +
> +// if there's no document, add the current working directory
> +// to the recent dirs so the open dialog and open pane show
> +// the directory from where the app was started, instead of
> +// the last directory from where we opened a file
> +KRecentDirs::add(":OpenDialog", QDir::currentPath());
> +
>  QString errorMsg;
>  KoDocument* doc = entry.createDoc(&errorMsg);
>  if (!doc) {

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix hyperlink-activation in Tables

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101872/#review4497
---

Ship it!


Looks good to me.

- Marijn


On July 7, 2011, 12:47 p.m., Sebastian Sauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101872/
> ---
> 
> (Updated July 7, 2011, 12:47 p.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Stefan Nikolaus.
> 
> 
> Summary
> ---
> 
> Sometimes hyperlinks are not proper activated (as in executed if you click on 
> them so that Konqueror or your favorite Webbrowser surfs to the link or an 
> executable is executed).
> 
> The reason for this are
> a) The logic added with 3b274ee1f4bae850826d694b32885bcc1705dbc5 by Stefan 
> Nikolaus on 2008-07-11 to prevent execution of the hyperlink if the 
> mouse-cursor is not over the hyperlink's text was inversed and therefore 
> wrong.
> b) That logic tried to compare the relative to the cell defined coordinates 
> of CellView::textRect with the mouse-position which is in absolute 
> coordinates.
> 
> The patch fixes both cases.
> 
> 
> Diffs
> -
> 
>   tables/ui/HyperlinkStrategy.cpp d35adaf 
> 
> Diff: http://git.reviewboard.kde.org/r/101872/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sebastian
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Plasma Active Roadmap

[Marijn Kruisselbrink]

On Friday, August 12, 2011 12:01:45 PM Boudewijn Rempt wrote:
> For the first release (with Calligra 2.4), open tasks are:
> 
> * integreation with the desktop search system
> * include a presentation mode (needs some hacking in stage itself to
> reuse stage's presentation mode) * support search
> * support select
> * support copy
What about support for opening files in another way than on the command line?

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [calligra] filters: Fix bug 276268 - “Format not recongnized” Error is displaying while opening the attached Excel 2010 file

[Marijn Kruisselbrink]

And for documentation sake:
The real problem is that the whole relying on QUALIFIED_NAME (and certain 
hardcoded namespace prefixes) is completely broken by design. There are no 
elements without namespaces anywhere here, just elements with empty namespace 
prefixes, but because of the (broken) design of the ooxml filters, that causes 
major issues as it relies on certain hard-coded namespace prefixes for 
namespaces (and completely ignores any namespace definitions in the file).
So this is not about "tags without namespaces", it is about "tags with default 
namespaces", to try to prevent any future confusion when somebody actually 
tries to fix this for real.

Marijn

On Wednesday, August 17, 2011 04:08:54 PM Inge Wallin wrote:
> Git commit e09771b20ef359dac24b74a5b7d02da9f72135e3 by Inge Wallin.
> Committed on 17/08/2011 at 16:03.
> Pushed by ingwa into branch 'master'.
> 
> Fix bug 276268 -  “Format not recongnized” Error is displaying while
> opening the attached Excel 2010 file
> 
> This problem was much more complicated that it looked on the surface.
> 
> 1. The easy part was that MSO 2010 defines something called
>AlternateContent that defines the same data in two different ways.
>The fallback way is the same as SO 2007 uses, so that's what we try
>to dig out.
> 
> 2. A more serious problem was that the QUALIFIED_NAME macro was (and
>still is) defined in a way that makes it impossible to use
>READ_PROLOGUE et al. in a file that handles both tags with and
>without namespaces.  See details in MsooXmlCommonReaderImpl.h,
>where the namespace mc starts.
> 
> Bug: 276268
> 
> M  +15   -0filters/tables/xlsx/XlsxXmlWorksheetReader.cpp
> M  +51   -17   filters/libmsooxml/MsooXmlCommonReaderImpl.h
> 
> http://commits.kde.org/calligra/e09771b20ef359dac24b74a5b7d02da9f72135e3
> 
> diff --git a/filters/libmsooxml/MsooXmlCommonReaderImpl.h
> b/filters/libmsooxml/MsooXmlCommonReaderImpl.h index 080b99d..3070a4c
> 100644
> --- a/filters/libmsooxml/MsooXmlCommonReaderImpl.h
> +++ b/filters/libmsooxml/MsooXmlCommonReaderImpl.h
> @@ -55,7 +55,7 @@ KoFilter::ConversionStatus
> MSOOXML_CURRENT_CLASS::read_t() READ_PROLOGUE
>  while (!atEnd()) {
>  readNext();
> -kDebug() << *this;
> +//kDebug() << *this;
>  if (isCharacters()) {
>  body->addTextSpan(text().toString());
>  #ifdef PPTXXMLSLIDEREADER_CPP
> @@ -68,6 +68,22 @@ KoFilter::ConversionStatus
> MSOOXML_CURRENT_CLASS::read_t() //kDebug() << "{1}";
>  READ_EPILOGUE
>  }
> +
> +
> +// 
> +// New namespace: mc
> +
> +// ARGH!
> +
> +// The way that READ_PROLOGUE is defined via QUALIFIED_NAME makes it
> +// impossible to use it in files that handle tags both with and
> +// without namespaces.  This means that we cannot use READ_PROLOGUE in
> +// the functions below, and most likely also not the READ_IF variants.
> +// The above is only true when called from XmlWorksheetReader.  For Docx,
> +// there are always namespaces, so it doesn't apply.
> +// Same is true for READ_EPILOGUE.
> +
> +
>  #undef MSOOXML_CURRENT_NS
>  #define MSOOXML_CURRENT_NS "mc"
> 
> @@ -76,23 +92,28 @@ KoFilter::ConversionStatus
> MSOOXML_CURRENT_CLASS::read_t() //! Alternate content handler
>  KoFilter::ConversionStatus MSOOXML_CURRENT_CLASS::read_AlternateContent()
>  {
> -READ_PROLOGUE
> -
>  m_choiceAccepted = false;
> 
>  while (!atEnd()) {
>  readNext();
> -BREAK_IF_END_OF(CURRENT_EL)
> +if (isEndElement() && name() == "AlternateContent") {
> +break;
> +}
> +
>  if (isStartElement()) {
> -TRY_READ_IF(Choice)
> +if (name() == "Choice") {
> +TRY_READ(Choice)
> +}
>  else if (!m_choiceAccepted && qualifiedName() ==
> "mc:Fallback") { TRY_READ(Fallback)
>  }
> -SKIP_UNKNOWN
> +else {
> +skipCurrentElement();
> +}
>  }
>  }
> 
> -READ_EPILOGUE
> +return KoFilter::OK;
>  }
> 
>  #undef CURRENT_EL
> @@ -100,28 +121,34 @@ KoFilter::ConversionStatus
> MSOOXML_CURRENT_CLASS::read_AlternateContent() //! Choice handler
>  KoFilter::ConversionStatus MSOOXML_CURRENT_CLASS::read_Choice()
>  {
> -READ_PROLOGUE
> +
>  const QXmlStreamAttributes attrs(attributes());
> 
>  TRY_READ_ATTR_WITHOUT_NS(Requires)
> 
> +// 'Requires="v"' means that the contents of the Choice part
> +// is VML, which we support (or something else we do support,
> +// Lassi is not sure).  For all other alternatives we
> +// don't dare try to interpret it, but instead we use the
> +// AlternateContent which is what MSO 2007 would have given us.
>  if (Requires != "v") {
>  skipCurrentElement();
> -READ_EPILOGUE
> +return KoFilter::OK;
>  }
> -m_choiceAccepted = true;
> 
> +m_choiceAccepte

Re: Review Request: Fix wrong position calculations in AbstractSelectionStrategy, SelectionStrategy and DragAndDropStrategy

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102517/#review6544
---

Ship it!


I don't really know what the code is supposed to do either, but if it works, 
that's all that matters I'd say...

- Marijn


On Sept. 2, 2011, 8:03 a.m., Sebastian Sauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102517/
> ---
> 
> (Updated Sept. 2, 2011, 8:03 a.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Stefan Nikolaus.
> 
> 
> Summary
> ---
> 
> This fixes a crash when selecting cell after creating a chart ( bug 
> https://bugs.kde.org/show_bug.cgi?id=279951 ).
> 
> This patch is rather essential and changes how selections are translated to a 
> range of rows and columns. Before we did;
> 
> const KoShape* shape = 
> tool()->canvas()->shapeManager()->selection()->firstSelectedShape();
> const QPointF position = documentPos - (shape ? shape->position() : 
> QPointF(0.0, 0.0));
> 
> and now (with this patch) we do;
> 
> const QPointF position = documentPos;
> 
> What means we don't try to take the position of the first selected shape into 
> account any longer. That seems to work
> great, fixes bug 279951 and also gets right of a few other asserts (e.g. 
> select C3 and keep the mouse to expand the
> selected range to A1 and go a bit future to have also the header in the 
> selection => assert).
> 
> The push that added the firstSelectedShape() to Tables (back then KSpread) 
> was commit 2afef0a9;
> 
> Author: Stefan Nikolaus   2008-06-14 12:40:03
> Committer: Stefan Nikolaus   2008-06-14 
> 12:40:03
> Parent: 781ac3926d0e6224d4547cb5041041f66c4ecd97 (* New, updated TODO 
> list managed using emacs' org-mode)
> 
> Cell Tool Switch to strategies for the mouse interaction.
>   Drag'n'drop is special cased.
> 
> I tried to compile that revision to check if the bug was present but seems I 
> get interesting compile-errors related
> to undefined QString, KGlobal, etc. Maybe cause 2008 we where building still 
> against Qt3? Or against a moving kdelibs
> (aka the KDE4-port)? Not sure there but also later revisions fail to 
> compile... I didn't went future cause since that
> particular commit *lot* of refactoring happens and it can also be the case 
> that one of the many refactorings like
> e.g. commit 3fcae916 did break it. I wouldn't wonder...
> 
> 
> Diffs
> -
> 
>   tables/ui/AbstractSelectionStrategy.cpp f5982f9 
>   tables/ui/DragAndDropStrategy.cpp f500b5a 
>   tables/ui/SelectionStrategy.cpp 8844e47 
> 
> Diff: http://git.reviewboard.kde.org/r/102517/diff
> 
> 
> Testing
> ---
> 
> I tested various drag and drop and selection cases and they all still seem to 
> work as expected. Also it fixes bug 279951 .
> 
> 
> Thanks,
> 
> Sebastian
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix missing images in excel filter

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103044/#review8400
---

Ship it!


Looks good to me, should also make a future refactoring of the ODraw handling 
in the xls filter more straightforward, since there is less special 
casing/duplication of code. Great.

- Marijn Kruisselbrink


On Nov. 22, 2011, 5 p.m., Lukáš Tvrdý wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103044/
> ---
> 
> (Updated Nov. 22, 2011, 5 p.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer.
> 
> 
> Description
> ---
> 
> This patch uses more of the libmso in excel filter.
> 
> So far the pictures were handled as PictureObject class. One problem was that
> there was no support for groups for this object. So when you put two images 
> into groups, they
> are not displayed because the anchoring information is saved in different 
> data-structure - in the 
> group structure.
> 
> Now I let the records to be handled by libmso, which provides this 
> functionality.
> It supports groups and even graphical styles like like borders etc.
> 
> 
> This addresses bugs 244862, 262865 and 286607.
> http://bugs.kde.org/show_bug.cgi?id=244862
> http://bugs.kde.org/show_bug.cgi?id=262865
> http://bugs.kde.org/show_bug.cgi?id=286607
> 
> 
> Diffs
> -
> 
>   filters/libmso/ODrawToOdf.h 0016f8b 
>   filters/libmso/pictures.cpp f8bfa7c 
>   filters/libmso/shapes.cpp db001ee 
>   filters/tables/excel/import/ExcelImport.cpp 0f361a4 
>   filters/tables/excel/import/ODrawClient.h 83ed45c 
>   filters/tables/excel/import/ODrawClient.cpp 5a6507b 
>   filters/tables/excel/import/excelimporttoods.cc 287aef7 
>   filters/tables/excel/sidewinder/cell.h f9f7fc3 
>   filters/tables/excel/sidewinder/cell.cpp 0be93c3 
>   filters/tables/excel/sidewinder/excel.h 2be1f5a 
>   filters/tables/excel/sidewinder/excel.cpp 92d4a41 
>   filters/tables/excel/sidewinder/globalssubstreamhandler.h 77c6e3a 
>   filters/tables/excel/sidewinder/globalssubstreamhandler.cpp f9c03b1 
>   filters/tables/excel/sidewinder/objects.h 2412f07 
>   filters/tables/excel/sidewinder/objects.cpp ea60560 
>   filters/tables/excel/sidewinder/sheet.h 060e52e 
>   filters/tables/excel/sidewinder/sheet.cpp b6ecc82 
>   filters/tables/excel/sidewinder/workbook.h 2e3c2fa 
>   filters/tables/excel/sidewinder/workbook.cpp 9ad61bc 
>   filters/tables/excel/sidewinder/worksheetsubstreamhandler.cpp 2b258ae 
> 
> Diff: http://git.reviewboard.kde.org/r/103044/diff/diff
> 
> 
> Testing
> ---
> 
> I did regression testing against master. My testing set consists of 976 xls 
> files.
> I found only positive changes.
> 
> Missing frames around pictures are displayed now, missing images are 
> displayed now.
> You can test the document.
> 
> 
> Thanks,
> 
> Lukáš Tvrdý
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Optimize loading speed of tables

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103408/#review8962
---


Over-all I like it, some small comments though


tables/Formula.h
<http://git.reviewboard.kde.org/r/103408/#comment7440>

typo in "dound"



tables/Formula.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7441>

Your new code has removed a whole bunch of comments, like this one, and I'm 
not sure why... Some of them might not be terribly useful, and most of them can 
probably be deduced from the code, but it might still be nice to leave them in 
anyway.



tables/Formula.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7442>

more comments you removed that I think can be valuable. 



tables/Formula.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7443>

commented out code? (the same line twice even)



tables/Formula.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7444>

I'm  curious what the FIXME comment is for? I'm not sure what exactly needs 
fixing, so either fix it, or remove the comment if there is no fixing needed.



tables/Formula.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7445>

please keep this comment too



tables/Region.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7446>

commented out code is probably a leftover from something else?



tables/Region.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7447>

please make this file-static so it doesn't pollute the global namespace



tables/Region.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7449>

please make file-static



tables/Region.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7448>

to be consistent, the QChar('a') and 'z' ones should probably also be 
QChar('a', 0)



tables/Util.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7450>

if startPos >= length I would expect the code to always return false, not 
pretend like startPos==0



tables/Util.cpp
<http://git.reviewboard.kde.org/r/103408/#comment7439>

I wonder if it wouldn't be possible to completely eliminate the copying of 
parts of the expression, by instead of having the current 
midString.startsWith() have expression.midRef(i, 10) == 
QLatin1String("ERROR.TYPE") and similar for the other functions


- Marijn Kruisselbrink


On Dec. 14, 2011, 11:18 a.m., Thorsten Zachmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103408/
> ---
> 
> (Updated Dec. 14, 2011, 11:18 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> Optimize formula parsing by a factor of 2-4
> 
> This optimizes formula parsing by a factor of 2-4. The file
> www.worldmapper.org%2Fdata%2Funderlying%2FWorldmapper_U3_hdr%304_tables1-22.ods
> loads now in 25 instead of 30 seconds.
> 
> The patch tries to avoid creating QString objects when not necessary and reuse
> QString object when possible. The reduces the number of allocations quite a 
> lot.
> Also implicit casts of 'x' and "foo" are avoided where ever possible as these
> are also quite expensive.
> 
> e.g. some of the easy optimizations are
> 
> if (QString::operator[0] == '$')
> 
> is better written as
> 
> if (QString::operator[0] == QChar('$', 0)
> 
> as this can be optimized already be the compiler and thus reduces the stuff 
> needed
> otherwise.
> 
> Also initialize class members in initialization list of the constructor where 
> possible
> as this avoids copying the data a second time which is also expensive if it 
> is e.g. a
> QString.
> 
> Additionally to the speed up also the formula parsing now can recognice a 
> escaped " in
> a formula and parsing of error codes has been updated to follow ODF 1.2. This 
> fixes the
> failing unit tests in TestFormula.
> 
> Added unit test for decodeFormula.
> 
> 
> This addresses bug 288959.
> http://bugs.kde.org/show_bug.cgi?id=288959
> 
> 
> Diffs
> -
> 
>   tables/DependencyManager.cpp 2313e46 
>   tables/Formula.h 5a996f3 
>   tables/Formula.cpp e79ae1b 
>   tables/Region.h 261beb4 
>   tables/Region.cpp 1920ca9 
>   tables/Util.h b1879fb 
>   tables/Util.cpp ac03f0f 
>   tables/tests/CMakeLists.txt 9cc51db 
>   tables/tests/TestUtil.h PRE-CREATION 
>   tables/tests/Test

Re: Review Request: Optimize loading speed of tables

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103408/#review8986
---

Ship it!


Ship It!

- Marijn Kruisselbrink


On Dec. 15, 2011, 4:23 a.m., Thorsten Zachmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103408/
> ---
> 
> (Updated Dec. 15, 2011, 4:23 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> Optimize formula parsing by a factor of 2-4
> 
> This optimizes formula parsing by a factor of 2-4. The file
> www.worldmapper.org%2Fdata%2Funderlying%2FWorldmapper_U3_hdr%304_tables1-22.ods
> loads now in 25 instead of 30 seconds.
> 
> The patch tries to avoid creating QString objects when not necessary and reuse
> QString object when possible. The reduces the number of allocations quite a 
> lot.
> Also implicit casts of 'x' and "foo" are avoided where ever possible as these
> are also quite expensive.
> 
> e.g. some of the easy optimizations are
> 
> if (QString::operator[0] == '$')
> 
> is better written as
> 
> if (QString::operator[0] == QChar('$', 0)
> 
> as this can be optimized already be the compiler and thus reduces the stuff 
> needed
> otherwise.
> 
> Also initialize class members in initialization list of the constructor where 
> possible
> as this avoids copying the data a second time which is also expensive if it 
> is e.g. a
> QString.
> 
> Additionally to the speed up also the formula parsing now can recognice a 
> escaped " in
> a formula and parsing of error codes has been updated to follow ODF 1.2. This 
> fixes the
> failing unit tests in TestFormula.
> 
> Added unit test for decodeFormula.
> 
> 
> This addresses bug 288959.
> http://bugs.kde.org/show_bug.cgi?id=288959
> 
> 
> Diffs
> -
> 
>   tables/DependencyManager.cpp 2313e46 
>   tables/Formula.h 5a996f3 
>   tables/Formula.cpp e79ae1b 
>   tables/Region.h 261beb4 
>   tables/Region.cpp 1920ca9 
>   tables/Util.h b1879fb 
>   tables/Util.cpp ac03f0f 
>   tables/tests/CMakeLists.txt 9cc51db 
>   tables/tests/TestUtil.h PRE-CREATION 
>   tables/tests/TestUtil.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103408/diff/diff
> 
> 
> Testing
> ---
> 
> Run the changes against ~ 500 docs and compared the pre patch/after values 
> returned by scan and decodeFormula. The results of decodeFormula where all 
> the same pre/after. The result of scan has changed due to the fixed error and 
> string handling. 
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: tables documentation update for 2.4

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103614/#review9663
---

Ship it!


I didn't entirely read through all the changes, but in general it looks fine to 
me.

- Marijn Kruisselbrink


On Jan. 3, 2012, 10:42 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103614/
> ---
> 
> (Updated Jan. 3, 2012, 10:42 a.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Yuri Chornoivan.
> 
> 
> Description
> ---
> 
> Doc Update for Tables 2.4.0
> 
> faq.docbook -> remove it?
> importexport.docbook -> remove it?
> configdialog.docbook -> empty Plugin page, why?
> a11y.docbook -> removed
> functions.docbook -> added as requested by Marjin
> generated with a python script, which reveals a lot of errors
> Summary of Errors in 1090 Functions:
> error_missing_parameter: 1
> error_missing_syntax: 1
> error_missing_example: 37
> error_missing_related: 209
> error_missing_helptxt: 1
> error_args_syntax_comment: 85
> error_optional_syntax_comments: 16
> error_type_description_not_supported: 163
> dead links: COUPDAYBS PRICEDISC PRICE ODDFPRICE
> 
> 
> Diffs
> -
> 
>   doc/tables/advanced.docbook 42626d5 
>   doc/tables/basics.docbook 2a06be2 
>   doc/tables/commands.docbook bf7ea7e 
>   doc/tables/config.docbook 23f1a29 
>   doc/tables/configdialog.docbook cb00b36 
>   doc/tables/faq.docbook c868744 
>   doc/tables/format.docbook afe5787 
>   doc/tables/functions.docbook PRE-CREATION 
>   doc/tables/importexport.docbook 40c35c9 
>   doc/tables/index.docbook 85a7bbb 
> 
> Diff: http://git.reviewboard.kde.org/r/103614/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: tables documentation update for 2.4

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103614/#review9664
---

Ship it!


I didn't entirely read through all the changes, but in general it looks fine to 
me.

- Marijn Kruisselbrink


On Jan. 3, 2012, 10:42 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103614/
> ---
> 
> (Updated Jan. 3, 2012, 10:42 a.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Yuri Chornoivan.
> 
> 
> Description
> ---
> 
> Doc Update for Tables 2.4.0
> 
> faq.docbook -> remove it?
> importexport.docbook -> remove it?
> configdialog.docbook -> empty Plugin page, why?
> a11y.docbook -> removed
> functions.docbook -> added as requested by Marjin
> generated with a python script, which reveals a lot of errors
> Summary of Errors in 1090 Functions:
> error_missing_parameter: 1
> error_missing_syntax: 1
> error_missing_example: 37
> error_missing_related: 209
> error_missing_helptxt: 1
> error_args_syntax_comment: 85
> error_optional_syntax_comments: 16
> error_type_description_not_supported: 163
> dead links: COUPDAYBS PRICEDISC PRICE ODDFPRICE
> 
> 
> Diffs
> -
> 
>   doc/tables/advanced.docbook 42626d5 
>   doc/tables/basics.docbook 2a06be2 
>   doc/tables/commands.docbook bf7ea7e 
>   doc/tables/config.docbook 23f1a29 
>   doc/tables/configdialog.docbook cb00b36 
>   doc/tables/faq.docbook c868744 
>   doc/tables/format.docbook afe5787 
>   doc/tables/functions.docbook PRE-CREATION 
>   doc/tables/importexport.docbook 40c35c9 
>   doc/tables/index.docbook 85a7bbb 
> 
> Diff: http://git.reviewboard.kde.org/r/103614/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: tables documentation update for 2.4

[Marijn Kruisselbrink]

> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/functions.docbook, lines 1-10
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45338#file45338line1>
> >
> > I need some input here
> 
> Burkhard Lück wrote:
> Is functions.docbook what Tables Maintainer(s) want?
> 
> I don't want to through 1500 messages into the translation system without 
> OK from Developers.

This is auto-generated from the .xml files, right? Shouldn't in that case all 
the translations already exist, since the actual xml files get their strings 
extracted? Not sure if it is possible to somehow link those two together though.


> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/importexport.docbook, lines 1-6
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45339#file45339line1>
> >
> > Remove this docbook?
> > 
> > Not much valid/uptodate infos here

I agree, doesn't seem to have much useful information.


> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/faq.docbook, lines 1-33
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45336#file45336line1>
> >
> > Does it really make sense to keep this docbook?
> > 
> > I'd like to remove it and move the info about template storage to the 
> > templates section in basics.docbook

Yeah, a faq with two questions, one of which indeed has the wrong answer is not 
the most useful thing. (for reference, number of columns is still correct, 
number of rows is 1,048,576 these days)


> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/configdialog.docbook, lines 306-308
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45335#file45335line306>
> >
> > Empty here, hat should be on the plugins page?

Oops, seems I renamed the service-type in the servicetype .desktop file, but 
not in the actual plugins (not that there really are any plugins at the moment, 
but still something that should be fixed of course)


> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/advanced.docbook, lines 47-51
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45331#file45331line47>
> >
> > Works here only with two cells with custom list entries, not with one 
> > custom list entry in one cell

Seems to have some bugs in the code indeed, it's supposed to work with one 
entry, but currently only for times and dates it will use a non-0 delta with 
only one cell selected.


- Marijn


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103614/#review9493
---


On Jan. 3, 2012, 10:42 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103614/
> ---
> 
> (Updated Jan. 3, 2012, 10:42 a.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Yuri Chornoivan.
> 
> 
> Description
> ---
> 
> Doc Update for Tables 2.4.0
> 
> faq.docbook -> remove it?
> importexport.docbook -> remove it?
> configdialog.docbook -> empty Plugin page, why?
> a11y.docbook -> removed
> functions.docbook -> added as requested by Marjin
> generated with a python script, which reveals a lot of errors
> Summary of Errors in 1090 Functions:
> error_missing_parameter: 1
> error_missing_syntax: 1
> error_missing_example: 37
> error_missing_related: 209
> error_missing_helptxt: 1
> error_args_syntax_comment: 85
> error_optional_syntax_comments: 16
> error_type_description_not_supported: 163
> dead links: COUPDAYBS PRICEDISC PRICE ODDFPRICE
> 
> 
> Diffs
> -
> 
>   doc/tables/advanced.docbook 42626d5 
>   doc/tables/basics.docbook 2a06be2 
>   doc/tables/commands.docbook bf7ea7e 
>   doc/tables/config.docbook 23f1a29 
>   doc/tables/configdialog.docbook cb00b36 
>   doc/tables/faq.docbook c868744 
>   doc/tables/format.docbook afe5787 
>   doc/tables/functions.docbook PRE-CREATION 
>   doc/tables/importexport.docbook 40c35c9 
>   doc/tables/index.docbook 85a7bbb 
> 
> Diff: http://git.reviewboard.kde.org/r/103614/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Making dbus optional in Calligra

[Marijn Kruisselbrink]

On Tuesday, February 07, 2012 07:59:55 PM Sebastian Sauer wrote:
> On 02/07/2012 02:52 PM, Boudewijn Rempt wrote:
> > On Tue, 7 Feb 2012, Sebastian Sauer wrote:
> >> What I would like to do is to introduce in Calligra a way to
> >> completely disable any use of dbus. The target would be to 1) make
> >> Calligra compile with #define QT_NO_DBUS and 2) make Calligra
> >> optionally compile without support for dbus even if Qt-dbus is
> >> available.
> >> 
> >> The idea is to address one of the issues named by Mek in his amazing
> >> blog-post about the port of Calligra to Android ( see
> >> http://blogs.kde.org/node/4521 ). The issue is that Android does not
> >> ship with dbus.
> >> 
> >> The idea would be;
> >> 1. introduce a new cmake flag that allows to disable dbus Caligra
> >> wide. Per default dbus is enabled except Qt was compiled without
> >> support for it.
> >> 2. introduce #ifdef's all over Calligra to proper disable / not
> >> compile any code that makes use of dbus when dbus was disabled.
> >> 
> >> Good idea? What do you think?
> > 
> > Well, Mek is the expert, but I guess it would help -- though the
> > biggest issues with dbus are actually in kdelibs.
> 
> kde-frameworks addresses lot of them. In fact there are very few places
> Calligra links against that depend on dbus. KMimeTypeTrader and
> KParts/KPartsPlugin/KLibLoader are the only big things left but that's
> todo for later. Let's first look at dbus :)
That calligra doesn't need dbus is quite obvious of course from both the N9 
documents app and my android efforts. In both cases there are no other kde 
daemons around/no dbus communication going on, and both work just fine. (the N9 
version is of course still built against libqtdbus). Removing the dbus 
dependencies from calligra was indeed mostly trivial, I think 
911bda03c72d8bf488166beeb1b3ad36a61842ea 
1e146dd026e5b5a7d85e91f109c222b2369a9665 and 
2a71dacf4b7b30af8a0138624c7565722f21f7df have most of the changes I had to do 
for that (there might be some minor changes in some of the other commits in 
the mobile-android-mek branch, but those are the main ones). Those commits are 
currently disabling dbus code based on if it is an android build, but it would 
of course be rather trivial to do that based on some other parameter.


> contra plugin;
> * We need to handle dbus-registration. That means if for example a sheet
> is added in Calligra Tables then the dbus plugin needs to be notified so
> it can create a SheetAdaptor. The same is true for *ALL* signals a
> dbus-adaptor exports. That means we need interfaces/decorators in Tables
> to forward calls to the plugin's or some other way to proper notify the
> plugin when something happens. KParts and flake are clearly not enough
> here. 
At least for the calligra tables case, there is no extra code needed in 
tables. The only dbus related code that I had to ifdef out there is the 
creation of the MapAdaptor/SheetAdaptor instances, all the rest is handled in 
those classes based on signals that are already exposed anyway.


Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Using the Tables brand/trade name for a spreadsheet application

[Marijn Kruisselbrink]

On Thursday, March 08, 2012 04:36:25 AM Sebastian Sauer wrote:
> On 03/07/2012 06:10 PM, Algot Runeman wrote:
> > On 03/07/2012 09:15 AM, Boudewijn Rempt wrote:
> >> On Wed, 7 Mar 2012, Sebastian Sauer wrote:
> >>> I really think we should not rename to Abacus if we do not plan to
> >>> make some lawyers even more rich.
> >> 
> >> Maybe we should just go for the most generic names possible, like
> >> Calligra Sheets or even Calligra Spreadsheet. Spreadsheet is such a
> >> generic word that nobody can claim it.
> >> 
> >> Boudewijn
> >> ___
> >> calligra-devel mailing list
> >> calligra-devel@kde.org
> >> https://mail.kde.org/mailman/listinfo/calligra-devel
> > 
> > As a user, I like this one, too.
> > Calligra Spreadsheet
> 
> I like Calligra Sheets which is even shorter, close to what is does and
> while it's rather generic there is no such big danger other apps are
> using it in there UI to describe something else.
> 
> Would  "Spreadsheet" pass those "the name should be short, 1-3
> syllables" idea formulated in the first discussion when Calligra was
> formed? If yes, I think that's for sure a nice and matching one too :)
> 
I think Calligra Sheets is also the best suggestion I've heard so far. So I 
would say we should just go for that.

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra sprint in May?

[Marijn Kruisselbrink]

On Thursday, March 08, 2012 04:31:16 AM Thorsten Zachmann wrote:
> On Wednesday, March 07, 2012 08:24:19 Inge Wallin wrote:
> > The e.V board has a new policy for sprints that means that you have to
> > apply for a budget the quarter before you plan to give a sprint. This
> > means that if we want to have a sprint in Q2, we need to apply for it
> > before end of March.
> > 
> > So, should we try to organize a sprint in May as usual? I would love to
> > and I think it would hurt our development if we didn't.
> > 
> > Since the situation today is slightly different, than previous years I'm
> > not sure we can get a corporate sponsor of the type that Nokia was last
> > time. So any ideas for a good venue? I really loved the Linux Hotel in
> > Essen and I think it would be very nice to go there again. And most
> > importantly, any volunteers for organizing it?
> 
> I think May might be a bit early for planning a sprint. Specially as we
> already have only until end of March to get the planning done. I think it
> might be easier to plan something for Q3. Also we might want to think about
> doing maybe 2 sprints. One in Europe and one in India to bring down the
> costs for the sprint.
I think a sprint in May would have been really useful, but maybe it is indeed 
a bit late to organize one now.
At least europe and india would probably both be about equally expensive and 
hard to get to for me (but then, that is my own fault for moving so far away 
:) )

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: RC2

[Marijn Kruisselbrink]

So I have to finish renaming calligra tables to calligra sheets before sunday 
then?

Marijn

On Thursday, March 08, 2012 09:33:31 AM Cyrille Berger wrote:
> Hi,
> 
> since there was some data loss spotted by Thorsten, and now fixed, we are
> not going to release the RC1, but I am going to tag a RC2 on Sunday, with a
> release next week.
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: RC2

[Marijn Kruisselbrink]

Well, if you'd rather do the renaming after RC2 (and before RC3), that is fine 
with me too, then I'll just do the renaming in master first and we can merge it 
to 2.4 after RC2 is tagged.

Marijn

On Thursday, March 08, 2012 08:33:04 PM Cyrille Berger Skott wrote:
> arg... I was actually hoping not to have to redo the translations as well
> :(
> 
> On Thursday 08 Mar 2012, Burkhard Lück wrote:
> > Am Donnerstag, 8. März 2012, 19:15:03 schrieb Marijn Kruisselbrink:
> > > So I have to finish renaming calligra tables to calligra sheets before
> > > sunday then?
> > 
> > Does not seem that hard:
> > $ wcgrep Tables l10n-kde4/templates/messages/calligra/|wc -l
> > 28
> > But please do not only rename 'calligra tables' to 'calligra sheets', but
> > also 'tables' to 'calligra sheets'.
> > 
> > 
> > The documentation needs to be changed as well:
> > 
> > $ wcgrep Tables l10n-kde4/templates/docmessages/calligra/|wc -l
> > 17
> > 
> > I'm going to handle the docs.
> > 
> > Would be nice to give the translators a warning with a link to the "Using
> > the Tables brand/trade name for a spreadsheet application" thread on this
> > list.
> > 
> > Thanks.
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Bug 290656( Meaningless action text in cell context menu) resolved

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104174/#review11265
---

Ship it!


Other than the one comment below, it looks good to me.


tables/ui/CellToolBase_p.cpp
<http://git.reviewboard.kde.org/r/104174/#comment9031>

What is this change about? The two extra separator actions don't seem to be 
used.


- Marijn Kruisselbrink


On March 6, 2012, 3:50 p.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104174/
> ---
> 
> (Updated March 6, 2012, 3:50 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> Bug 290656 - Meaningless action text in cell context menu: 
> 
> Solution using patch: The confusion regarding the same label with different 
> functionalities of "comment" in the cell context menu has been resolved.
> 
> 
> This addresses bug 290656.
> http://bugs.kde.org/show_bug.cgi?id=290656
> 
> 
> Diffs
> -
> 
>   tables/ui/CellToolBase_p.cpp 5d3cf73 
> 
> Diff: http://git.reviewboard.kde.org/r/104174/diff/
> 
> 
> Testing
> ---
> 
> The code has been tested and is successfully working.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: RC2

[Marijn Kruisselbrink]

So I'm not sure what you're suggesting then? Release as Calligra Tables anyway 
and only rename for 2.5? That seems to be the worst possible solution...

Marijn

On Sunday, March 11, 2012 12:04:04 PM Cyrille Berger Skott wrote:
> It would be really weird to do it during RC time.
> 
> On Thursday 08 Mar 2012, Marijn Kruisselbrink wrote:
> > Well, if you'd rather do the renaming after RC2 (and before RC3), that is
> > fine with me too, then I'll just do the renaming in master first and we
> > can merge it to 2.4 after RC2 is tagged.
> > 
> > Marijn
> > 
> > On Thursday, March 08, 2012 08:33:04 PM Cyrille Berger Skott wrote:
> > > arg... I was actually hoping not to have to redo the translations as
> > > well
> > > 
> > > :(
> > > 
> > > On Thursday 08 Mar 2012, Burkhard Lück wrote:
> > > > Am Donnerstag, 8. März 2012, 19:15:03 schrieb Marijn Kruisselbrink:
> > > > > So I have to finish renaming calligra tables to calligra sheets
> > > > > before sunday then?
> > > > 
> > > > Does not seem that hard:
> > > > $ wcgrep Tables l10n-kde4/templates/messages/calligra/|wc -l
> > > > 28
> > > > But please do not only rename 'calligra tables' to 'calligra sheets',
> > > > but also 'tables' to 'calligra sheets'.
> > > > 
> > > > 
> > > > The documentation needs to be changed as well:
> > > > 
> > > > $ wcgrep Tables l10n-kde4/templates/docmessages/calligra/|wc -l
> > > > 17
> > > > 
> > > > I'm going to handle the docs.
> > > > 
> > > > Would be nice to give the translators a warning with a link to the
> > > > "Using the Tables brand/trade name for a spreadsheet application"
> > > > thread on this list.
> > > > 
> > > > Thanks.
> > 
> > ___
> > calligra-devel mailing list
> > calligra-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/calligra-devel
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: RC2

[Marijn Kruisselbrink]

I have a patch ready here locally to rename Calligra Tables to Calligra 
Sheets, I'm just not sure anymore what I should do with it...

On Monday, March 12, 2012 02:34:39 AM Marijn Kruisselbrink wrote:
> So I'm not sure what you're suggesting then? Release as Calligra Tables
> anyway and only rename for 2.5? That seems to be the worst possible
> solution...
> 
> Marijn
> 
> On Sunday, March 11, 2012 12:04:04 PM Cyrille Berger Skott wrote:
> > It would be really weird to do it during RC time.
> > 
> > On Thursday 08 Mar 2012, Marijn Kruisselbrink wrote:
> > > Well, if you'd rather do the renaming after RC2 (and before RC3), that
> > > is fine with me too, then I'll just do the renaming in master first
> > > and we can merge it to 2.4 after RC2 is tagged.
> > > 
> > > Marijn
> > > 
> > > On Thursday, March 08, 2012 08:33:04 PM Cyrille Berger Skott wrote:
> > > > arg... I was actually hoping not to have to redo the translations as
> > > > well
> > > > 
> > > > :(
> > > > 
> > > > On Thursday 08 Mar 2012, Burkhard Lück wrote:
> > > > > Am Donnerstag, 8. März 2012, 19:15:03 schrieb Marijn Kruisselbrink:
> > > > > > So I have to finish renaming calligra tables to calligra sheets
> > > > > > before sunday then?
> > > > > 
> > > > > Does not seem that hard:
> > > > > $ wcgrep Tables l10n-kde4/templates/messages/calligra/|wc -l
> > > > > 28
> > > > > But please do not only rename 'calligra tables' to 'calligra
> > > > > sheets', but also 'tables' to 'calligra sheets'.
> > > > > 
> > > > > 
> > > > > The documentation needs to be changed as well:
> > > > > 
> > > > > $ wcgrep Tables l10n-kde4/templates/docmessages/calligra/|wc -l
> > > > > 17
> > > > > 
> > > > > I'm going to handle the docs.
> > > > > 
> > > > > Would be nice to give the translators a warning with a link to the
> > > > > "Using the Tables brand/trade name for a spreadsheet application"
> > > > > thread on this list.
> > > > > 
> > > > > Thanks.
> > > 
> > > ___
> > > calligra-devel mailing list
> > > calligra-devel@kde.org
> > > https://mail.kde.org/mailman/listinfo/calligra-devel
> 
> ___
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Using the Tables brand/trade name for a spreadsheet application

[Marijn Kruisselbrink]

Hi Daniel,

We did of course use google to try to make sure that we wouldn't use any name 
that might conflict with existing software, and unfortunately didn't come 
across your application (also our application is called "Calligra Tables", not 
"Tables"). But since we of course don't want to couse any more confusion than 
is inherent in using a generic word as name for an application, we've decided 
to rename Calligra Tables to Calligra Sheets.

Regards,
Marijn Kruisselbrink
Calligra Sheets Maintainer

On Wednesday, March 07, 2012 11:18:23 AM Tables (mails) wrote:
> Hi,
> 
> My name is Daniel Schwill and I'm the developer of a spreadsheet
> application called Tables for Mac OS X. I'm using the brand/trade name
> Tables for my spreadsheet application since 2004/2005. I just recognized
> that you released a spreadsheet application called Tables as part of the
> Calligra project.
> 
> Before choosing a name for an application it could be a good idea to use
> google and search that name. When you search for "Tables" or "Tables
> spreadsheet" for example you'll find many links to my spreadsheet
> application on the first page of the search results.
> 
> Choosing a name for a new spreadsheet application that is already in use by
> an existing spreadsheet application will irritate customers and cause
> confusion. As my spreadsheet application Tables and the Calligra project
> are both available on Mac OS X I ask you to rename your spreadsheet
> application to avoid confusion of names between my spreadsheet application
> and the spreadsheet application of the Calligra project.
> 
> Regards,
> 
>Daniel
> 
> ___
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: calligra.org/tables needs to be changed to calligra.org/sheets

[Marijn Kruisselbrink]

Also somebody should rename the bugzilla component.

Marijn

On Wednesday, March 14, 2012 08:28:17 PM Jaroslaw Staniek wrote:
> On 14 March 2012 18:36, Friedrich W. H. Kossebau  wrote:
> > Hi,
> > 
> > now that Calligra Tables officially got renamed to Calligra Sheets, this
> > needs to be reflected in the calligra.org website as well, ideally best
> > before the next RC, because this is when a lot of people will visit
> > those pages, and they better are consistent with what is actually
> > released and talked about in the release announcement.
> 
> Full rename is of course impossible because of external links so I
> propose extra symlink (or mod_rewrite rule) from /tables/* to /sheets/*.
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Regarding Proposal

[Marijn Kruisselbrink]

On Friday, March 16, 2012 09:56:27 AM Jaroslaw Staniek wrote:

> Jigar,
> Cool, that's normal - many ideas, food for thought :_)
> 
> To add even more spice here - pivot tables for database apps (Kexi)
> are really appealing (but I think reuse of Sheets pivot tables would
> be rather limited because of different data models and requirements -
> spreadsheets usually have all the data in memory already). Another
> challenge :)
Actually, that is not really true. To support all of pivot tables that are 
defined in odf, having an actual database as source of the data is also 
something that would be possible. So hopefully any pivot table implementation 
would be generic enough to also allow for those usecases.

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: calligra/2.4 build fails

[Marijn Kruisselbrink]

On Friday, March 16, 2012 10:14:24 AM Boudewijn Rempt wrote:
> On Friday 16 March 2012 Mar, Dag wrote:
> > If I'm not mistaken, something is missing from the 2.4 -> calligra/2.4
> > conversion in sheets/part/View.cpp:1179
> > 
> > Att patch fixes, but could you check it out Boudewijn, it seems you were
> > the last to touch this code.
> 
> Aw, yes, that must have been a merging error. Your patch is correct.
I think the merging error was actually on my side. I committed the fix now. I 
probably shouldn't have tried to port just my patches from the wrong 2.4 
branch to the real 2.4 branch, as that needlessly complicated things.

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: formulas averageif, averageifs, sumifs, countifs implemented in Calligra Sheets

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104487/#review12176
---


One thing I'd really like to have before this goes in is unit tests. Currently 
(almost?) every function has several unit tests to test for correctness, so I 
don't really want new functions that get added to not have at least some basic 
unit tests.

- Marijn Kruisselbrink


On April 5, 2012, 12:56 a.m., Nityam Vakil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104487/
> ---
> 
> (Updated April 5, 2012, 12:56 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> To fully support all of the defined heighest level 4 formulas, I added 
> support for formulas averageif, averageifs, sumifs, countifs.
> 
> 
> Diffs
> -
> 
>   sheets/ValueCalc.h d0018c2 
>   sheets/ValueCalc.cpp 7e6f3a3 
>   sheets/functions/math.cpp d57ce94 
>   sheets/functions/statistical.cpp 020b03e 
> 
> Diff: http://git.reviewboard.kde.org/r/104487/diff/
> 
> 
> Testing
> ---
> 
> I've tested above formulas with some test data attached here. And it seems to 
> be working fine.
> 
> 
> Thanks,
> 
> Nityam Vakil
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [calligra] sheets: save shapes with the proper offset when they are cell-anchored

[Marijn Kruisselbrink]

On Saturday, April 07, 2012 10:54:21 AM Inge Wallin wrote:
> On Saturday, April 07, 2012 02:58:44 Marijn Kruisselbrink wrote:
> > Git commit f64d1b162595753a50367793a96fac6af2083684 by Marijn
> > Kruisselbrink. Committed on 07/04/2012 at 02:09.
> > Pushed by mkruisselbrink into branch 'master'.
> > 
> > save shapes with the proper offset when they are cell-anchored
> 
> This is a pretty important fix. Without it, most shapes in Sheets will be
> misplaced after a save/load cycle and be more misplaced for every such
> cycle. Is it at all possible to get it into 2.4?
It should definitely be backported to 2.4.x, yes, not sure if it warrants 
delaying the 2.4.0 release since it isn't really a regression, it's just 
something that has never worked in and koffice 2.x release.

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Historical Name of Date Basis and wrong sepperator used in financial.xml

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104645/#review12613
---

Ship it!


Ship It!

- Marijn Kruisselbrink


On April 17, 2012, 1:32 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104645/
> ---
> 
> (Updated April 17, 2012, 1:32 p.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer.
> 
> 
> Description
> ---
> 
> 1) ... is using ";" as seperator by default
> 
> 2) http://docs.oasis-open.org/office/v1.2/OpenDocument-v1.2-part2.odt says in 
> 4.11.7.1 General
> "Date Basis 4 Historical Name European 30/360", but calligra financial.xml 
> has "European 30/365"
> 
> 
> Diffs
> -
> 
>   sheets/functions/financial.xml 3a90090 
> 
> Diff: http://git.reviewboard.kde.org/r/104645/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: change Sheets UI by moving the cell editor out of the cell tool

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104708/
---

Review request for Calligra.


Description
---

This changes to UI of Calligra Sheets a bit by moving the cell editor widget 
out of the CellTool and instead have it as a separate docker. On top of that 
there are several new option widgets for the cell tool that provide common 
formatting options.
I've also changed the KoToolDocker a tiny bit, by changing the scroll area in 
it to not be able to get keyboard focus, at least for these new dockers that is 
preferred, I'm not sure if there are any other tool option widgets/use cases 
where you would want the scroll area containing the tool option widgets to be 
able to get keyboard focus?
Please test (also available in the tables-uirefactor-mek branch) and see if 
anything weird is happening since it is a fairly big change.


Diffs
-

  libs/main/KoToolDocker.cpp 44ce789 
  sheets/CMakeLists.txt 5355719 
  sheets/Messages.sh e636ac1 
  sheets/part/CanvasItem.h 41acefe 
  sheets/part/CanvasItem.cpp c5ccba3 
  sheets/part/Factory.cpp fb612da 
  sheets/part/View.h 5322e43 
  sheets/part/View.cpp 5c11f98 
  sheets/ui/ActionOptionWidget.h PRE-CREATION 
  sheets/ui/ActionOptionWidget.cpp PRE-CREATION 
  sheets/ui/CellEditorDocker.h PRE-CREATION 
  sheets/ui/CellEditorDocker.cpp PRE-CREATION 
  sheets/ui/CellToolBase.h aa3a094 
  sheets/ui/CellToolBase.cpp 33f2d29 
  sheets/ui/CellToolBase_p.h 7750a4a 
  sheets/ui/CellToolBase_p.cpp 0cba586 
  sheets/ui/CellToolOptionWidget.h c46b7df 
  sheets/ui/CellToolOptionWidget.cpp 4a1d068 
  sheets/ui/CellToolOptionWidgets.xml PRE-CREATION 
  sheets/ui/ExternalEditor.h ab3ee6d 
  sheets/ui/ExternalEditor.cpp e9f8781 
  sheets/ui/LocationComboBox.h e666ada 
  sheets/ui/LocationComboBox.cpp 6215039 
  sheets/ui/Selection.h baa9cdf 
  sheets/ui/Selection.cpp 316a2fc 

Diff: http://git.reviewboard.kde.org/r/104708/diff/


Testing
---


Thanks,

Marijn Kruisselbrink

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: remove one of two copies of KoItemToolTip

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104738/
---

Review request for Calligra.


Description
---

Somehow we ended up with two copies of the KoItemToolTip class, one in 
kowidgets and one in komain. (and worse, some bug fixes were only applied to 
one of the two copies). This fixes that by only having one copy of the class, 
in the kowidgets library. I copied the komain version there since that version 
had some bug fixes that the kowidgets version didn't get.
The only potential downside to this I can see is that now the class needs to be 
exported (since the only users of it are in kowidgets and komain, the class 
wasn't exported before and instead somebody decided to have two copies instead).


Diffs
-

  libs/main/CMakeLists.txt f4074ea 
  libs/main/KoItemToolTip.h 4e35e1e 
  libs/main/KoItemToolTip.cpp 72b3801 
  libs/widgets/KoItemToolTip.h 91dd510 
  libs/widgets/KoItemToolTip.cpp beffbcb 

Diff: http://git.reviewboard.kde.org/r/104738/diff/


Testing
---


Thanks,

Marijn Kruisselbrink

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [KDE/Mac] Working kde apps on kde?

[Marijn Kruisselbrink]

I have no idea what is going on there, but I have seen similar errors/warnings 
when running calligra applications on Android. In that case it seems loading 
libwordsprivate.so is what triggers similar warnings (of course for different 
files, since obviously /mach_kernel doesn't exist on android; instead I get the 
warnings for various *.rc files that exist in /). I haven't manage to figure 
out 
yet what static initializers or similar are responsible for reading files they 
shouldn't be reading though.

Marijn

On Saturday, May 05, 2012 12:21:45 AM Joan wrote:
> Hi all,
> 
> I've been playing with brew trying to compile and use krita on mac, and
> after a few patches for some formulas (and some help of krita devs) I've
> been able to compile it properly.
> The problem is that I'm getting a ton of errors similar to this
> 
> 05/05/12 0:16:52,079 [0x0-0x70070].org.calligra.krita: "KConfigIni: In file
> /mach_kernel, line 1: " Invalid entry (missing '=')
> 05/05/12 0:16:52,079 [0x0-0x70070].org.calligra.krita: "KConfigIni: In file
> /mach_kernel, line 2: " Invalid entry (missing '=')
> 05/05/12 0:16:52,079 [0x0-0x70070].org.calligra.krita: "KConfigIni: In file
> /mach_kernel, line 3: " Invalid entry (missing '=')
> 05/05/12 0:16:52,079 [0x0-0x70070].org.calligra.krita: "KConfigIni: In file
> /mach_kernel, line 4: " Invalid entry (missing '=')
> 
> Do you know of an application that has fixed this problems? Any application
> that works properly?
> 
> For the interested, the modified formulas are here pending to be
> accepted/rejected:
> https://github.com/Homebrew/homebrew-boneyard/pulls
> Also you need to follow the instructions on setting dbus daemon at
> http://community.kde.org/index.php?title=Mac&action=historysubmit&diff=1429
> 0&oldid=14088#Running_KDE_Applications
> 
> Also the calligra formula I am using at the moment is this
> https://github.com/aseques/homebrew/blob/calligra/Library/Formula/calligra.
> rb
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: calligra:fill-style-name and friends

[Marijn Kruisselbrink]

On Wednesday, May 16, 2012 10:42:38 AM Jos van den Oever wrote:
> calligra:fill-style-name:
> -
>  fo:background- color="#00" style:vertical-align="bottom"/>
>   which points to
> 
>draw:transparency="88%"/>
> 
> (after converting me03_different_color_pattern.xls)
> 
> Do style:background-color and style:background-image not suffice? A
> background image can be nearly anything.
Yes, a background image would work great as fallback for other office suites, 
but not if you want to allow actual editing of backgrounds. At the moment I 
think the only background style sheets supports that is not just an 
image/color is hatches, but gradients would probably not be very hard to 
support too, and there isn't really a way to express that with standard odf.
So the calligra:fill-style-name attribute references a graphic style that is 
used as background for the table cell.

> calligra:vertical-distributed
> -
>  calligra:vertical-distributed="distributed" fo:wrap-option="wrap"
> style:text-align-source="fix" style:vertical- align="top"/>
> (after converting me00_text_alignment_hc_vj_formatting.xls)
Excel has a couple more vertical alignment options than odf supports (and 
sheets supports them too, although not exposed in the UI), so
we use this extra attribute to store that information. The attribute can be 
either empty or have value "distributed" (and together with the vertical-align 
property that then determines what the actual vertical alignment/distribution 
is).

> calligra:number-length
> --
>   number:textual="true"/>
> (after converting me07_date_formatting.xlsx)
Again a feature Excel supports that odf doesn't. Extra-short here means that 
the month is only displayed as the first character (not sure how you're 
supposed to distinguish months that start with the same letter, but that's 
what Excel does...)

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Important must read: Splitting UI out of KoDocument

[Marijn Kruisselbrink]

On Monday, May 21, 2012 11:17:32 PM C. Boemann wrote:
> Such a big branch has a tendency to bit rot quickly so please do your
> checking and reviewing quickly so we can merge within a week or so. If we
> don't hear from you we will assume you have tested and found no problems.
> 
> It's unlikely that there will be no problems, so I urge you to check. We
> will be at assistance and even do most fixes, but some things probably
> requires your inside knowledge of how your app works.

Haven't done any deep testing yet, but I noticed about 10 or so "FIXME" 
comments and commented out code being introduced in sheets. I assume you're 
planning on fixing those known regressions before merging? (things like saving 
of active sheet/cell, part of the INFO() function, etc)

Marijn

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Important must read: Splitting UI out of KoDocument

[Marijn Kruisselbrink]

On Tuesday, May 22, 2012 08:50:10 PM C. Boemann wrote:
> On Tuesday 22 May 2012 20:45:15 Marijn Kruisselbrink wrote:
> > On Monday, May 21, 2012 11:17:32 PM C. Boemann wrote:
> > > Such a big branch has a tendency to bit rot quickly so please do your
> > > checking and reviewing quickly so we can merge within a week or so. If
> > > we don't hear from you we will assume you have tested and found no
> > > problems.
> > > 
> > > It's unlikely that there will be no problems, so I urge you to check.
> > > We will be at assistance and even do most fixes, but some things
> > > probably requires your inside knowledge of how your app works.
> > 
> > Haven't done any deep testing yet, but I noticed about 10 or so "FIXME"
> > comments and commented out code being introduced in sheets. I assume
> > you're planning on fixing those known regressions before merging?
> > (things like saving of active sheet/cell, part of the INFO() function,
> > etc)
> Well not fixing on my own, or i would have doneit already. So at the very
> least i was hoping some kind of hint from you so i can do the right thing.
> 
> I'll take a second look on my own, but feel free to reply with some
> suggestions if you have some
Well, I haven't quite studied what the effects of the KoDocument/KoPart split 
are; so if you have some hints on how to get to a view from a KoDocument 
instance after the refactor, the rest of at least the part of the code saving 
view settings should be trivial (is Sheets the only application that stores 
some of the view state in files?)

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Use KoModeBox in Sheets

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105175/#review14491
---

Ship it!


Ship It!

- Marijn Kruisselbrink


On June 7, 2012, 3:50 p.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105175/
> ---
> 
> (Updated June 7, 2012, 3:50 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> Sheets is not a canvas base application, so just like Words the metaphor of a 
> toolbox is wrong.
> 
> This patch uses the same ui that Words has, increasing the commonality 
> between the productivity application.
> 
> 
> Diffs
> -
> 
>   libs/main/KoModeBox.cpp 24ca271 
>   sheets/part/CellToolFactory.cpp fd3df68 
>   sheets/part/View.cpp 77667ba 
> 
> Diff: http://git.reviewboard.kde.org/r/105175/diff/
> 
> 
> Testing
> ---
> 
> Nothing special, apart from having been used in Words since 2.4. well, 
> naturally I tested that it works in Sheets
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Remove some deprecated calls and fix a typing error

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103057/#review14498
---

Ship it!


the tables/sheets changes look good to me.

- Marijn Kruisselbrink


On Nov. 6, 2011, 5:35 p.m., Mauro Levra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103057/
> ---
> 
> (Updated Nov. 6, 2011, 5:35 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> Remove some deprecated calls (dates/locale) and fix a typing error (== 
> instead of =).
> 
> 
> Diffs
> -
> 
>   filters/tables/opencalc/opencalcexport.cc ab32787 
>   filters/words/rtf/import/rtf-qt/src/UserPropsDestination.cpp 4e6d185 
>   plan/libs/kernel/kptcommand.cpp 74c4979 
>   plan/libs/models/kcalendar/kdatepicker.cpp 94e7da38 
>   plan/libs/models/kcalendar/kdatetable.cpp 57ed05d 
>   plan/plugins/schedulers/tj/taskjuggler/TjMessageHandler.cpp 066036f 
>   plan/plugins/schedulers/tj/taskjuggler/Utility.cpp 113a442 
>   tables/plugins/calendar/CalendarTool.cpp 44e4cf4 
>   tables/ui/CellToolBase.cpp 8c0d66a 
>   tables/ui/CellToolBase_p.cpp 5d3cf73 
> 
> Diff: http://git.reviewboard.kde.org/r/103057/diff/
> 
> 
> Testing
> ---
> 
> Only built it and related warnings were gone.
> 
> 
> Thanks,
> 
> Mauro Levra
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: rename the app icon of Calligra sheets from kspread to sheets

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105583/#review15950
---

Ship it!


Sorry that I missed this review request. Looks good to me, indeed please 
backport too.

- Marijn Kruisselbrink


On July 15, 2012, 6:20 p.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105583/
> ---
> 
> (Updated July 15, 2012, 6:20 p.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and C. Boemann.
> 
> 
> Description
> ---
> 
> The running Calligra sheets currently has as icon the "unknown" icon.
> Reason is that the icon installed is still named "*-kspread" and also used by 
> that name in all-but-one places.
> This place is "AboutData", which has set as icon name the string "sheets", as 
> by default set from the app id.
> 
> Also still using the id "kspread" for the icon is not perfect from a 
> consistent appearance POV :)
> 
> Attached patch renames the installed icons to *-sheets and also adapts all 
> places which used the "kspread" icon name.
> 
> (Only nitpick is that the actual icons are still the old ones from KOffice 
> 1.* times(?), as the new ones are not yet done.
> But those are still better than the "unknown" :) )
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -
> 
>   active/qml/DocumentTypeSelector.qml 73fecf0 
>   sheets/CMakeLists.txt 41ce521 
>   sheets/data/pics/hi16-app-kspread.png 2fc3d86 
>   sheets/data/pics/hi16-app-sheets.png PRE-CREATION 
>   sheets/data/pics/hi22-app-kspread.png 9f8c807 
>   sheets/data/pics/hi22-app-sheets.png PRE-CREATION 
>   sheets/data/pics/hi32-app-kspread.png 5161357 
>   sheets/data/pics/hi32-app-sheets.png PRE-CREATION 
>   sheets/data/pics/hi48-app-kspread.png b908ae9 
>   sheets/data/pics/hi48-app-sheets.png PRE-CREATION 
>   sheets/part/CellToolFactory.cpp 4573c10 
>   sheets/sheets.desktop af637b0 
>   sheets/sheetspart.desktop 09f494e 
> 
> Diff: http://git.reviewboard.kde.org/r/105583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Enabling Sheets to show plugin items on Configure Sheets/Plugins page

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106220/#review18119
---

Ship it!


Looks good to me

- Marijn Kruisselbrink


On Aug. 26, 2012, 2:23 p.m., Yuri Chornoivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106220/
> ---
> 
> (Updated Aug. 26, 2012, 2:23 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> Plugins page in settings dialog is empty in the current versions of Calligra 
> Sheets (2.5 and git/master).
> 
> As there have been a need for some plugin items for a documentation 
> screenshot, it was reasonable to enable some plugins by fixing KSpread 
> leftovers.
> 
> 
> This addresses bug 291343.
> http://bugs.kde.org/show_bug.cgi?id=291343
> 
> 
> Diffs
> -
> 
>   sheets/part/ToolRegistry.cpp bdbac72 
>   sheets/part/dialogs/PreferenceDialog.cpp 4856dad 
>   sheets/plugins/calendar/kspread_plugin_tool_calendar.desktop 4810eec 
> 
> Diff: http://git.reviewboard.kde.org/r/106220/diff/
> 
> 
> Testing
> ---
> 
> The items for function plugins appear in the list. However, it seems that 
> some issues left. Console shows the messages like
> 
> plugins should not have a 'lib' prefix: "libkspreadsolver.so"
> kdecore (KPluginInfo): found 0 offers for "InformationModule"
> 
> Do not know if these are critical.
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

[Marijn Kruisselbrink]

> On Nov. 26, 2012, 6:51 p.m., Thorsten Zachmann wrote:
> > sheets/functions/information.cpp, lines 193-201
> > 
> >
> > This seems to be wrong. It should return the number of of documents in 
> > the vlaue and not true and false.
> 
> Boudewijn Rempt wrote:
> well, no -- I checked in 2.4, and back then it already returning a bool:
> 
> if (type == "numfile")
> return Value(KoDocument::documentList() ? 
> KoDocument::documentList()->count() : 0);

How is that returning a bool? If there is a documentList it returns the size of 
it, otherwise it returns 0; but it definitely always returns (and should 
return) a number.


> On Nov. 26, 2012, 6:51 p.m., Thorsten Zachmann wrote:
> > sheets/tests/TestInformationFunctions.cpp, line 338
> > 
> >
> > This looks wrong. The test was working  before and it should still work 
> > with the fix.

Yes, this change definitely seems wrong. Since you changed the implementation 
to return a bool you had to change the test to match, but you never should have 
changed the implementation to return a non-number.


- Marijn


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107459/#review22589
---


On Nov. 25, 2012, 4:44 p.m., Sujith Haridasan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107459/
> ---
> 
> (Updated Nov. 25, 2012, 4:44 p.m.)
> 
> 
> Review request for Calligra, Arjen Hiemstra, Boudewijn Rempt, Inge Wallin, 
> and C. Boemann.
> 
> 
> Description
> ---
> 
> This patch helps to pass the issue in the 
> http://build.kde.org/job/calligra_master/323/testReport/(root)/TestSuite/sheets_InformationFunctions/
>  because of which the test case TestInformationFunctions were failing.
> 
> 
> The failure is as below:
> FAIL!  : Calligra::Sheets::TestInformationFunctions::testINFO() Compared 
> values are not the same
>Actual (evaluate("ISNUMBER(INFO(\"numfile\"))",z)): Boolean: FALSE
>Expected ((z)): Boolean: TRUE
>Loc: 
> [/srv/jenkins/workspace/calligra_master/sheets/tests/TestInformationFunctions.cpp(338)]
> 
> 
> Diffs
> -
> 
>   libs/main/KoApplication.h b0bcab2 
>   libs/main/KoApplication.cpp 8ac4639 
>   sheets/functions/information.cpp 5ae962d 
>   sheets/tests/TestInformationFunctions.cpp d0adc68 
> 
> Diff: http://git.reviewboard.kde.org/r/107459/diff/
> 
> 
> Testing
> ---
> 
> I had done testing on my host machine. And here is the output:
> 
> sujith@kdekiddo:/media/kdedeveloper/kde-dev/kde/build/KDE/calligra/sheets/tests$
>  ./TestInformationFunctions
> * Start testing of Calligra::Sheets::TestInformationFunctions 
> *
> Config: Using QTest library 4.8.4, Qt 4.8.4
> QDEBUG : Calligra::Sheets::TestInformationFunctions::initTestCase() 
> qttest(27285)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open 
> ksycoca from "/home/sujith/.kde-unit-test/cache-kdekiddo/ksycoca4"
> PASS   : Calligra::Sheets::TestInformationFunctions::initTestCase()
> PASS   : Calligra::Sheets::TestInformationFunctions::testAREAS()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCELL()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOLUMN()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOLUMNS()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOUNT()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOUNTA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOUNTBLANK()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOUNTIF()
> PASS   : Calligra::Sheets::TestInformationFunctions::testERRORTYPE()
> PASS   : Calligra::Sheets::TestInformationFunctions::testFORMULA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testINFO()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISBLANK()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISERR()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISERROR()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISEVEN()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISFORMULA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISLOGICAL()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISNONTEXT()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISNA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISNUMBER()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISODD()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISTEXT()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISREF()
> PASS   

Re: Review Request: Add a parent parameter to CanvasItem in sheets/part/

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107514/#review22776
---

Ship it!


Ship It!

- Marijn Kruisselbrink


On Nov. 29, 2012, 3:23 p.m., Philip Hoof wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107514/
> ---
> 
> (Updated Nov. 29, 2012, 3:23 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> Add a parent parameter with default = 0 to the constructor of CanvasItem
> 
> 
> Diffs
> -
> 
>   sheets/part/CanvasItem.h dfbefdc 
>   sheets/part/CanvasItem.cpp 8c54907 
> 
> Diff: http://git.reviewboard.kde.org/r/107514/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Philip Hoof
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Compile errors while trying to build with Windows build of calligrasheetscommon

[Marijn Kruisselbrink]

Old versions of MSVC did not include a definition of atanh (I'm not sure if
newer versions do, but at least MSVC 2012 seems to). When building kde
applications on windows, wrapper headers are used that make sure among
others this symbol exist too (see
https://projects.kde.org/projects/kdesupport/kdewin/repository/revisions/master/entry/include/msvc/math.h#L204
for
example). If you have kdewin, by making sure that its msvc/math.h is found
before msvc's this error should go away...

Marijn

On Thu, Dec 13, 2012 at 12:31 AM, Philip Van Hoof wrote:

> Hi there,
>
> I worked around these issues while building our application against
> Calligra's Sheets component:
>
> I could copy and paste assetfactory.cpp but it comes down to a include
> that ends up including Number.h. Not sure what that stuff with kglobal.h
> is, I just added a typedef for mode_t as a workaround.
>
> I would think that sys/types.h would do this on Win32, but apparently
> not.
>
> [  1%] Building CXX object
> qframework/CMakeFiles/qframework.dir/assetfactory.cpp.obj
> assetfactory.cpp
> R:\include\kglobal.h(397) : error C2146: syntax error : missing ';' before
> identifier 'umask'
> R:\include\kglobal.h(397) : error C4430: missing type specifier - int
> assumed. Note: C++ does not support default-int
> R:\include\kglobal.h(397) : error C4430: missing type specifier - int
> assumed. Note: C++ does not support default-int
> c:\users\root\kde4\inst\include\sheets\Number.h(65) : error C2039: 'atanh'
> : is not a member of '`global namespace''
> c:\users\root\kde4\inst\include\sheets\Number.h(65) : error C3861:
> 'atanh': identifier not found
> jom: W:\repos\q-bix-build\qframework\CMakeFiles\qframework.dir\build.make
> [qframework\CMakeFiles\qframework.dir\assetfactory.cpp.obj] Error 2
> jom: W:\repos\q-bix-build\CMakeFiles\Makefile2
> [qframework\CMakeFiles\qframework.dir\all] Error 2
> jom: W:\repos\q-bix-build\Makefile [all] Error 2
>
> W:\repos\q-bix-build>jom
>
> jom 1.0.12 - empower your cores
>
> [  0%] Building CXX object
> qframework/CMakeFiles/qframework.dir/assetfactory.cpp.obj
> assetfactory.cpp
> c:\users\root\kde4\inst\include\sheets\Number.h(65) : error C2039: 'atanh'
> : is not a member of '`global namespace''
> c:\users\root\kde4\inst\include\sheets\Number.h(65) : error C3861:
> 'atanh': identifier not found
> jom: W:\repos\q-bix-build\qframework\CMakeFiles\qframework.dir\build.make
> [qframework\CMakeFiles\qframework.dir\assetfactory.cpp.obj] Error 2
> jom: W:\repos\q-bix-build\CMakeFiles\Makefile2
> [qframework\CMakeFiles\qframework.dir\all] Error 2
> jom: W:\repos\q-bix-build\Makefile [all] Error 2
>
> W:\repos\q-bix-build>jom
>
> Kind regards,
>
> Philip
>
> --
>
>
> Philip Van Hoof
> Software developer
> Codeminded BVBA - http://codeminded.be
>
> ___
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Move ElapsedTime class to a private header that wont be installed

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107717/#review23471
---

Ship it!


LGTM

- Marijn Kruisselbrink


On Dec. 14, 2012, 1:39 p.m., Philip Hoof wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107717/
> ---
> 
> (Updated Dec. 14, 2012, 1:39 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> From 6df02b31d66934ac57a4bce123bab8fcc0dbdf82 Mon Sep 17 00:00:00 2001
> From: Philip Van Hoof 
> Date: Fri, 14 Dec 2012 14:34:49 +0100
> Subject: [PATCH] Move ElapsedTime class to a private header that wont be
>  installed
> 
> This also fixes a old-style-cast problem in the class's destructor
> 
> 
> Diffs
> -
> 
>   sheets/ElapsedTime_p.h PRE-CREATION 
>   sheets/Global.h 1759095 
>   sheets/RecalcManager.cpp c5674f2 
>   sheets/part/CanvasBase.cpp f973f40 
>   sheets/part/Headers.cpp f29408f 
>   sheets/part/View.cpp 6a12d45 
>   sheets/DocBase.cpp d67c66d 
>   sheets/DependencyManager.cpp 60e82e8 
> 
> Diff: http://git.reviewboard.kde.org/r/107717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Philip Hoof
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Impementation-dependent casts from uchar to char

[Marijn Kruisselbrink]

On Wed, Jan 2, 2013 at 1:26 PM, Jaroslaw Staniek  wrote:

> Hello Marijn,
> There are impementation-dependent casts from uchar to char:
>
Ah yes, that is indeed not good.

Since this is your code, could you point me what are these values?
>
I assume I copied these values from whatever document documents the
encryption ms office uses... Not sure what the nicest way is to hardcode
binary data in c++ source code... "\xfe\xa7\xd2\x76\x3b\x4b\x9e\x79" might
work, but has the downside that there is a trailing 0 byte that should not
be included in the qbytearray. Signed char constants seem ugly, since
QByteArray expects regular char, not signed char (although I guess it would
be safe, since the signed->unsigned underflowing conversion is defined
unlike this unsigned->signed overflow).

Marijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Impementation-dependent casts from uchar to char

[Marijn Kruisselbrink]

On Wed, Jan 2, 2013 at 2:50 PM, Jaroslaw Staniek  wrote:

> On 2 January 2013 22:52, Marijn Kruisselbrink 
> wrote:
> > On Wed, Jan 2, 2013 at 1:26 PM, Jaroslaw Staniek 
> wrote:
> >>
> >> Hello Marijn,
> >> There are impementation-dependent casts from uchar to char:
> >
> > Ah yes, that is indeed not good.
> >
> >> Since this is your code, could you point me what are these values?
> >
> > I assume I copied these values from whatever document documents the
> > encryption ms office uses... Not sure what the nicest way is to hardcode
> > binary data in c++ source code... "\xfe\xa7\xd2\x76\x3b\x4b\x9e\x79"
> might
> > work, but has the downside that there is a trailing 0 byte that should
> not
> > be included in the qbytearray. Signed char constants seem ugly, since
> > QByteArray expects regular char, not signed char (although I guess it
> would
> > be safe, since the signed->unsigned underflowing conversion is defined
> > unlike this unsigned->signed overflow).
>
> It's implementaton defined:
> http://c0x.coding-guidelines.com/6.4.4.4.html#891
>
> How about this, similarly safe only when sizeof(char)==1 but warnings
> disappear:
>
sizeof(char) is always 1, so yes, that looks good to me (if you replace
sizeof(char) with 1).


>
> -const char blockKeyData1[] = {0xfe, 0xa7, 0xd2, 0x76,
> 0x3b, 0x4b, 0x9e, 0x79};
> -QByteArray blockKey1(blockKeyData1, sizeof(blockKeyData1));
> +const char blockKeyData1[] =
> "\xfe\xa7\xd2\x76\x3b\x4b\x9e\x79";
> +QByteArray blockKey1(blockKeyData1, sizeof(blockKeyData1)
> - sizeof(char));
>
> --
> regards / pozdrawiam, Jaroslaw Staniek
>  Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
>  Qt Certified Specialist | http://qt-project.org
>  http://www.linkedin.com/in/jstaniek
>
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 107866: Pivot Tables for Calligra Sheets

[Marijn Kruisselbrink]

> On Jan. 14, 2013, 11:17 p.m., Inge Wallin wrote:
> > I think it's very high time that somebody who knows Sheets took a look at 
> > this review request. Nobody should have to wait 3 weeks to get a review, 
> > especially for something as important as this.

Yes, I'm sorry; I took a quick look earlier, and I don't think most of the 
issues are actually related to Sheets. It is definitely an important feature to 
have, but in it's current state (with buttons that don't do anything, UI that 
is confusing, limitations that are not visible in the UI), I don't think it is 
ready to be part of a release. It would have been nice if this could somehow 
have been a plugin that we could ship separately, but I don't think that is 
quite possible at the moment.
Most of these things are of course to blame on me, for not having been more 
active during the development of this branch/summer of code project. I'll try 
to spend some time during my commutes this week to come up with some way this 
can at least be merged without actually confusing users with it (or maybe 
thinking of a way the functionality can be moved to be a plugin), as well as 
doing a more detailed review of the implementation itself.

Additionally from a quick look, there are some issues with coding 
style/conventions (files should have CamelCase names), qDebug()s that should 
probably be removed.


- Marijn


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107866/#review25540
---


On Dec. 23, 2012, 9:41 a.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107866/
> ---
> 
> (Updated Dec. 23, 2012, 9:41 a.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> I had built Pivot Tables as part of my GSoC 2012 project. Some minor features 
> were remaining which i finished lately. I have committed my latest code to 
> the branch. 
> 
> How to use:   Blog link : 
> http://jigarraisinghani.blogspot.in/2012/07/pivot-tablesupdate-here-is-update-about.html
>   Video link: http://www.youtube.com/watch?v=uz2PGVNyseA
> 
>  
> 
> Note:
> 1) Please drop only the fields containing non alphabets in "Values" and 
> support is built for only 1 field in "Values". You can drop various in "Rows" 
> & "Columns".
> 
> Features Still to be built:
> 1) Page Fields: Only GUI is there, but the functionality is yet to be added.
> 2) Pivot Options: The functionality only contains simple functions yet. The 
> Base Field, Base Item functionalities are yet to be added.
> 
> Also note that pivot tables only makes sense if used in correct manner.
> 
> 
> Diffs
> -
> 
> 
> Diff: http://git.reviewboard.kde.org/r/107866/diff/
> 
> 
> Testing
> ---
> 
> I have tested the code for different test cases(data sets) and it works fine.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 107866: Pivot Tables for Calligra Sheets

[Marijn Kruisselbrink]

> On Jan. 14, 2013, 11:17 p.m., Inge Wallin wrote:
> > I think it's very high time that somebody who knows Sheets took a look at 
> > this review request. Nobody should have to wait 3 weeks to get a review, 
> > especially for something as important as this.
> 
> Marijn Kruisselbrink wrote:
> Yes, I'm sorry; I took a quick look earlier, and I don't think most of 
> the issues are actually related to Sheets. It is definitely an important 
> feature to have, but in it's current state (with buttons that don't do 
> anything, UI that is confusing, limitations that are not visible in the UI), 
> I don't think it is ready to be part of a release. It would have been nice if 
> this could somehow have been a plugin that we could ship separately, but I 
> don't think that is quite possible at the moment.
> Most of these things are of course to blame on me, for not having been 
> more active during the development of this branch/summer of code project. 
> I'll try to spend some time during my commutes this week to come up with some 
> way this can at least be merged without actually confusing users with it (or 
> maybe thinking of a way the functionality can be moved to be a plugin), as 
> well as doing a more detailed review of the implementation itself.
> 
> Additionally from a quick look, there are some issues with coding 
> style/conventions (files should have CamelCase names), qDebug()s that should 
> probably be removed.

(also it's hard to comment on the actual code, since there doesn't seem to be 
an actual diff uploaded to this review request)


- Marijn


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107866/#review25540
---


On Dec. 23, 2012, 9:41 a.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107866/
> -------
> 
> (Updated Dec. 23, 2012, 9:41 a.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> I had built Pivot Tables as part of my GSoC 2012 project. Some minor features 
> were remaining which i finished lately. I have committed my latest code to 
> the branch. 
> 
> How to use:   Blog link : 
> http://jigarraisinghani.blogspot.in/2012/07/pivot-tablesupdate-here-is-update-about.html
>   Video link: http://www.youtube.com/watch?v=uz2PGVNyseA
> 
>  
> 
> Note:
> 1) Please drop only the fields containing non alphabets in "Values" and 
> support is built for only 1 field in "Values". You can drop various in "Rows" 
> & "Columns".
> 
> Features Still to be built:
> 1) Page Fields: Only GUI is there, but the functionality is yet to be added.
> 2) Pivot Options: The functionality only contains simple functions yet. The 
> Base Field, Base Item functionalities are yet to be added.
> 
> Also note that pivot tables only makes sense if used in correct manner.
> 
> 
> Diffs
> -
> 
> 
> Diff: http://git.reviewboard.kde.org/r/107866/diff/
> 
> 
> Testing
> ---
> 
> I have tested the code for different test cases(data sets) and it works fine.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 107866: Pivot Tables for Calligra Sheets

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107866/#review25627
---



sheets/dialogs/pivot.h
<http://git.reviewboard.kde.org/r/107866/#comment19539>

All the existing code has this as:
namespace Calligra
{
namespace Sheets
{

(so no indentation, and every { on a separate line... which seems a bit 
verbose, but at least get rid of the indentation)



sheets/dialogs/pivot.cpp
<http://git.reviewboard.kde.org/r/107866/#comment19540>

inconsistent indentation, please use 4 spaces everywhere, also the 
prevailing code-style places { on the same line as if (and for/while/...) 
statements. Only for methods, classes (and namespaces it seems) { gets a line 
of its own



sheets/dialogs/pivotfilters.h
<http://git.reviewboard.kde.org/r/107866/#comment19541>

oh, and please add comments behind these to make it clear what block they 
close; so change these two lines to:
} // namespace Sheets
} // namespace Calligra



sheets/dialogs/pivotfilters.cpp
<http://git.reviewboard.kde.org/r/107866/#comment19542>

Some consistent ordering of #include's would be nice too, in general put 
the .h that matches the .cpp first, and then the rest in groups either most 
local to most global or the other way around, not sure which is most common in 
sheets code, so:
// Pivot table includes
// Sheets includes
// Calligra includes
// KDE includes
// Qt includes
// C++ includes
or the exact reverse order.



sheets/dialogs/pivotfilters.cpp
<http://git.reviewboard.kde.org/r/107866/#comment19543>

can you come up with more descriptive names than flag, flag1 and flag2?


- Marijn Kruisselbrink


On Jan. 15, 2013, 7:29 p.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107866/
> ---
> 
> (Updated Jan. 15, 2013, 7:29 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> I had built Pivot Tables as part of my GSoC 2012 project. Some minor features 
> were remaining which i finished lately. I have committed my latest code to 
> the branch. 
> 
> How to use:   Blog link : 
> http://jigarraisinghani.blogspot.in/2012/07/pivot-tablesupdate-here-is-update-about.html
>   Video link: http://www.youtube.com/watch?v=uz2PGVNyseA
> 
>  
> 
> Note:
> 1) Please drop only the fields containing non alphabets in "Values" and 
> support is built for only 1 field in "Values". You can drop various in "Rows" 
> & "Columns".
> 
> Features Still to be built:
> 1) Page Fields: Only GUI is there, but the functionality is yet to be added.
> 2) Pivot Options: The functionality only contains simple functions yet. The 
> Base Field, Base Item functionalities are yet to be added.
> 
> Also note that pivot tables only makes sense if used in correct manner.
> 
> 
> Diffs
> -
> 
>   sheets/CMakeLists.txt f617322 
>   sheets/sheets.rc 7eae858 
> 
> Diff: http://git.reviewboard.kde.org/r/107866/diff/
> 
> 
> Testing
> ---
> 
> I have tested the code for different test cases(data sets) and it works fine.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 107866: Pivot Tables for Calligra Sheets

[Marijn Kruisselbrink]

> On Jan. 14, 2013, 11:17 p.m., Inge Wallin wrote:
> > I think it's very high time that somebody who knows Sheets took a look at 
> > this review request. Nobody should have to wait 3 weeks to get a review, 
> > especially for something as important as this.
> 
> Marijn Kruisselbrink wrote:
> Yes, I'm sorry; I took a quick look earlier, and I don't think most of 
> the issues are actually related to Sheets. It is definitely an important 
> feature to have, but in it's current state (with buttons that don't do 
> anything, UI that is confusing, limitations that are not visible in the UI), 
> I don't think it is ready to be part of a release. It would have been nice if 
> this could somehow have been a plugin that we could ship separately, but I 
> don't think that is quite possible at the moment.
> Most of these things are of course to blame on me, for not having been 
> more active during the development of this branch/summer of code project. 
> I'll try to spend some time during my commutes this week to come up with some 
> way this can at least be merged without actually confusing users with it (or 
> maybe thinking of a way the functionality can be moved to be a plugin), as 
> well as doing a more detailed review of the implementation itself.
> 
> Additionally from a quick look, there are some issues with coding 
> style/conventions (files should have CamelCase names), qDebug()s that should 
> probably be removed.
> 
> Marijn Kruisselbrink wrote:
> (also it's hard to comment on the actual code, since there doesn't seem 
> to be an actual diff uploaded to this review request)
> 
> Jigar Raisinghani wrote:
> I have added a diff for new files added(Revision 1) & some other files 
> which were edited(Revision 2). I will take care of the CamelCase, qDebug.
> 
> Moreover, I had deliberately left some of the buttons in the UI 
> non-functional(as they are yet to be developed). I can remove the 
> non-functional buttons and tweak the UI to make it possible for at least a 
> certain release. If not a "Ship It!", I just wanted a feedback so that I 
> could move ahead. The functionality for non-functional buttons could be added 
> later and so could the buttons be. For the time being I could remove those.

Okay, I pushed a change to your branch that moves all your changes to 
plugins/staging/pivottables (and turned it into a plugin). With that done, I 
don't think there is much stopping this from being merged into master and 
developing it there further.


- Marijn


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107866/#review25540
---


On Jan. 15, 2013, 7:29 p.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107866/
> ---
> 
> (Updated Jan. 15, 2013, 7:29 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> I had built Pivot Tables as part of my GSoC 2012 project. Some minor features 
> were remaining which i finished lately. I have committed my latest code to 
> the branch. 
> 
> How to use:   Blog link : 
> http://jigarraisinghani.blogspot.in/2012/07/pivot-tablesupdate-here-is-update-about.html
>   Video link: http://www.youtube.com/watch?v=uz2PGVNyseA
> 
>  
> 
> Note:
> 1) Please drop only the fields containing non alphabets in "Values" and 
> support is built for only 1 field in "Values". You can drop various in "Rows" 
> & "Columns".
> 
> Features Still to be built:
> 1) Page Fields: Only GUI is there, but the functionality is yet to be added.
> 2) Pivot Options: The functionality only contains simple functions yet. The 
> Base Field, Base Item functionalities are yet to be added.
> 
> Also note that pivot tables only makes sense if used in correct manner.
> 
> 
> Diffs
> -
> 
>   sheets/CMakeLists.txt f617322 
>   sheets/sheets.rc 7eae858 
> 
> Diff: http://git.reviewboard.kde.org/r/107866/diff/
> 
> 
> Testing
> ---
> 
> I have tested the code for different test cases(data sets) and it works fine.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 107866: Pivot Tables for Calligra Sheets

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107866/#review25628
---


(hmm, not used to the reviewboard UI). I meant to add a comment that I only did 
a quick look over for simple style issues so far. I'll try to give more 
comments on the actual implementation tomorrow.

- Marijn Kruisselbrink


On Jan. 15, 2013, 7:29 p.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107866/
> ---
> 
> (Updated Jan. 15, 2013, 7:29 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> I had built Pivot Tables as part of my GSoC 2012 project. Some minor features 
> were remaining which i finished lately. I have committed my latest code to 
> the branch. 
> 
> How to use:   Blog link : 
> http://jigarraisinghani.blogspot.in/2012/07/pivot-tablesupdate-here-is-update-about.html
>   Video link: http://www.youtube.com/watch?v=uz2PGVNyseA
> 
>  
> 
> Note:
> 1) Please drop only the fields containing non alphabets in "Values" and 
> support is built for only 1 field in "Values". You can drop various in "Rows" 
> & "Columns".
> 
> Features Still to be built:
> 1) Page Fields: Only GUI is there, but the functionality is yet to be added.
> 2) Pivot Options: The functionality only contains simple functions yet. The 
> Base Field, Base Item functionalities are yet to be added.
> 
> Also note that pivot tables only makes sense if used in correct manner.
> 
> 
> Diffs
> -
> 
>   sheets/CMakeLists.txt f617322 
>   sheets/sheets.rc 7eae858 
> 
> Diff: http://git.reviewboard.kde.org/r/107866/diff/
> 
> 
> Testing
> ---
> 
> I have tested the code for different test cases(data sets) and it works fine.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108424: updated modebox for words,sheets,author

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108424/#review25630
---


Not sure I like the way this look/what problem this is solving, but I guess I 
can live with the change (I'm not a UI guy after all).

- Marijn Kruisselbrink


On Jan. 15, 2013, 12:34 p.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108424/
> ---
> 
> (Updated Jan. 15, 2013, 12:34 p.m.)
> 
> 
> Review request for Calligra, Inge Wallin, Marijn Kruisselbrink, and Thorsten 
> Zachmann.
> 
> 
> Description
> ---
> 
> I've changed the modebox away from using qtoolbox to a tab bar and stacked 
> widget
> 
> In the future i hope stage can use this too so that is why i include Thorsten 
> specfically too.
> 
> 
> Diffs
> -
> 
>   libs/main/KoModeBox.cpp 8b49f6e 
>   libs/main/KoModeBox_p.h c437757 
> 
> Diff: http://git.reviewboard.kde.org/r/108424/diff/
> 
> 
> Testing
> ---
> 
> played with it, without problems
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108913: remove explicit, but duplicated passing of parameters xmlWriter & mainStyles in Sheets*::saveOdf(...)

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108913/#review27237
---

Ship it!


The xmlWriter & mainStyles parameters pre-date the introduction of 
OdfSavingContext (and KoShapeSavingContext), so yeah, I think it is a good idea 
to clean this up a bit.

- Marijn Kruisselbrink


On Feb. 11, 2013, 8:20 p.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108913/
> ---
> 
> (Updated Feb. 11, 2013, 8:20 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> It confused me when I read the code of saving a Sheet document to ODF:
> "KoXmlWriter& xmlWriter" and "KoGenStyles &mainStyles" are passed explicitly 
> as parameters to Sheet::saveOdfColRowCell(...), Sheet::saveOdfCells(...), and 
> Cell::saveOdf(...), even though they are already members of the also passed 
> "OdfSavingContext& tableContext". By just looking at the method it seemed 
> that xmlWriter and mainStyles were different objects to those which are part 
> of tableContext, which has such objects via the shapeContext member. Only 
> when going up the callstack it could be found that these references are just 
> duplicates.
> 
> This confusion seems also the reason why in Cell::saveOdf(...) a shapeContext 
> was recreated with these objects, instead of using the shapeContext of 
> tableContext.
> 
> Attached patch changes the signatures of those methods to only pass 
> "OdfSavingContext& tableContext", like also done in similar methods, and to 
> simply create helper references to xmlWriter and mainStyles in the method 
> bodies, as needed. It also removes the unneeded additional creation of a 
> shapeContext.
> 
> Resulting code should be less confusing :)
> 
> (Came across the code during of my currently done big tuning of 
> KoOdfWriteStore)
> 
> 
> Diffs
> -
> 
>   sheets/Sheet.cpp 1b11a6f 
>   sheets/Sheet.h 9d9f1a7 
>   sheets/Cell.cpp fef7846 
>   sheets/Cell.h 015e847 
> 
> Diff: http://git.reviewboard.kde.org/r/108913/diff/
> 
> 
> Testing
> ---
> 
> all Sheets tests pass as before, richtext in cell roundtrip also worked
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109284: Normalize SIGNAL and SLOT signatures in Sheets

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109284/#review28558
---

Ship it!


Ship It!

- Marijn Kruisselbrink


On March 4, 2013, 8:44 p.m., Inge Wallin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109284/
> ---
> 
> (Updated March 4, 2013, 8:44 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> Normalize all SIGNAL and SLOT signatures in sheets.  I asked Mek beforehand 
> and he said he liked it and would look at the diff.
> 
> 
> Diffs
> -
> 
>   sheets/Map.cpp 66c950c 
>   sheets/MapModel.cpp f2610c7 
>   sheets/NamedAreaManager.cpp c980a71 
>   sheets/Sheet.cpp 6ae75fa 
>   sheets/SheetAccessModel.cpp 7b80318 
>   sheets/commands/SpellCheckCommand.cpp c762428 
>   sheets/dialogs/AddNamedAreaDialog.cpp 090ec34 
>   sheets/dialogs/ConditionalDialog.cpp 2728527 
>   sheets/dialogs/ConsolidateDialog.cpp d9d708b 
>   sheets/dialogs/DatabaseDialog.cpp bc25c4c 
>   sheets/dialogs/FormulaDialog.cpp 5d8acfb 
>   sheets/dialogs/GotoDialog.cpp 9ae4be2 
>   sheets/dialogs/LayoutDialog.cpp 69772dd 
>   sheets/dialogs/LinkDialog.cpp f5f7332 
>   sheets/dialogs/NamedAreaDialog.cpp 87d597c 
>   sheets/dialogs/ShowColRowDialog.cpp 0aa073b 
>   sheets/dialogs/ShowDialog.cpp e703e3d 
>   sheets/dialogs/StyleManagerDialog.cpp b932002 
>   sheets/interfaces/SheetAdaptor.cpp 97bd61d 
>   sheets/part/CanvasItem.cpp e7577b5 
>   sheets/part/Doc.cpp c9d60cf 
>   sheets/part/HeaderItems.cpp b589542 
>   sheets/part/HeaderWidgets.cpp 9fb14bb 
>   sheets/part/View.cpp 0ad5be8 
>   sheets/part/dialogs/PreferenceDialog.cpp 36a91ee 
>   sheets/plugins/calendar/CalendarTool.cpp 71c4332 
>   sheets/plugins/scripting/ScriptingListener.cpp 508fb5d 
>   sheets/shape/SheetsEditor.cpp 2cc3247 
>   sheets/shape/TableShape.cpp 43777eb 
>   sheets/ui/CellEditor.cpp b0ca432 
>   sheets/ui/CellToolBase.cpp 7591d7a 
>   sheets/ui/FunctionCompletion.cpp b3a4d9b 
>   sheets/ui/LocationComboBox.cpp 7a9d827 
>   sheets/ui/MapViewModel.cpp e66b211 
>   sheets/ui/RegionSelector.cpp 42e711e 
> 
> Diff: http://git.reviewboard.kde.org/r/109284/diff/
> 
> 
> Testing
> ---
> 
> It builds correctly but it should probably be tested too. I haven't done 
> that. One risk is that the filter(s) use some connections that need to be 
> normalized too.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109378/#review28862
---



sheets/ui/CellToolBase.cpp
<http://git.reviewboard.kde.org/r/109378/#comment21606>

what is that number? Can't you use Qt::Key_F2 instead?



sheets/ui/CellToolBase.cpp
<http://git.reviewboard.kde.org/r/109378/#comment21605>

nit: get rid of extra whitespace


- Marijn Kruisselbrink


On March 9, 2013, 10:37 p.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109378/
> ---
> 
> (Updated March 9, 2013, 10:37 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> KAction does not support function keys(F1,F2 etc) as shortCuts. QAction does 
> but KoToolBase does not allow for both KAction* & QAction* at the same time. 
> Added an exception for F2 as needed. 
> 
> Fixed. 
> 
> 
> This addresses bug 291624.
> http://bugs.kde.org/show_bug.cgi?id=291624
> 
> 
> Diffs
> -
> 
>   sheets/ui/CellToolBase.cpp e66ba5b 
> 
> Diff: http://git.reviewboard.kde.org/r/109378/diff/
> 
> 
> Testing
> ---
> 
> Yes, working.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109378/#review28882
---


looks mostly good, a couple of small nits left


sheets/ui/CellToolBase.cpp
<http://git.reviewboard.kde.org/r/109378/#comment21612>

whitespace around == and before ( here and in the other line, so:
if (event->key() == Qt::Key_F2)
Then shouldn't Qt_Delete be Qt::Key_Delete?
and please no tab-characters as whitespace before the comments, use spaces 
instead.


- Marijn Kruisselbrink


On March 10, 2013, 1:39 p.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109378/
> ---
> 
> (Updated March 10, 2013, 1:39 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> KAction does not support function keys(F1,F2 etc) as shortCuts. QAction does 
> but KoToolBase does not allow for both KAction* & QAction* at the same time. 
> Added an exception for F2 as needed. 
> 
> Fixed. 
> 
> 
> This addresses bug 291624.
> http://bugs.kde.org/show_bug.cgi?id=291624
> 
> 
> Diffs
> -
> 
>   sheets/ui/CellToolBase.cpp e66ba5b 
> 
> Diff: http://git.reviewboard.kde.org/r/109378/diff/
> 
> 
> Testing
> ---
> 
> Yes, working.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109378/#review28883
---


And another comment, after fixing the delete case to compile, I don't think the 
behavior is completely as desired. After clearing all the cells it still enters 
the editor, while I don't think that should happen. Maybe just an early return 
from the key press handler would work for this?

- Marijn Kruisselbrink


On March 10, 2013, 1:52 p.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109378/
> ---
> 
> (Updated March 10, 2013, 1:52 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> KAction does not support function keys(F1,F2 etc) as shortCuts. QAction does 
> but KoToolBase does not allow for both KAction* & QAction* at the same time. 
> Added an exception for F2 as needed. 
> 
> Fixed. 
> 
> 
> This addresses bug 291624.
> http://bugs.kde.org/show_bug.cgi?id=291624
> 
> 
> Diffs
> -
> 
>   sheets/ui/CellToolBase.cpp e66ba5b 
> 
> Diff: http://git.reviewboard.kde.org/r/109378/diff/
> 
> 
> Testing
> ---
> 
> Yes, working.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109378: Bug 291624 : "F2 key(Edit_>Modify Cell) doesn't work" FIXED

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109378/#review28885
---

Ship it!



sheets/ui/CellToolBase.cpp
<http://git.reviewboard.kde.org/r/109378/#comment21613>

tiny nit, please get rid of the trailing whitespace on this line and the 
line a bit further down


- Marijn Kruisselbrink


On March 10, 2013, 2:34 p.m., Jigar Raisinghani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109378/
> ---
> 
> (Updated March 10, 2013, 2:34 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> ---
> 
> KAction does not support function keys(F1,F2 etc) as shortCuts. QAction does 
> but KoToolBase does not allow for both KAction* & QAction* at the same time. 
> Added an exception for F2 as needed. 
> 
> Fixed. 
> 
> 
> This addresses bug 291624.
> http://bugs.kde.org/show_bug.cgi?id=291624
> 
> 
> Diffs
> -
> 
>   sheets/ui/CellToolBase.cpp e66ba5b 
> 
> Diff: http://git.reviewboard.kde.org/r/109378/diff/
> 
> 
> Testing
> ---
> 
> Yes, working.
> 
> 
> Thanks,
> 
> Jigar Raisinghani
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 118232: Don't allow the scroll area in a KoModeBox to be focused.

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118232/
---

Review request for Calligra.


Repository: calligra


Description
---

Currently everytime you click a button to change formatting of a cell in sheets 
the scrollarea gets keyboard focus, making further editing very annoying. This 
fixes that behavior.
I'm not sure if any other code/UI depends on this scroll area being focusable 
though?
(two years ago I made the same change in 
5e2cc2ee27a50806b0c2eb16724ad704a6450d9f for KoToolDocker)


Diffs
-

  libs/main/KoModeBox.cpp 91f71e2 

Diff: https://git.reviewboard.kde.org/r/118232/diff/


Testing
---


Thanks,

Marijn Kruisselbrink

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 118232: Don't allow the scroll area in a KoModeBox to be focused.

[Marijn Kruisselbrink]

> On May 21, 2014, 8:15 a.m., Camilla Boemann wrote:
> > I think it's safe enough to commit this, however in the text tool every 
> > botton emits an i_am_done signal which we use to return focus to the 
> > canvas. Some widgets will keep the focus (and we would want them to be 
> > navigatable by keyboard for accessability) and without this signal it wont 
> > work
> > 
> > just some inspiration for testing and further improvement.
> > 
> > That said i'll say ship it but please check that text input widget (like 
> > font selector in text tool) still works

Ah, I was wondering how other apps dealt with this, yes something like that 
would work too, and might indeed be better from the keyboard navigation point 
of view...

Font selectors still seem to work just fine.


- Marijn


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118232/#review58220
-------


On May 20, 2014, 11:42 p.m., Marijn Kruisselbrink wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118232/
> ---
> 
> (Updated May 20, 2014, 11:42 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Currently everytime you click a button to change formatting of a cell in 
> sheets the scrollarea gets keyboard focus, making further editing very 
> annoying. This fixes that behavior.
> I'm not sure if any other code/UI depends on this scroll area being focusable 
> though?
> (two years ago I made the same change in 
> 5e2cc2ee27a50806b0c2eb16724ad704a6450d9f for KoToolDocker)
> 
> 
> Diffs
> -
> 
>   libs/main/KoModeBox.cpp 91f71e2 
> 
> Diff: https://git.reviewboard.kde.org/r/118232/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marijn Kruisselbrink
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 118232: Don't allow the scroll area in a KoModeBox to be focused.

[Marijn Kruisselbrink]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118232/
---

(Updated May 21, 2014, 3:56 p.m.)


Status
--

This change has been marked as submitted.


Review request for Calligra.


Repository: calligra


Description
---

Currently everytime you click a button to change formatting of a cell in sheets 
the scrollarea gets keyboard focus, making further editing very annoying. This 
fixes that behavior.
I'm not sure if any other code/UI depends on this scroll area being focusable 
though?
(two years ago I made the same change in 
5e2cc2ee27a50806b0c2eb16724ad704a6450d9f for KoToolDocker)


Diffs
-

  libs/main/KoModeBox.cpp 91f71e2 

Diff: https://git.reviewboard.kde.org/r/118232/diff/


Testing
---


Thanks,

Marijn Kruisselbrink

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel