gnodet-bot commented on PR #13166:
URL: https://github.com/apache/maven/pull/13166#issuecomment-5725622024
⚠️ **(unresolved, raised by @cstamas @ascheman and previous reviews)
`maven-4.0.x` matrix leg is still a no-op.**
`-P?versions-update` prevents a profile-not-found failure (good), but the
actual problem is different: `maven-4.0.x`'s `impl/maven-core/pom.xml` still
uses `version.maven-*-plugin` property names (the rename to `lifecycle.*`
exists only on `master`). When the workflow runs:
```
mvn versions:update-properties -P?versions-update \
-DincludeProperties="lifecycle.clean-plugin,..." \
-pl impl/maven-core
```
...on `maven-4.0.x`, the properties `lifecycle.clean-plugin` etc. don't
exist in that branch's POM → `versions:update-properties` has nothing to update
→ `git diff --quiet impl/maven-core/pom.xml` is always true → the step exits
with `"No updates found"` every single run. The `maven-4.0.x` leg is a
permanent silent no-op.
**Fix options:**
1. Restrict the matrix to `[master]` until the property rename is
backported: `branch: [master]`
2. Backport the `lifecycle.*` property rename to `maven-4.0.x`
Option 1 is simpler and avoids touching the release branch unnecessarily.
_This comment was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
