gnodet-bot commented on code in PR #13166: URL: https://github.com/apache/maven/pull/13166#discussion_r4044150483
########## .github/workflows/update-lifecycle-plugins.yml: ########## @@ -0,0 +1,86 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Update lifecycle plugin versions + +on: + schedule: + # Every Monday at 08:00 UTC + - cron: '0 8 * * 1' + workflow_dispatch: + +permissions: + contents: read + +jobs: + update-lifecycle-plugins: + runs-on: ubuntu-latest + permissions: + contents: write + pull-requests: write + strategy: + fail-fast: false + matrix: + branch: [master, maven-4.0.x] Review Comment: ⚠️ **`maven-4.0.x` matrix leg is still a silent no-op (unresolved since initial review).** The `versions-update` profile is defined only in **master**'s `pom.xml`. On `maven-4.0.x`, `-P?versions-update` silently skips the profile (the `?` prefix suppresses the failure). `versions:update-properties` then runs with no `<property>` mappings, finds nothing to update, `git diff` stays empty, and the step exits with `"No updates found for maven-4.0.x"` every single run — no PR is ever created. Simplest fix: restrict the matrix to `master` until the property rename and the `versions-update` profile are backported to `maven-4.0.x`. ```suggestion branch: [master] ``` ########## impl/maven-core/src/main/java/org/apache/maven/lifecycle/PluginVersions.java: ########## @@ -27,6 +27,7 @@ * <p> * Versions are read from {@code plugin-versions.properties}, which is filtered * at build time from POM properties ({@code version.maven-<name>-plugin}). + * The properties file uses {@code lifecycle.<name>-plugin} keys. Review Comment: 🔧 **(nit) First Javadoc line is stale.** The newly added second line (`lifecycle.<name>-plugin` keys) is correct, but the first line still says `{@code version.maven-<name>-plugin}`, which is the old property name scheme. Both lines now say different things for what is effectively the same concept. ```suggestion * at build time from POM properties ({@code lifecycle.maven-<name>-plugin}). * The properties file uses those same keys. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
