gnodet-bot commented on code in PR #13166: URL: https://github.com/apache/maven/pull/13166#discussion_r4041463445
########## .github/workflows/update-lifecycle-plugins.yml: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Update lifecycle plugin versions + +on: + schedule: + # Every Monday at 08:00 UTC + - cron: '0 8 * * 1' + workflow_dispatch: + +permissions: + contents: read + +jobs: + update-lifecycle-plugins: + runs-on: ubuntu-latest + permissions: + contents: write + pull-requests: write + strategy: + fail-fast: false + matrix: + branch: [master, maven-4.0.x] + steps: + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + ref: ${{ matrix.branch }} + persist-credentials: false + + - uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1 + with: + java-version: '21' + distribution: 'temurin' + cache: maven + + - name: Update lifecycle plugin versions + run: | + mvn -B eu.maveniverse.maven.plugins:toolbox:0.16.0:plugin-versions \ + -f impl/maven-core \ + -Pversions-update \ Review Comment: ⚠️ **`-Pversions-update` will hard-fail on the `maven-4.0.x` matrix leg.** This PR adds the `versions-update` profile to the root `pom.xml` on `master` only. When the matrix checks out `maven-4.0.x`, that profile does not exist there. Maven 4 treats `-P<profile>` as a *required* profile activation (`activateRequiredProfile()`), and `DefaultMaven.validateRequiredProfiles()` throws `MissingProfilesException` when any required profile is absent — see [`DefaultMaven.java` L565](https://github.com/apache/maven/blob/master/impl/maven-core/src/main/java/org/apache/maven/DefaultMaven.java#L565). The build exits with `BUILD FAILURE` before toolbox runs, so no update PR is ever created for `maven-4.0.x`. @slawekjaranowski raised this in his review comment — still unresolved. Fix options (pick one): 1. **Backport the profile to `maven-4.0.x`** — add the `versions-update` profile to `pom.xml` on that branch. 2. **Drop `-Pversions-update`** — toolbox reads `pluginManagement` from `impl/maven-core/pom.xml` directly (the 13 plugins with `${version.maven-*-plugin}` references are already declared there from #13080), so the profile is not consulted by toolbox at all. @cstamas confirmed this already works without the profile: `mvn toolbox:plugin-versions -f impl/maven-core/ -Dapply`. 3. **Make it optional**: use `-P?versions-update` — Maven silently skips absent optional profiles instead of failing. ########## pom.xml: ########## @@ -1302,5 +1302,157 @@ under the License. </plugins> </build> </profile> + <profile> + <!-- + This profile is NEVER activated during a normal build. + It declares the 13 Maven lifecycle plugins under pluginManagement, + establishing the link between the version.maven-*-plugin properties + (in impl/maven-core/pom.xml) and their corresponding plugin artifacts. Review Comment: 📝 **Clarify what this profile provides to toolbox (or note it is for manual use only).** The comment says the profile lets toolbox "resolve the property-to-GAV mapping". In practice, toolbox reads `pluginManagement` from the project specified by `-f impl/maven-core`, and that POM already declares all 13 lifecycle plugins under its own `<pluginManagement>` (from #13080). This profile adds `versions-maven-plugin` `<properties>` configuration — a different schema that toolbox does not consult. The profile is a valid manual alternative for `mvn versions:update-properties -Pversions-update -pl impl/maven-core`, but it plays no functional role in the `toolbox:plugin-versions` workflow invocation. The comment would be clearer if it noted this distinction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
