gnodet-bot commented on code in PR #13166: URL: https://github.com/apache/maven/pull/13166#discussion_r4044283730
########## .github/workflows/update-lifecycle-plugins.yml: ########## @@ -0,0 +1,86 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Update lifecycle plugin versions + +on: + schedule: + # Every Monday at 08:00 UTC + - cron: '0 8 * * 1' + workflow_dispatch: + +permissions: + contents: read + +jobs: + update-lifecycle-plugins: + runs-on: ubuntu-latest + permissions: + contents: write + pull-requests: write + strategy: + fail-fast: false + matrix: + branch: [master, maven-4.0.x] Review Comment: ⚠️ **(unresolved, raised by @cstamas, @ascheman, and every prior review) `maven-4.0.x` matrix leg is a permanent silent no-op.** `-P?versions-update` prevents a build failure when the profile is absent on `maven-4.0.x` — but the core issue is a property name mismatch: `maven-4.0.x`'s `impl/maven-core/pom.xml` uses `version.maven-*-plugin` property names, while the workflow passes `-DincludeProperties="lifecycle.maven-clean-plugin,..."`. Those `lifecycle.*` properties do not exist on that branch. `versions:update-properties` has nothing to update, `git diff --quiet` is always true, and the leg exits `"No updates found"` every weekly run without ever creating a PR. **Simplest fix** — restrict to `master` until the rename is backported: ```suggestion branch: [master] ``` Alternatively, backport the `lifecycle.*` rename to `maven-4.0.x` and add the `versions-update` profile there too (more work, but gives automated updates for the 4.0.x release branch). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
