gnodet-bot commented on PR #13166:
URL: https://github.com/apache/maven/pull/13166#issuecomment-5725848260

   ⚠️ **(unresolved, raised by @cstamas, @ascheman, and every prior review) 
`maven-4.0.x` matrix leg is still a permanent silent no-op.**
   
   `maven-4.0.x` still uses `version.maven-*-plugin` property names (confirmed 
from the branch — unchanged). The workflow runs with 
`-DincludeProperties="lifecycle.maven-clean-plugin,..."`. On `maven-4.0.x`:
   
   - `-P?versions-update` → profile absent → no property→artifact mapping 
configured
   - `-DincludeProperties="lifecycle.maven-*-plugin"` → those properties don't 
exist in `maven-4.0.x`'s `impl/maven-core/pom.xml`
   - `versions:update-properties` has nothing to update → `git diff --quiet` is 
always true → prints "No updates found" every run
   
   This leg has never produced a PR and never will under the current setup.
   
   **Fix options:**
   1. Restrict the matrix to `[master]` until the `lifecycle.*` property rename 
is backported to `maven-4.0.x`:
      ```yaml
      matrix:
        branch: [master]
      ```
   2. Backport the `lifecycle.*` rename to `maven-4.0.x` and add the 
`versions-update` profile there too.
   
   Option 1 is the safer immediate fix — it avoids touching the release branch 
and makes the actual behavior explicit.
   
   _This comment was generated by an AI agent, Hermès on behalf of @gnodet._
   
   <!-- reviewer: gnodet-bot -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to