gnodet-bot commented on code in PR #13166:
URL: https://github.com/apache/maven/pull/13166#discussion_r4044197182
##########
impl/maven-core/src/main/java/org/apache/maven/lifecycle/PluginVersions.java:
##########
@@ -27,6 +27,7 @@
* <p>
* Versions are read from {@code plugin-versions.properties}, which is filtered
* at build time from POM properties ({@code version.maven-<name>-plugin}).
+ * The properties file uses {@code lifecycle.<name>-plugin} keys.
Review Comment:
🔧 **(nit) Stale Javadoc on the preceding line.** The added line 30 correctly
documents the `lifecycle.<name>-plugin` keys used in the properties file. But
line 29 still says the values are filtered from POM properties `{@code
version.maven-<name>-plugin}` — which no longer exist on `master` after this
rename. Lines 29–30 now contradict each other: line 29 says the source is
`version.maven-*`, line 30 says `lifecycle.*`.
Fix line 29 to match:
```suggestion
* at build time from POM properties ({@code lifecycle.maven-<name>-plugin}).
* The properties file uses {@code lifecycle.<name>-plugin} keys.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
