gnodet-bot commented on code in PR #13166: URL: https://github.com/apache/maven/pull/13166#discussion_r4042651467
########## .github/workflows/update-lifecycle-plugins.yml: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Update lifecycle plugin versions + +on: + schedule: + # Every Monday at 08:00 UTC + - cron: '0 8 * * 1' + workflow_dispatch: + +permissions: + contents: read + +jobs: + update-lifecycle-plugins: + runs-on: ubuntu-latest + permissions: + contents: write + pull-requests: write + strategy: + fail-fast: false + matrix: + branch: [master, maven-4.0.x] + steps: + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + ref: ${{ matrix.branch }} + persist-credentials: false + + - uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1 + with: + java-version: '21' + distribution: 'temurin' + cache: maven + + - name: Update lifecycle plugin versions + run: | + mvn -B versions:update-properties \ + -P?versions-update \ + -DallowMajorUpdates=false \ + -DincludeProperties="lifecycle.clean-plugin,lifecycle.compiler-plugin,lifecycle.deploy-plugin,lifecycle.ear-plugin,lifecycle.ejb-plugin,lifecycle.install-plugin,lifecycle.jar-plugin,lifecycle.plugin-plugin,lifecycle.rar-plugin,lifecycle.resources-plugin,lifecycle.site-plugin,lifecycle.surefire-plugin,lifecycle.war-plugin" \ Review Comment: ⚠️ **[NOT RESOLVED] `maven-4.0.x` leg is still a no-op.** `-P?versions-update` makes the profile optional — Maven won't fail if absent. But on `maven-4.0.x`, the properties in `impl/maven-core/pom.xml` are still named `version.maven-*-plugin` (not `lifecycle.*`). So `-DincludeProperties="lifecycle.clean-plugin,..."` finds no matching properties in that branch's POM, and without the profile the artifact→property mappings are also absent. The step runs, touches nothing, and exits at "No lifecycle plugin version changes detected." — silently, every week. The fix depends on intended design: - **Option A (recommended):** Backport the property rename to `maven-4.0.x` (i.e. apply the same `lifecycle.*` rename to that branch). The `-P?` fallback then correctly skips the profile on a future branch that lacks it, but the `maven-4.0.x` leg works once the rename is in place. - **Option B:** Keep `version.maven-*-plugin` names on `maven-4.0.x` and use those in `-DincludeProperties` for that matrix leg (branch-specific command), along with adding the profile to `maven-4.0.x`. The `maven-4.0.x` matrix leg provides zero value in its current form and must be fixed before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
