gnodet-bot commented on code in PR #13166: URL: https://github.com/apache/maven/pull/13166#discussion_r4041451619
########## .github/workflows/update-lifecycle-plugins.yml: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Update lifecycle plugin versions + +on: + schedule: + # Every Monday at 08:00 UTC + - cron: '0 8 * * 1' + workflow_dispatch: + +permissions: + contents: read + +jobs: + update-lifecycle-plugins: + runs-on: ubuntu-latest + permissions: + contents: write + pull-requests: write + strategy: + fail-fast: false + matrix: + branch: [master, maven-4.0.x] Review Comment: ⚠️ **[Unresolved — raised by @cstamas and @ascheman] `maven-4.0.x` matrix leg is a no-op.** This PR adds the `versions-update` profile to `pom.xml` on `master` only. When the workflow matrix checks out `maven-4.0.x` and runs `mvn -f impl/maven-core -Pversions-update …`, the root `pom.xml` on `maven-4.0.x` does not have this profile — Maven silently skips or warns "profile not found". The `maven-4.0.x` leg never produces a PR. The profile needs to be backported to `maven-4.0.x`, or the matrix should be limited to `[master]` until it is: ```suggestion branch: [master] ``` ########## pom.xml: ########## @@ -1302,5 +1302,157 @@ under the License. </plugins> </build> </profile> + <profile> + <!-- + This profile is NEVER activated during a normal build. + It declares the 13 Maven lifecycle plugins under pluginManagement, Review Comment: 📝 **(nit) Comment says “pluginsManagement” but no `<pluginManagement>` block exists in this profile.** The profile configures `versions-maven-plugin`’s `<configuration><properties>` — not a `<pluginManagement>` section. The comment description of the mechanism is inaccurate. Also the example command shows `toolbox:plugin-versions` without a version, while the workflow pins `toolbox:0.16.0:plugin-versions`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
