[ 
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004462#comment-17004462
 ] 

Herve Boutemy commented on MSHADE-339:
--------------------------------------

bq. Surely enough, if something so obvious as the file extension would change, 
it would make some existing ITs fail (I hope)...

from the initial implementation in MSHADE-158 
http://svn.apache.org/viewvc?view=revision&revision=1543990 , I fear there is 
absolutely no IT checking anything about this case...

(and reading MSHADE-158, the request about improving documentation for the new 
parameter seems to have been neglected: this one would also be useful to 
improve)
then if you did not test the update with one of your favorite project that uses 
the feature, any change in code is just hazardous guessing about the effective 
result vs the intent :)

> Shaded test jar has wrong type "jar"
> ------------------------------------
>
>                 Key: MSHADE-339
>                 URL: https://issues.apache.org/jira/browse/MSHADE-339
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2, 3.2.2
>            Reporter: Peter De Maeyer
>            Priority: Minor
>             Fix For: 3.2.2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to