[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004341#comment-17004341
]
Peter De Maeyer commented on MSHADE-339:
----------------------------------------
{quote}
and while at it, shouldn't the "tests" classifier be removed from the call,
since it is implicit in "test-jar" type?
{quote}
That's not correct - the classifier is not implicit. "tests" is the _default_
classifier, but can be explicitly overridden to be anything.
See MSOURCES-124 for a more elaborate explanation.
The Shade plugin only deals well with the default classifiers, but doesn't
properly handle non-default classifiers.
I've made another bug for that which I intend to fix at some point too, but
let's first fix the default classifier already (the scope of _this_ issue).
{quote}
one question: is this little code inconsistency breaking anything?
{quote}
Types and classifiers are used to look up dependencies, so if a dependency is
attached with the wrong type, a project that depends on it may not find back
the dependency.
Hence, I think it will break projects that depend on it, which are processed
later in the "Maven reactor processing chain" (not sure if that is a correct
term).
I suppose I could try and write an IT test scenario that illustrates what can
go wrong. I didn't bother initially because it takes some effort and the fix is
obvious enough, but if you really like I can try...
> Shaded test jar has wrong type "jar"
> ------------------------------------
>
> Key: MSHADE-339
> URL: https://issues.apache.org/jira/browse/MSHADE-339
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 2.2, 3.2.2
> Reporter: Peter De Maeyer
> Priority: Minor
> Fix For: 3.2.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
