[ 
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004566#comment-17004566
 ] 

Peter De Maeyer commented on MSHADE-339:
----------------------------------------

{quote}
 fear there is absolutely no IT checking anything about this case
{quote}

Actually, there is :-). It's the one that I wrote myself in the context of 
MSHADE-284. See 
[master/src/it/MSHADE-284_shadeTestJar/verify.groovy|https://github.com/apache/maven-shade-plugin/blob/master/src/it/MSHADE-284_shadeTestJar/verify.groovy],
 lines 37-52: those assertions would have failed if the extension had suddenly 
changed to "test-jar". I double-checked just now by running the test and 
inspecting the resulting project in the {{target/}} directory - I confirm that 
the extension is still "jar" after my fix.

Still, I'll (try to) add an IT to illustrate what can go wrong if we don't fix 
this issue. Stay tuned.

> Shaded test jar has wrong type "jar"
> ------------------------------------
>
>                 Key: MSHADE-339
>                 URL: https://issues.apache.org/jira/browse/MSHADE-339
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2, 3.2.2
>            Reporter: Peter De Maeyer
>            Priority: Minor
>             Fix For: 3.2.2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to