[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004429#comment-17004429
]
Herve Boutemy commented on MSHADE-339:
--------------------------------------
[~peterdm] thank you for your feedback
bq. That's not correct - the classifier is not implicit. "tests" is the default
classifier for "test-jar" type, but can be explicitly overridden to be anything.
yes, it can be overridden, when necessary (then default value is implicit: we
fully agree): in this case it is not necessary, since it is the default value.
Then why override the default value with the same value?
bq. I suppose I could try and write an IT test scenario that illustrates what
can go wrong. I didn't bother initially because it takes some effort and the
fix is obvious enough, but if you really like I can try...
I think an IT would be useful (perhaps updating an existing IT, if one was
written for MSHADE-158): from experience, these little one liner changes are
the most risky, because "they are obvious" then we discover that the effect is
not limited to what was obvious :)
> Shaded test jar has wrong type "jar"
> ------------------------------------
>
> Key: MSHADE-339
> URL: https://issues.apache.org/jira/browse/MSHADE-339
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 2.2, 3.2.2
> Reporter: Peter De Maeyer
> Priority: Minor
> Fix For: 3.2.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
