[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004431#comment-17004431
]
Herve Boutemy commented on MSHADE-339:
--------------------------------------
[~rfscholte]
bq. In the end this PR has will still give you the same result.
Is it an opinion based on pure logic, or result of tests? I've learned in the
past to avoid pure opinions, since effective results a may vary...
bq. That said: artifacts have an extension, not a type (that's for dependencies)
yes, we should probably update MavenProjectHelper.attachArtifact API
https://maven.apache.org/ref/3.6.3/maven-core/apidocs/org/apache/maven/project/MavenProjectHelper.html#attachArtifact-org.apache.maven.project.MavenProject-java.lang.String-java.io.File-
perhaps it's just the attribute name that is just wrongly named as
{{artifactType}} (then implies default classifier) when it is in reality just
{{artifactExtension}}
but in this case, the PR won't work, since the extension from a call with
"test-jar" would be ".test-jar"...
these types of issues are exactly why I don't want to just rely on "pure
logic", since it seems the initial logic in Maven core may be half baked
> Shaded test jar has wrong type "jar"
> ------------------------------------
>
> Key: MSHADE-339
> URL: https://issues.apache.org/jira/browse/MSHADE-339
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 2.2, 3.2.2
> Reporter: Peter De Maeyer
> Priority: Minor
> Fix For: 3.2.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
