benwtrent commented on PR #14963:
URL: https://github.com/apache/lucene/pull/14963#issuecomment-3321371929
Hey @shubhamvishu sorry, this fell off my radar!
Those benchmark numbers are pretty crazy!
I can give a fuller review if you deem it ready :).
Some initial feed back:
- readers shouldn't ever know about this new parameter. They should just
check to see if there is a graph. If not, be smart about it. I am not 100% sure
how this will behave with BWC and not a new format. But intuitively it SHOULD
work as the reader just needs to check if the graph is there or not. The on
disk format isn't really changing...
- I am confused by this `String.length()*10` thing. Why not just use
numbers directly?
All the conflicts need updating :/
I would also like a benchmark with many random commits (e.g. simulating
random commits and searches) to see how it all behaves. I still slightly worry
about NRT and tiny segments. Intuitively, they should be fine as we would
likely bypass the graph anyways on search, but I have learned never to trust my
intuition when I can benchmark it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
