shubhamvishu commented on PR #14963: URL: https://github.com/apache/lucene/pull/14963#issuecomment-3336033870
@benwtrent Thank you Ben, really appreciate you jumping in to make those changes. > I removed the string logic thing...we can adjust that back if you want to. But, we should likely just do Math.log10 if that is what we care about. Yes, I agree. We can confirm once if that is not having any negative impact. > fixed the merges, it compiles and runs, maybe its all good? Will need to double check everything Yeah, only other thing I think left is fixing the tests. They all assume that there will a HNSW graph. I don't know if there is any cleaner way to fix these (other than plumbing each of those) but I'll look into fixing the tests from here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
