shubhamvishu commented on PR #14963: URL: https://github.com/apache/lucene/pull/14963#issuecomment-3335963165
> readers shouldn't ever know about this new parameter. They should just check to see if there is a graph. If not, be smart about it. I am not 100% sure how this will behave with BWC and not a new format. But intuitively it SHOULD work as the reader just needs to check if the graph is there or not. The on disk format isn't really changing... @benwtrent Makes sense, we can remove it. We are anyways not using in anywhere on the reader. I also think there should be no issue with BWC. > I am confused by this String.length()*10 thing. Why not just use numbers directly? This was based on the [above comment](https://github.com/apache/lucene/pull/14963#discussion_r2248862786) from Adrien about choosing the graph creation threshold from `k` as where 1 order of magnitude higher. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
