benwtrent commented on code in PR #14963:
URL: https://github.com/apache/lucene/pull/14963#discussion_r2392733261
##########
lucene/CHANGES.txt:
##########
@@ -140,7 +140,9 @@ New Features
* GITHUB#15176: Add `[Float|Byte]VectorValues#rescorer(element[])` interface
to allow optimized rescoring of vectors.
(Ben Trent)
-* GITHUB#15169: Add codecs for 4 and 8 bit Optimized Scalar Quantization
vectors (Trevor McCulloch)
+* GITHUB#15169, GITHUB#15223: Add codecs for 4 and 8 bit Optimized Scalar
Quantization vectors. The new format
+ `Lucene104HnswScalarQuantizedVectorsFormat` replaces the now legacy
`Lucene99HnswScalarQuantizedVectorsFormat`
Review Comment:
there was a bit of an issue with main branch recently and it needed to be
restored. So the commits might be out of alignment. I think your branch needs
to have main merged back in or something to fix the changes.
##########
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##########
@@ -3277,4 +3278,9 @@ public Executor
getIntraMergeExecutor(MergePolicy.OneMerge merge) {
return intraMergeExecutor;
}
}
+
+ public static boolean hasGraphPresent(int k, int size) {
+ int expectedVisitedNodes = expectedVisitedNodes(k, size);
+ return size > expectedVisitedNodes && expectedVisitedNodes > 0;
+ }
Review Comment:
This is very trappy. This sort of assumes that the test case knows the logic
that makes a graph exist or not.
Something better might be adjust `TestUtil.getDefaultCodec()` to set the
threshold for building the graph to `0` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
