benwtrent commented on PR #14963: URL: https://github.com/apache/lucene/pull/14963#issuecomment-3336008795
@shubhamvishu I pushed up a commit: - I removed the string logic thing...we can adjust that back if you want to. But, we should likely just do `Math.log10` if that is what we care about. - I removed the buffered vectors thing (just using the underlying vectors) - adjusted the api and removed the input to the reader (I think) - fixed the merges, it compiles and runs, maybe its all good? Will need to double check everything -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org