shubhamvishu commented on PR #14963: URL: https://github.com/apache/lucene/pull/14963#issuecomment-3353509476
@benwtrent I fixed the failing tests in the latest commit. They were making assumptions that we always do HNSW and since many of those don't create high cardinality graphs it was causing failures. One way would have been to just increase the number of docs for some of them which create many vectors(but that might have increased the time those take to test; but did that with just one test I think). Others I mostly updated to check if there would be graph present or not. There are some refactoring opportunities in the testing I could think of like to test more random behaviors like when this optimization OFF vs ON (default is on) and some more simplifications but for now I didn't focus much on that and kept it mostly to make all tests happy in the most straightforward way. Maybe we can make these tests more random in a followup change? Looking for your feedback. I'll also post the latest upstream numbers shortly with the latest changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
