jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2050117622
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##########
@@ -53,11 +59,22 @@ public LeafCollector getLeafCollector(LeafReaderContext
context) throws IOExcept
// The segment has no values, nothing to do.
throw new CollectionTerminatedException();
}
+
+ // We can use multi range traversal logic to collect the histogram on
numeric
+ // field indexed as point range query for MATCH_ALL cases
+ final PointValues pointValues = context.reader().getPointValues(field);
+ if (query instanceof MatchAllDocsQuery &&
!context.reader().hasDeletions()) {
Review Comment:
Yes, I will open follow-up once we are close to merging this PR. I will keep
this conversation open, until the issue is created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
