jainankitk commented on PR #14439: URL: https://github.com/apache/lucene/pull/14439#issuecomment-2819914834
@stefanvodita - Thanks for a prompt review. Addressed most of the review comments. Adding JMH benchmark instead of the not so useful performance test added earlier. The benchark results demonstrate significant increase in throughput with increasing # documents and bucket width (lesser buckets mean less low level traversal in point range tree and more documents collected in bulk): ``` Benchmark (bucketWidth) (docCount) (pointEnabled) Mode Cnt Score Error Units HistogramCollectorBenchmark.collectHistogram 5000 500000 true thrpt 3 2114.002 ± 46.852 ops/s HistogramCollectorBenchmark.collectHistogram 5000 500000 false thrpt 3 1236.532 ± 724.312 ops/s HistogramCollectorBenchmark.collectHistogram 5000 5000000 true thrpt 3 220.636 ± 17.688 ops/s HistogramCollectorBenchmark.collectHistogram 5000 5000000 false thrpt 3 147.054 ± 37.055 ops/s HistogramCollectorBenchmark.collectHistogram 25000 500000 true thrpt 3 9788.181 ± 4388.445 ops/s HistogramCollectorBenchmark.collectHistogram 25000 500000 false thrpt 3 1227.537 ± 21.222 ops/s HistogramCollectorBenchmark.collectHistogram 25000 5000000 true thrpt 3 856.278 ± 840.625 ops/s HistogramCollectorBenchmark.collectHistogram 25000 5000000 false thrpt 3 145.322 ± 86.603 ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org