jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2049741831
##########
lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/plain/histograms/TestHistogramCollectorManager.java:
##########
@@ -115,6 +117,38 @@ public void testSkipIndexWithSortAndLowInterval() throws
IOException {
.setCodec(TestUtil.alwaysDocValuesFormat(new
Lucene90DocValuesFormat(3))));
}
+ public void testMultiRangePointTreeCollector() throws IOException {
Review Comment:
Okay, ran the test and few times and I understand what the error is.
```
java.lang.AssertionError: expected:<[1=>978, 3=>1004, 4=>1000, 2=>1022,
0=>996]> but was:<[4=>5000, 1=>4890, 2=>5110, 3=>5020, 0=>4980]>
```
The actual values are 5 times of the expected. Essentially, the logic
efficiently collects values for entire segment and in case of intra-segment
concurrency, it ends up collecting 5 times. I am wondering if the collectors
can be aware of intra-segment concurrency, and not use the optimized path when
it is enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
