jainankitk commented on PR #14439: URL: https://github.com/apache/lucene/pull/14439#issuecomment-2810960212
I have updated the PR, and the code flow is like below now: * `HistogramCollector` overrides the `setWeight` for accessing the underlying `Query` * To keep things simple, just optimizing for `MATCH_ALL_DOCS` query and no deleted documents for now * Optimized path is enabled only if `pointTree` is built for the field * There are few other conditions for optimized path being enabled. Being conservative for now, and fallback to original. * Add small unit test to verify working as expected Will add few more unit tests, once I get some feedback on the code changes. Can also include small performance unit test that demonstrates, pointTree based collection is faster than the docValues based collector. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org