stefanvodita commented on PR #14439: URL: https://github.com/apache/lucene/pull/14439#issuecomment-2794700870
I didn't mean to imply that the two solutions are the same, apologies if that's how it came across. > Need some inputs from the community on how it can be plugged correctly into the HistogramCollector Let me know if this doesn't answer the question @jainankitk, maybe you'd already gone through this and you were looking for a different answer. I think you could start in `HistogramCollector.getLeafCollector` ([code](https://github.com/apache/lucene/blob/4957766fcee52c534d786e3948fadf6d36c9779f/lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java#L50)). Right now we throw an exception if the field we're using isn't doc values ([code](https://github.com/apache/lucene/blob/4957766fcee52c534d786e3948fadf6d36c9779f/lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java#L59)). You'd need a new branch for the case you want to implement and a new `LeafCollector`, similar to the ones already in the file. Having that would make it easier to think through the next steps. At a higher level, I'm curious if you had a use-case in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
