jainankitk commented on PR #14439:
URL: https://github.com/apache/lucene/pull/14439#issuecomment-2814740258
Addressed most of the review comments. Ran small performance benchmark to
see the difference, and we can see some even with small number of documents:
Bulk time is new approach, and skip index time is the existing
With 100k docs, and 5k bucketWidth
```
1> Bulk time was : 10593417 vs skip index time : 12941417
1> Bulk time was : 1006750 vs skip index time : 3241959
1> Bulk time was : 770916 vs skip index time : 4690875
1> Bulk time was : 870917 vs skip index time : 2621291
1> Bulk time was : 754709 vs skip index time : 3175500
1> Bulk time was : 1389750 vs skip index time : 2557125
1> Bulk time was : 788125 vs skip index time : 4633541
1> Bulk time was : 767125 vs skip index time : 5078917
1> Bulk time was : 727208 vs skip index time : 6333083
1> Bulk time was : 755250 vs skip index time : 3179917
```
With 250k documents, and 10k bucketWidth:
```
1> Bulk time was : 14125250 vs skip index time : 20235666
1> Bulk time was : 915583 vs skip index time : 15929834
1> Bulk time was : 886959 vs skip index time : 15842375
1> Bulk time was : 904667 vs skip index time : 10911500
1> Bulk time was : 801959 vs skip index time : 10846750
1> Bulk time was : 844834 vs skip index time : 14980917
1> Bulk time was : 855209 vs skip index time : 5865500
1> Bulk time was : 804334 vs skip index time : 15966667
1> Bulk time was : 805042 vs skip index time : 11613791
1> Bulk time was : 830958 vs skip index time : 11036833
```
As we can see the difference is bit more pronounced with increasing number
of documents and wide enough bucketWidth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
