easyice commented on PR #12841: URL: https://github.com/apache/lucene/pull/12841#issuecomment-1850424855
The performance of the new approach seems regressed a bit more on java21_benchMMapDirectoryInputs_readGroupVInt, here is the difference of speed up relative to the baseline. | | task | previous commit | current | diff | |--------|------------------------------------------|------------------|--------------|--------| | java17 | benchByteBuffersIndexInput_readGroupVInt | 2.3x faster | 2.1x faster | -0.2x | | java17 | benchNIOFSDirectoryInputs_readGroupVInt | 1.15x faster | 1.09x faster | -0.06x | | java21 | benchByteBuffersIndexInput_readGroupVInt | 2.7x faster | 3.0x faster | +0.3x | | java21 | benchNIOFSDirectoryInputs_readGroupVInt | 1.75x faster | 1.24x faster | -0.51x | | java21 | benchMMapDirectoryInputs_readGroupVInt | 1.74x faster | 1.3x faster | -0.44x | Benchmark delta: **Previous commit:** java21 ``` Benchmark (size) Mode Cnt Score Error Units GroupVIntBenchmark.benchByteArrayDataInput_readGroupVInt 64 thrpt 5 11.463 ± 0.371 ops/us GroupVIntBenchmark.benchByteArrayDataInput_readVInt 64 thrpt 5 4.631 ± 0.970 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVInt 64 thrpt 5 4.346 ± 1.094 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVIntBaseline 64 thrpt 5 1.611 ± 0.408 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVInt 64 thrpt 5 9.099 ± 1.438 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 5.207 ± 0.646 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readVInt 64 thrpt 5 3.998 ± 0.667 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVInt 64 thrpt 5 8.702 ± 0.513 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 4.967 ± 0.319 ops/us ``` java17 ``` Benchmark (size) Mode Cnt Score Error Units GroupVIntBenchmark.benchByteArrayDataInput_readGroupVInt 64 thrpt 5 10.309 ± 1.592 ops/us GroupVIntBenchmark.benchByteArrayDataInput_readVInt 64 thrpt 5 4.236 ± 0.464 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVInt 64 thrpt 5 4.755 ± 0.426 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVIntBaseline 64 thrpt 5 2.012 ± 0.142 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVInt 64 thrpt 5 7.233 ± 0.759 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 7.471 ± 0.274 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readVInt 64 thrpt 5 3.854 ± 0.541 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVInt 64 thrpt 5 6.399 ± 1.494 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 5.557 ± 0.147 ops/us ``` **New approach:** java17 ``` Benchmark (size) Mode Cnt Score Error Units GroupVIntBenchmark.benchByteArrayDataInput_readGroupVInt 64 thrpt 5 4.715 ± 3.024 ops/us GroupVIntBenchmark.benchByteArrayDataInput_readVInt 64 thrpt 5 4.085 ± 0.352 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVInt 64 thrpt 5 4.194 ± 2.129 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVIntBaseline 64 thrpt 5 1.985 ± 0.594 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVInt 64 thrpt 5 6.946 ± 2.249 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 7.198 ± 1.596 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readVInt 64 thrpt 5 3.859 ± 0.345 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVInt 64 thrpt 5 5.845 ± 1.214 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 5.324 ± 0.470 ops/us ``` java21 ``` Benchmark (size) Mode Cnt Score Error Units GroupVIntBenchmark.benchByteArrayDataInput_readGroupVInt 64 thrpt 5 10.705 ± 1.000 ops/us GroupVIntBenchmark.benchByteArrayDataInput_readVInt 64 thrpt 5 4.785 ± 0.986 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVInt 64 thrpt 5 4.704 ± 1.458 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVIntBaseline 64 thrpt 5 1.518 ± 0.428 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVInt 64 thrpt 5 6.948 ± 3.155 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 5.312 ± 0.223 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readVInt 64 thrpt 5 3.374 ± 2.154 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVInt 64 thrpt 5 6.367 ± 1.217 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 5.095 ± 0.544 ops/us ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
