uschindler commented on PR #12841: URL: https://github.com/apache/lucene/pull/12841#issuecomment-1851570021
> Could we consider not changing `MemorySegmentIndexInput` for java 19 and java20? As a preview feature , it seems reasonable that we only do optimizations in higher versions, and they are not Long-Term-Support (LTS) releases. but if you still feel we should to support them, i will do it. Hi, it is up to you, but at some point I will copy paster the code over, because I try to keep the 3 impls aligned to each other (I have some semi-automatic process) for updates. Java 22 is ongoing and will be merged soon. There is also the problem: It would be slower in Java 19 than in Java 18 or Java 17, if we also improve the `ByteBufferIndexInput` (without 's', see below). So I would like you to just copypaste the one method to the other impl. It is tested by Jenkins automatically once we have it merged into main branch. What is much more important: Please add the implementation for `ByteBufferIndexInput` (which is responsible for `MMapDirectory` before Java 18. Then you should see speedup with Java 17, too. I am in generally not sure if this should be backported into the 9.x branch of Lucene unless we have performance tests for Java 11. In Java 11 the lambdas may be a problem and slowdown. So I would say: Let's do this only in main branch (Lucene 10.x). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
