uschindler commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1422441239
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java:
##########
@@ -303,6 +304,30 @@ public byte readByte(long pos) throws IOException {
}
}
+ @Override
+ public void readGroupVInts(long[] dst, int limit) throws IOException {
+ int i;
+ try {
+ for (i = 0; i <= limit - 4; i += 4) {
Review Comment:
oooooh, no better not on default. DataInput by default reads the bytes in a
loop (e.g., when it is an InputStreamDataInput). But in that case the
specialized method should never be used. Maybe add this to the documentation.
We should add some hint in the Utility's class that the specialized method can
only be used if and only if:
- input supports random access with `IntReader` and is able to return a
maximum size to read in randomaccess.
- calling skipBytes only changes file pointer and does *NOT* read bytes
(e.g., does not use the default impl).
Of course tests would fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
