easyice commented on PR #12841: URL: https://github.com/apache/lucene/pull/12841#issuecomment-1851319229
> I have a better idea. Lets keep the 2 different method, but do another trick: With this great idea, the performance comes back! java21 ``` Benchmark (size) Mode Cnt Score Error Units GroupVIntBenchmark.benchByteArrayDataInput_readGroupVInt 64 thrpt 5 5.458 ± 0.405 ops/us GroupVIntBenchmark.benchByteArrayDataInput_readVInt 64 thrpt 5 4.837 ± 0.502 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVInt 64 thrpt 5 4.587 ± 0.304 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVIntBaseline 64 thrpt 5 1.799 ± 0.084 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVInt 64 thrpt 5 9.815 ± 0.255 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 5.517 ± 0.230 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readVInt 64 thrpt 5 4.294 ± 0.060 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVInt 64 thrpt 5 8.928 ± 0.313 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 5.121 ± 0.328 ops/us ``` java17 ``` Benchmark (size) Mode Cnt Score Error Units GroupVIntBenchmark.benchByteArrayDataInput_readGroupVInt 64 thrpt 5 4.093 ± 2.429 ops/us GroupVIntBenchmark.benchByteArrayDataInput_readVInt 64 thrpt 5 3.530 ± 1.120 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVInt 64 thrpt 5 3.648 ± 3.295 ops/us GroupVIntBenchmark.benchByteBuffersIndexInput_readGroupVIntBaseline 64 thrpt 5 1.644 ± 0.844 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVInt 64 thrpt 5 6.992 ± 1.110 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 7.188 ± 1.340 ops/us GroupVIntBenchmark.benchMMapDirectoryInputs_readVInt 64 thrpt 5 3.690 ± 0.617 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVInt 64 thrpt 5 5.587 ± 4.289 ops/us GroupVIntBenchmark.benchNIOFSDirectoryInputs_readGroupVIntBaseline 64 thrpt 5 5.283 ± 0.330 ops/us ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
