uschindler commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1422507453
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java:
##########
@@ -303,6 +304,30 @@ public byte readByte(long pos) throws IOException {
}
}
+ @Override
+ public void readGroupVInts(long[] dst, int limit) throws IOException {
+ int i;
+ try {
+ for (i = 0; i <= limit - 4; i += 4) {
Review Comment:
> +1, we can make sure the static method caller have an efficient
implementation of `skipBytes()`(base on `seek()`), Just i guess the `seek()`
has an impact on performance, let me try..
Yes, if `skipBytes()` is not efficient (InputStream based DataInput), you
can't use that specialized method anyways. IndecInput has an efficient default
implementation, so no need to change anything. So we do not need to optimize
anything.
Just call skipBytes() and test performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
