uschindler commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1423722848
##########
lucene/core/src/java/org/apache/lucene/store/ByteBuffersIndexInput.java:
##########
@@ -205,6 +205,12 @@ public void readLongs(long[] dst, int offset, int length)
throws IOException {
in.readLongs(dst, offset, length);
}
+ @Override
+ public void readGroupVInt(long[] docs, int limit) throws IOException {
Review Comment:
this should be protected.
Why do we not have an improved implemenattion here? Last parameter should be
"offset".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
