gf2121 commented on code in PR #12699:
URL: https://github.com/apache/lucene/pull/12699#discussion_r1402138507
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/IntersectTermsEnumFrame.java:
##########
@@ -142,12 +138,20 @@ public void setState(int state) {
}
void load(BytesRef frameIndexData) throws IOException {
- if (frameIndexData != null) {
- floorDataReader.reset(frameIndexData.bytes, frameIndexData.offset,
frameIndexData.length);
- // Skip first long -- has redundant fp, hasTerms
- // flag, isFloor flag
- final long code = ite.fr.readVLongOutput(floorDataReader);
- if ((code & Lucene90BlockTreeTermsReader.OUTPUT_FLAG_IS_FLOOR) != 0) {
+ floorDataReader.reset(frameIndexData.bytes, frameIndexData.offset,
frameIndexData.length);
+ load(ite.fr.readVLongOutput(floorDataReader));
+ }
+
+ void load(SegmentTermsEnum.OutputAccumulator outputAccumulator) throws
IOException {
+ outputAccumulator.prepareRead();
+ final long code = ite.fr.readVLongOutput(outputAccumulator);
+ outputAccumulator.setFloorData(floorDataReader);
+ load(code);
+ }
+
+ void load(Long boxCode) throws IOException {
Review Comment:
I called it box because we are using a big `Long`... blockCode is better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
