gf2121 commented on code in PR #12699:
URL: https://github.com/apache/lucene/pull/12699#discussion_r1391055842
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/FieldReader.java:
##########
@@ -118,13 +118,11 @@ long readVLongOutput(DataInput in) throws IOException {
* <p>Package private for testing.
*/
static long readMSBVLong(DataInput in) throws IOException {
- long l = 0L;
- while (true) {
- byte b = in.readByte();
+ byte b = in.readByte();
+ long l = b & 0x7FL;
+ while (b < 0) {
Review Comment:
Background:
https://github.com/apache/lucene/issues/12659#issuecomment-1759244758
This was a try to get back the PKLookUp speed but Luceneutil has shown that
this change does not affect performance. I kept it here because I think this
way is more consistent with the `DataInput#readVInt` and more readable. But now
I would revert it since it is not really related to the point of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
