gf2121 commented on PR #12699: URL: https://github.com/apache/lucene/pull/12699#issuecomment-1831412787
Hi @mikemccand @jpountz ! The [newest nightly benchmark](https://home.apache.org/~mikemccand/lucenebench/2023.11.28.18.03.59.html) shows we get back some speed for [PKLookUp](https://home.apache.org/~mikemccand/lucenebench/PKLookup.html), but still not as good as the performance before the merge of https://github.com/apache/lucene/pull/12631. This result is not quite same as what i saw locally, but reasonable for me as we do more `Outputs#read` anyway. Since we are [preparing for the release of 9.9.0](https://lists.apache.org/thread/6bxf0fo1ypblxn2hbdfyg38y3hc8lo9g). I'm not sure if it is an acceptable trade-off now. Should we backport this or revert https://github.com/apache/lucene/pull/12631? I'd appreciate your suggestions :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
