gf2121 commented on code in PR #12699:
URL: https://github.com/apache/lucene/pull/12699#discussion_r1402131137
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##########
@@ -104,13 +104,9 @@ public SegmentTermsEnumFrame(SegmentTermsEnum ste, int
ord) throws IOException {
suffixLengthsReader = new ByteArrayDataInput();
}
- public void setFloorData(ByteArrayDataInput in, BytesRef source) {
- final int numBytes = source.length - (in.getPosition() - source.offset);
- if (numBytes > floorData.length) {
- floorData = new byte[ArrayUtil.oversize(numBytes, 1)];
- }
- System.arraycopy(source.bytes, source.offset + in.getPosition(),
floorData, 0, numBytes);
- floorDataReader.reset(floorData, 0, numBytes);
+ public void setFloorData(SegmentTermsEnum.OutputAccumulator
outputAccumulator) {
+ outputAccumulator.setFloorData(floorDataReader);
+ rewindPos = floorDataReader.getPosition();
Review Comment:
Hmm i'm a bit confused. I think `setFloorData` changes the position of
`floorDataReader` because it calls
`floorDataReader#reset`, so we can not move this line above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
