jpountz commented on PR #12699: URL: https://github.com/apache/lucene/pull/12699#issuecomment-1832082403
+1 to not reverting #12631. The fact that our terms index used to not share prefixes properly was a bug, I'm glad it's fixed even though it may make performance slightly slower because more nodes have non-empty outputs to contribute. FWIW it looks like your change did not only help PKLookup, but possibly also [`CountTerm`](https://home.apache.org/~mikemccand/lucenebench/CountTerm.html), [`Respell`](https://home.apache.org/~mikemccand/lucenebench/Respell.html), [`Fuzzy1`](https://home.apache.org/~mikemccand/lucenebench/Fuzzy1.html) and [`Fuzzy2`](https://home.apache.org/~mikemccand/lucenebench/Fuzzy2.html). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
