gf2121 commented on code in PR #12699:
URL: https://github.com/apache/lucene/pull/12699#discussion_r1402112063
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##########
@@ -1190,4 +1176,63 @@ public void seekExact(long ord) {
public long ord() {
throw new UnsupportedOperationException();
}
+
+ static class OutputAccumulator extends DataInput {
+
+ BytesRef[] outputs = new BytesRef[16];
+ BytesRef current;
+ int num;
+ int outputIndex;
+ int index;
+
+ void push(BytesRef output) {
+ if (output != Lucene90BlockTreeTermsReader.NO_OUTPUT) {
Review Comment:
This object comparing is what we did before. I believe it is right because
we have strict
[contract](https://github.com/apache/lucene/blob/e04793d6517e17385b755f1707d59aeceaa41f15/lucene/core/src/java/org/apache/lucene/util/fst/Outputs.java#L28)
for `Outputs` operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
