rmuir commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1479355672
> Would your worries be assuaged if we created a separate `QueryBoostAttribute` class @rmuir? Then `QueryBuilder` can use that, and we can add checks for negative boosts, javadocs that say it should only be used for query time analysis, etc. It would certainly be a LOT less offensive than using FuzzyQuery's BoostAtt? But I still don't think analysis pipeline should be involved in this way, in query formulation. It is confusing in many ways, especially with boosts that will get silently dropped at index-time, confusing users. So I'd really rather us avoid analysis chain doing this stuff. it is mixing separate concerns in a very bad way: analysis chain is supposed to be about tokenization and boosts are supposed to be in the domain of higher level query parsers/MLT as it represents query intent (and also makes no sense at index time). See my comment above about whether this should even be an analyzer :) I really see it closer to "query expansion" (e.g. closer in functionality to MLT). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
