rmuir commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1479301623
> Hi @rmuir, we definitely don't want to ignore improvement recommendations, rest assured. > Sorry if I am pedantic, I just want to understand why it shouldn't be used for additional things(on top of what it was originally designed to). > Do you have more info on the "odd things about its behavior"? > Allowing negative numbers shouldn't be an issue, the vector similarity score is 0<=x<=1. > Thank you again for your time, it's genuinely much appreciated The class documents that it should not be used for this purpose. I honestly feel the documentation is good: the problem is you didn't read it. Please don't make me repeat myself here. To be clear, i'm -1 on the issue and this constitutes a veto. it can't be ignored, just fix the issue instead of merging the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
