rmuir commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1479306693
> Allowing negative numbers shouldn't be an issue, the vector similarity score is 0<=x<=1. You don't understand. Some day, someone may want to add such safety as a check to the attribute, but they won't be able to because fuzzy query relies on such things. That's a great big reason this attribute should not be used for other purposes! It was created to be applied to `TermsEnum` and not a tokenstream at all. By using an attribute on `TermsEnum`, we are able to handle this corner-case needed to accelerate top-N selection of fuzzyquery, without adding unnecessary bloat to `TermsEnum` itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
