mkhludnev commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1479396426
> i'm -1 for this PR. analyzers shouldnt be mixing with query boosts at all. it is a mixing of concerns that we should avoid: please refactor to be something other than an analyzer. Presumably expansion logic might be moved from [Word2VecSynonymFilter.java](https://github.com/apache/lucene/pull/12169/files#diff-c7476adadb37ec05d504af2eb6212ed1eae9a9a7a40da913c3d39fef5d28c8fb) into `QueryBuilder.newSynonymQuery(),.newTermQuery()`. Thus, boosting logic would be moved from analyzer into query parsing, but how to make it easily configurable and pluggable into all query parsers for may users? On top of my head ComplexQP probably can configure such pipeline. But how to turn it on&off for classic, Elastic, Solr, etc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
